From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B23F646985 for ; Mon, 31 Jul 2023 12:57:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 801C768C5A7; Mon, 31 Jul 2023 15:57:21 +0300 (EEST) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0278068C196 for ; Mon, 31 Jul 2023 15:57:14 +0300 (EEST) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-1a28de15c8aso3524096fac.2 for ; Mon, 31 Jul 2023 05:57:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690808233; x=1691413033; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=mTLGRrWnyVdwKaS6InxWoZyU7zNReg4B1ob4i4j8ciw=; b=CVIJ6nnX7IS/CZ/G1zzQALnHM8pZluJg+B14XETaPwdV7XZJBJLMS7SfxQO9RS0JpJ JOQ953tBuSqI/li7NmwDckUSWqDyEtac28zDYkHgUHyN/38ZNXMiZOiE8RLthKWfsqMq ICjak9NLEagNEaOdLRxN1YlI4pxAEmShSAnQee8kBrTmcZhAAERK23dA488w0wb+UGrD ux7nr5KXeDnZfm1cA2ckMH4zazB/kDJGtUlmozAW0dwAvzpOa0g2NIeup8ms1NIzZIPO LjgVE0dS5uGZVoHYzWZaf9Btpiie1V68JpyQ1SupRAlKQtvVVz5mZKntwOfZ63Q5FviO 2A7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690808233; x=1691413033; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mTLGRrWnyVdwKaS6InxWoZyU7zNReg4B1ob4i4j8ciw=; b=h46QJg+ZFxRHeUmV+Y33deFILkg6tyqhwdCqC/SCzoky6pjLV1GpB2uTgSjQA+Pit4 UlFfj8Zdon+/wn5CqJo8mzePj23CwkXWpuqOlxgUbffEx+SL8Y6+Oi+CJOsBXMMGDFoC xOSgi7PxfmQGPCULgOBhEJh13hIhMMpVuJZDZsQNxkAycPcN5vitdBiXSrmlKuIdvZDY 4cSAmK+gPFQbc9IMrVHcyyPZ6fTsgXkfBZGHcNoACaQC643wzyChDLO3z6tEq49i7Feh f4lT25YrczlJs3TVd1vdfhYx356XO2yU2NrMEjs/6AJmR206vLI1BoYpthmD9VZM8NUr 7WXw== X-Gm-Message-State: ABy/qLY4eSSPKVIUjjS9U1HdTjMaFT2jE7QXchao6/yVuCDhI1tI2x9H xOB3OxUkPipi4gz/x0bqVFK3q7Mbioo= X-Google-Smtp-Source: APBJJlF4l/15kKBv0OkOfpXHHt3cZ0Old4FxQmw3v8NRoauNyeXZsz1PGmfJlec0cUlGicvtU6ue2g== X-Received: by 2002:a05:6870:5611:b0:1bd:a5ea:ed7d with SMTP id m17-20020a056870561100b001bda5eaed7dmr6453159oao.7.1690808232944; Mon, 31 Jul 2023 05:57:12 -0700 (PDT) Received: from [192.168.0.16] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id r80-20020a4a3753000000b00560c9477e19sm4112489oor.7.2023.07.31.05.57.10 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 31 Jul 2023 05:57:11 -0700 (PDT) Message-ID: Date: Mon, 31 Jul 2023 09:57:24 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffprobe: Fix memleak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/31/2023 8:08 AM, Andreas Rheinhardt wrote: > Fixes Coverity issue #1524491. > Regression since e6126abc6997058ca49ee596b70611bbe367163e. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 81610c097b..5c2d4cbff1 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -2929,8 +2929,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile, > FrameData *fd; > > pkt->opaque_ref = av_buffer_allocz(sizeof(*fd)); > - if (!pkt->opaque_ref) > - return AVERROR(ENOMEM); > + if (!pkt->opaque_ref) { > + ret = AVERROR(ENOMEM); > + goto end; > + } > fd = (FrameData*)pkt->opaque_ref->data; > fd->pkt_pos = pkt->pos; > fd->pkt_size = pkt->size; LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".