Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffprobe: Fix memleak

From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffprobe: Fix memleak
Date: Mon, 31 Jul 2023 09:57:24 -0300
Message-ID: <c6e113b6-2b54-d735-5c61-58ee76a6a60c@gmail.com> (raw)
In-Reply-To: <GV1P250MB0737C3EDF15EA842378D8DC58F05A@GV1P250MB0737.EURP250.PROD.OUTLOOK.COM>

On 7/31/2023 8:08 AM, Andreas Rheinhardt wrote:
> Fixes Coverity issue #1524491.
> Regression since e6126abc6997058ca49ee596b70611bbe367163e.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   fftools/ffprobe.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c
> index 81610c097b..5c2d4cbff1 100644
> --- a/fftools/ffprobe.c
> +++ b/fftools/ffprobe.c
> @@ -2929,8 +2929,10 @@ static int read_interval_packets(WriterContext *w, InputFile *ifile,
>                   FrameData *fd;
>   
>                   pkt->opaque_ref = av_buffer_allocz(sizeof(*fd));
> -                if (!pkt->opaque_ref)
> -                    return AVERROR(ENOMEM);
> +                if (!pkt->opaque_ref) {
> +                    ret = AVERROR(ENOMEM);
> +                    goto end;
> +                }
>                   fd = (FrameData*)pkt->opaque_ref->data;
>                   fd->pkt_pos  = pkt->pos;
>                   fd->pkt_size = pkt->size;

LGTM.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".