Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Léon Spaans" <leons@gridpoint.nl>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] libavformat/hlsenc: set HTTP options before writing WebVTT HLS playlists
Date: Sun, 1 Oct 2023 16:40:43 +0200
Message-ID: <c68d2819-a06b-4e12-b227-f76bcbbee038@gridpoint.nl> (raw)

Fixes: Erroneous HTTP POST instead of HTTP PUT for WebVTT HLS variant 
playlists.

Signed-off-by: Léon Spaans <leons@gridpoint.nl>
---
  libavformat/hlsenc.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c
index 08f3746ce7..150320a880 100644
--- a/libavformat/hlsenc.c
+++ b/libavformat/hlsenc.c
@@ -1585,6 +1585,7 @@ static int hls_window(AVFormatContext *s, int 
last, VariantStream *vs)
              ret = 0;
          goto fail;
      }
+    av_dict_free(&options);
       for (en = vs->segments; en; en = en->next) {
          if (target_duration <= en->duration)
@@ -1635,8 +1636,11 @@ static int hls_window(AVFormatContext *s, int 
last, VariantStream *vs)
          ff_hls_write_end_list(byterange_mode ? hls->m3u8_out : vs->out);
       if (vs->vtt_m3u8_name) {
+        set_http_options(vs->avf, &options, hls);
          snprintf(temp_vtt_filename, sizeof(temp_vtt_filename), 
use_temp_file ? "%s.tmp" : "%s", vs->vtt_m3u8_name);
-        if ((ret = hlsenc_io_open(s, &hls->sub_m3u8_out, 
temp_vtt_filename, &options)) < 0) {
+        ret = hlsenc_io_open(s, &hls->sub_m3u8_out, temp_vtt_filename, 
&options);
+        av_dict_free(&options);
+        if (ret < 0) {
              if (hls->ignore_io_errors)
                  ret = 0;
              goto fail;
-- 
2.40.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-10-01 14:40 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-01 14:40 Léon Spaans [this message]
2023-10-01 23:16 ` Steven Liu
2023-10-02  3:50   ` Léon Spaans
2023-10-05  7:15     ` Léon Spaans
2023-10-05  7:25       ` Steven Liu
2023-10-06 14:50         ` Steven Liu
2023-10-06 21:09           ` Léon Spaans
  -- strict thread matches above, loose matches on Subject: below --
2023-10-06 21:40 Léon Spaans
2023-10-11  1:50 ` Steven Liu
2023-10-01  9:38 Léon Spaans
2023-10-01 12:43 ` Steven Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c68d2819-a06b-4e12-b227-f76bcbbee038@gridpoint.nl \
    --to=leons@gridpoint.nl \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git