[FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

[FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

[Gyan Doshi]

Can lead to printing of nonsensical negative memory usage
---
 fftools/ffmpeg.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
index 00ab1cce51..3aa2e12780 100644
--- a/fftools/ffmpeg.c
+++ b/fftools/ffmpeg.c
@@ -309,8 +309,8 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL };
 static void ffmpeg_cleanup(int ret)
 {
     if (do_benchmark) {
-        int maxrss = getmaxrss() / 1024;
-        av_log(NULL, AV_LOG_INFO, "bench: maxrss=%iKiB\n", maxrss);
+        int64_t maxrss = getmaxrss() / 1024;
+        av_log(NULL, AV_LOG_INFO, "bench: maxrss=%"PRId64"KiB\n", maxrss);
     }
 
     for (int i = 0; i < nb_filtergraphs; i++)
-- 
2.44.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

[Gyan Doshi]

On 2024-07-11 02:52 pm, Gyan Doshi wrote:
> Can lead to printing of nonsensical negative memory usage

Plan to push in 24h.

Regards,
Gyan

> ---
>   fftools/ffmpeg.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c
> index 00ab1cce51..3aa2e12780 100644
> --- a/fftools/ffmpeg.c
> +++ b/fftools/ffmpeg.c
> @@ -309,8 +309,8 @@ const AVIOInterruptCB int_cb = { decode_interrupt_cb, NULL };
>   static void ffmpeg_cleanup(int ret)
>   {
>       if (do_benchmark) {
> -        int maxrss = getmaxrss() / 1024;
> -        av_log(NULL, AV_LOG_INFO, "bench: maxrss=%iKiB\n", maxrss);
> +        int64_t maxrss = getmaxrss() / 1024;
> +        av_log(NULL, AV_LOG_INFO, "bench: maxrss=%"PRId64"KiB\n", maxrss);
>       }
>   
>       for (int i = 0; i < nb_filtergraphs; i++)

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] ffmpeg: don't truncate getmaxrss value

[Gyan Doshi]

On 2024-07-14 02:14 pm, Gyan Doshi wrote:
>
>
> On 2024-07-11 02:52 pm, Gyan Doshi wrote:
>> Can lead to printing of nonsensical negative memory usage
>
> Plan to push in 24h.

Pushed as 350146a1ea9d2d0220cc8d024125b77240e3e98d

Regards,
Gyan

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".