From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B19FB4BEFA for ; Tue, 4 Feb 2025 13:38:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DCF5A68B7AB; Tue, 4 Feb 2025 15:38:13 +0200 (EET) Received: from mail-lf1-f45.google.com (mail-lf1-f45.google.com [209.85.167.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D557968A57C for ; Tue, 4 Feb 2025 15:38:06 +0200 (EET) Received: by mail-lf1-f45.google.com with SMTP id 2adb3069b0e04-54020b0dcd2so7222004e87.1 for ; Tue, 04 Feb 2025 05:38:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1738676286; x=1739281086; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=+cN+LSy2Zytz9GZXrnr5lbqFSlPOvkie9SflTOZVGas=; b=ePIkR+8S5TgZ5wJ8SPgHRrN7PNhAlnt2GwNxqXGbcTYam45NekvaIExmVHy9n3dvdb wBYVN3OgulHdT4JO/ZtXTLmOeTcbglhdDbsOVkk7QpyPU2wT2yMFmjbQ6dAY1q9vJxpB spHU7P5mUlFQnuH80wUmKTq5CfMQYo+sErlDaAeKW2JqOePlk89m2m5WtDiW+mlFHrZO jOf03kXafY6+Q6pF189PGujG6BR0zlcgcAKOximj9lZbvWlWiVdEIL9RyRuMoBa/mQ9g wec9QLCX2Y8OwdZIvL7sj/uHilh89sK4F2LWLlO4GFusk0EKOkSUzFowxZGzl/NpW4Gx 35bA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738676286; x=1739281086; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+cN+LSy2Zytz9GZXrnr5lbqFSlPOvkie9SflTOZVGas=; b=Mcc5w5LPRBEv21pbkQvclXMCQHfPxRXi6mgbT4nxYxOcaMWK2+bNvQ2l5d3E4U1DGg +K2mzUtlv3Kgo9npidk0hx3kJ+BPMIlUHXzE+u3Y2TIUU4TJOCjvqa6GsdAntO0d5DrE MWzeKD93B7BXEhdpQlDc4MBPHqQL2FBD72nGeR7v1NYMK2RIxON1Iw0nLwn0eYWbTIN7 uG9BLaikEZRYwwEieTAdxuH3I5YZQdVuaSHuGIgmKHFz+qOFGe4lfo4L4O1se1Znk8qL HmUe3gKyeQmnOFIxpR2bJQ8/oIRVfK6/hV0nVNv7yId1mnrC2ByOwEw+MkK565tnVnMH y9uA== X-Gm-Message-State: AOJu0YxlgZr8Nr/b7omlpm9lUJLRavYl1Ct4m1PdsmqWjs+QM21z1W+t dYFSoRO2YIjOQVjo+40t+oV7IlH/6jgWEx1RWPVbGN1UwBtArLhuFA6w6b0jJ+hAJLfSHBQlI45 Uwg== X-Gm-Gg: ASbGncsbg3igGuS0eq3hmBT6nh+qWSBe1aHdRQyftWdy+33x1ZP/NZdXwbs/+yZPV/D gY10AXRCs8NTFImclsJGSbUGwtP4gCA25YNAeoKULxHnKTCERff78Ya2nRBgwg+fj+TA1QYnt8D auaU3WECIH5QcP9WZOaaafOcxEw+8Ekm69FjMZoCA6WtCivhxMMf6YGAbokyhCau5cEoq6SvOzD 824xe1LgftO/x63SAjAAXEwiykjnTK3hXVPEulbB/YYP0xxgXb8RsdFqZP3MY0zmwFn25Wmb+TB ez6fSRssT0faX1ylTpkd1H5yiYJhA7jmSUqYevkgbmd61AektwUIygwV8VTn5zmI/jdHTXv2yaI Wqgc1fPHlscE= X-Google-Smtp-Source: AGHT+IHwk87gIjPXlXl3AN6JQKQ8k/MRhmGVbRGt6Ekc3+1Sxiai/y0uNdJrchuzjibPQcURcwusGQ== X-Received: by 2002:a05:6512:ba9:b0:542:8d92:158a with SMTP id 2adb3069b0e04-543ffb25fc6mr1122606e87.10.1738676285792; Tue, 04 Feb 2025 05:38:05 -0800 (PST) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-543ebeb0ae4sm1571790e87.133.2025.02.04.05.38.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Feb 2025 05:38:05 -0800 (PST) Date: Tue, 4 Feb 2025 15:38:04 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20250204133123.1463-1-jamrial@gmail.com> Message-ID: References: <20250204133123.1463-1-jamrial@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: add compile time check for outputRecoveryPointSEI for HEVC X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 4 Feb 2025, James Almer wrote: > Fixes compilation when using API headers older than 12.0 > > Signed-off-by: James Almer > --- > libavcodec/nvenc.c | 2 ++ > libavcodec/nvenc.h | 5 +++++ > 2 files changed, 7 insertions(+) > > diff --git a/libavcodec/nvenc.c b/libavcodec/nvenc.c > index c359c2bc8a..eea3e8d703 100644 > --- a/libavcodec/nvenc.c > +++ b/libavcodec/nvenc.c > @@ -1462,7 +1462,9 @@ static av_cold int nvenc_setup_hevc_config(AVCodecContext *avctx) > hevc->intraRefreshPeriod = cc->gopLength; > hevc->intraRefreshCnt = cc->gopLength - 1; > cc->gopLength = NVENC_INFINITE_GOPLENGTH; > +#ifdef NVENC_HAVE_OUTPUT_RECOVERY_POINT_SEI > hevc->outputRecoveryPointSEI = 1; > +#endif > #ifdef NVENC_HAVE_SINGLE_SLICE_INTRA_REFRESH > hevc->singleSliceIntraRefresh = ctx->single_slice_intra_refresh; > #endif > diff --git a/libavcodec/nvenc.h b/libavcodec/nvenc.h > index 341a242cf7..d395221870 100644 > --- a/libavcodec/nvenc.h > +++ b/libavcodec/nvenc.h > @@ -78,6 +78,11 @@ typedef void ID3D11Device; > #define NVENC_HAVE_SINGLE_SLICE_INTRA_REFRESH > #endif > > +// SDK 12.0 compile time feature checks > +#if NVENCAPI_CHECK_VERSION(12, 0) > +#define NVENC_HAVE_OUTPUT_RECOVERY_POINT_SEI > +#endif > + > // SDK 12.1 compile time feature checks > #if NVENCAPI_CHECK_VERSION(12, 1) > #define NVENC_NO_DEPRECATED_RC > -- > 2.48.1 Thanks, this does indeed seem to fix compilation in my setup. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".