From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D08C447EE1 for ; Tue, 31 Oct 2023 12:17:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7116D68CCA4; Tue, 31 Oct 2023 14:17:24 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6275A68CC4D for ; Tue, 31 Oct 2023 14:17:18 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 39VCHHmI006926-39VCHHmJ006926 for ; Tue, 31 Oct 2023 14:17:17 +0200 Received: from foo.martin.st (host-97-144.parnet.fi [77.234.97.144]) by mail9.parnet.fi (Postfix) with ESMTPS id 99F09A1481 for ; Tue, 31 Oct 2023 14:17:17 +0200 (EET) Date: Tue, 31 Oct 2023 14:17:16 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <515e9509-7074-46d3-8d9c-ff2e9ea3bab3@myais.com.cn> Message-ID: References: <646d7216-e68d-4a49-821b-f358337797ef@myais.com.cn> <723ec8dd-67ca-4b69-82b8-ebde9234e32f@myais.com.cn> <515e9509-7074-46d3-8d9c-ff2e9ea3bab3@myais.com.cn> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/4] lavc/aarch64: new optimization for 8-bit hevc_epel_v X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Thu, 26 Oct 2023, Logan.Lyu wrote: > And I missed submitting a commit that was earlier than these four commits, > which caused the corrupted whitespace problem. Now I have recreated these > patches. > > In addition, I rebased it to ensure that these patches can be successfully > applied on the latest master branch. > > Please check again, thank you. Thanks, now these was possibly to apply, and they looked mostly ok, so I touched up the last details I noticed and pushed them. Things I noticed and fixed before pushing: A bunch of minor cosmetics, you had minor misindentations in a few places (that were copypasted around in lots of places), that I fixed like this: ld1 {v18.16b}, [x1], x2 .macro calc src0, src1, src2, src3 - ld1 {\src3\().16b}, [x1], x2 + ld1 {\src3\().16b}, [x1], x2 movi v4.8h, #0 movi v5.8h, #0 calc_epelb v4, \src0, \src1, \src2, \src3 @@ -461,7 +461,7 @@ function ff_hevc_put_hevc_epel_v64_8_neon, export=1 .endm 1: calc_all16 .purgem calc -2: ld1 {v8.8b-v11.8b}, [sp] +2: ld1 {v8.8b-v11.8b}, [sp] add sp, sp, #32 ret The first patch, with mostly small trivial functions, can probably be scheduled better for in-order cores. I'll send a patch if I can make them measurably faster. In almost every patch, you have loads/stores to the stack; you use the fused stack decrement nicely everywhere possible, but for the loading, you're almost always lacking the fused stack increment. I've fixed it now for this patchset, but please do keep this in mind and fix it up before submitting any further patches. I've fixed that up like this: bl X(ff_hevc_put_hevc_epel_h4_8_neon_i8mm) - ldp x5, x30, [sp] ldp x0, x3, [sp, #16] - add sp, sp, #32 + ldp x5, x30, [sp], #32 load_epel_filterh x5, x4 (In many places.) In one place, you wrote below the stack pointer before decrementing it. That's ok on OSes with a defined red zone, but we shouldn't need to assume that; I've fixed that like this: function ff_hevc_put_hevc_qpel_v48_8_neon, export=1 - stp x5, x30, [sp, #-16] - stp x0, x1, [sp, #-32] stp x2, x3, [sp, #-48]! + stp x0, x1, [sp, #16] + stp x5, x30, [sp, #32] I'll push the patchset with these changes soon. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".