From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3C06A44F8E for ; Sat, 11 Feb 2023 16:56:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 34C4168BD1D; Sat, 11 Feb 2023 18:56:54 +0200 (EET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1CAB468B9CA for ; Sat, 11 Feb 2023 18:56:47 +0200 (EET) Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4PDcFm35Mcz9sSy for ; Sat, 11 Feb 2023 17:56:44 +0100 (CET) Message-ID: Date: Sat, 11 Feb 2023 22:26:28 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230125010744.255455-1-stefasab@gmail.com> <29fe7152-55a9-8354-b018-60d4ac6e8681@gyani.pro> <20230206012523.GA338325@mariano> <20230208234118.GU1949656@pb2> <20230211023000.GE338325@mariano> <20230211162811.GA31279@mariano> From: Gyan Doshi In-Reply-To: <20230211162811.GA31279@mariano> X-Rspamd-Queue-Id: 4PDcFm35Mcz9sSy Subject: Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: extend -dts_delta_threshold option description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2023-02-11 09:58 pm, Stefano Sabatini wrote: > On date Saturday 2023-02-11 03:30:00 +0100, Stefano Sabatini wrote: >> On date Thursday 2023-02-09 00:41:18 +0100, Michael Niedermayer wrote: >>> On Mon, Feb 06, 2023 at 02:25:23AM +0100, Stefano Sabatini wrote: >> [...] >>>> Subject: [PATCH 2/2] ffmpeg: review -dts_delta_threshold and -dts_delta_error >>>> options >>>> >>>> Review handling of -dts_delta_threshold and -dts_delta_error options, >>>> specify them as floating point expressed in seconds. >>>> >>>> Also, review and simplify logic. Adjust values for tests, since in >>>> some cases the new values does not trigger the correction logic. >>>> >>>> PR: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=8252 >>>> --- >>>> doc/ffmpeg.texi | 36 ++++++++++++++++--- >>>> fftools/ffmpeg.c | 72 ++++++++++++++++++++----------------- >>>> fftools/ffmpeg.h | 2 ++ >>>> fftools/ffmpeg_demux.c | 3 ++ >>>> tests/fate/filter-audio.mak | 2 +- >>>> tests/fate/mpeg4.mak | 2 +- >>>> 6 files changed, 77 insertions(+), 40 deletions(-) >>> This seems to break a case with concat and vsync >>> ./ffmpeg -y -i 'concat:///home/michael/videos/angels.mpg|/home/michael/videos/angels.mpg' -vsync 0 -an file.avi >>> >>> ... >>> cpb: bitrate max/min/avg: 0/0/200000 buffer size: 0 vbv_delay: N/A >>> [mpeg4 @ 0x55e051b8d4c0] Invalid pts (0) <= last (11)00.00 bitrate=N/A speed= 0x >>> [vost#0:0/mpeg4 @ 0x55e051b9d700] Error submitting video frame to the encoder >>> Conversion failed! >>> >>> >>> Ill mail you the angels.mpg, i think its online somewhere but i cant >>> find it >> Fixed, now the code should be equivalent to the previous >> implementation. >> >> What happened in this case (and apparently in the other fate tests >> failing), is that some sort of limit correction is applied: >> >> detected dts:-0.041711 < dts_limit:0.358789 >> ts delta 0.5005 applied => ts_offset_discont:0.5005 dts:0.458789 >> >> preventing the invalid pts error. >> >> The limit correction, hardcoded in the ffmpeg.c code, is completely >> unrelated to the dts_delta_threshold value, no idea if it would make >> sense to make this parametric (but at least now it should be a bit >> more clear from the code/logs). > Moving the refactoring changes to a dedicated thread. > > Updating the doc extensions. LGTM. Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".