From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8668E4252B for ; Wed, 5 Jan 2022 01:17:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9863A68A7FD; Wed, 5 Jan 2022 03:17:28 +0200 (EET) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 18A67689B39 for ; Wed, 5 Jan 2022 03:17:22 +0200 (EET) Received: by mail-qk1-f175.google.com with SMTP id i130so35717193qke.3 for ; Tue, 04 Jan 2022 17:17:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=lFwYUe0BW4500vmgL76/G1t4Kqud6Y9toBijV44TLfw=; b=O0dOjOx+CL3XosdKpAdHJ17afNW63+mNAKzAIeisyiSQxYpceG//VNu18EzW+IJgjT GW1mNdeQW1oPuTj6NE7aaCTPqWSja8qELknz3Vtd6rwWKrQH+tF2XgVsKX+YQkaUwHx+ NMJ58ZT9sUDo/yBPgVAOKGZrkagotADxc9R/4x9cTyOeSDJfZ5O33GcgzaAUax4PaLVk jFz9p4o3yMoI8Cr+cIUYJodYuk8R+p/NJY1XRwcaRTepEYn4y84qKoD3xt5nPyGCw7A4 fZeIawAux1gde2NimjAz01hqKUX+H6f/5ljBCV6XHWYAtwnDPMaRmr6s/LHrcoaNnCgM n0jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=lFwYUe0BW4500vmgL76/G1t4Kqud6Y9toBijV44TLfw=; b=Y5AFLOb6oUr8gI8u0YAy2xw+46sTY/+Jh8B+NXRHF3fQ4PXoOeMy1VSZXzMl0O4m9y jwsDPBAmTXcPNgDvAFryvUu2xjhXpaPMp/d+8gaZvR6lkMs9cqiChn5e8COozR9qGaxy x30RlmdT7MloYHn+9G1pn4dyFNd8aaCjjW2tGK6B5hotDoe/URD1ebQZqqk1mbZ/kI2B yTKCSsfJbu/S/9dh31vGbrENxzWZXaNUJykh2WQm9cvIbC8M/Lp44EVYiZj4x33cN6vg tr7dnMsU+9ajoR7tnbyQoHUJxCDuc5wi4bJyYUoIeQOfJqkIBXMKz41I0XKRWNV8H4sC S8qw== X-Gm-Message-State: AOAM530mzcJkUC/rsVar2OPrMTdf/b3Ex2zo4MzdT8iNFq39wE88c+Zg y9mi2ZojIei8L3y6ZhP3YLdyJiuep7U= X-Google-Smtp-Source: ABdhPJxxhmfP91s2y4Jtw/zP49EkwQLLiRYhSuZAYYBPdUTnhIZSoYebLEQJ09+DnV0pr12uTen4qQ== X-Received: by 2002:a05:620a:1035:: with SMTP id a21mr38409144qkk.427.1641345440463; Tue, 04 Jan 2022 17:17:20 -0800 (PST) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id w9sm32680255qko.71.2022.01.04.17.17.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Jan 2022 17:17:19 -0800 (PST) Message-ID: Date: Tue, 4 Jan 2022 22:17:17 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <1641289393-4372-1-git-send-email-lance.lmwang@gmail.com> <8448DF04-D4A1-40AB-A4CF-2F4E65301300@gmail.com> <20220105011528.GA14829@gmail.com> From: James Almer In-Reply-To: <20220105011528.GA14829@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/videotoolbox: Fix undefined symbol with minimal configuration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/4/2022 10:15 PM, lance.lmwang@gmail.com wrote: > On Tue, Jan 04, 2022 at 05:51:56PM -0600, Cameron Gutman wrote: >> >>> On Jan 4, 2022, at 3:43 AM, lance.lmwang@gmail.com wrote: >>> >>> From: Limin Wang >>> >>> Please reproduced with the following minimal configure command: >>> ./configure --enable-shared --disable-all --enable-avcodec --enable-decoder=h264 --enable-hwaccel=h264_videotoolbox >>> >>> You'll get below error: >>> >>> Undefined symbols for architecture x86_64: >>> "_ff_videotoolbox_vpcc_extradata_create", referenced from: >>> _videotoolbox_start in videotoolbox.o >>> ld: symbol(s) not found for architecture x86_64 >>> clang: error: linker command failed with exit code 1 (use -v to see invocation) >>> >>> Reported-by: Cameron Gutman >>> Signed-off-by: Limin Wang >>> --- >> >> Thanks, this fixes the build break for me. Please merge it into 5.0 if possible. >> >> Tested-by: Cameron Gutman > > thank for the testing, will apply and try to merge to 5.0. A cherry-pick should work without conflicts for this change. > >> >>> libavcodec/videotoolbox.c | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c >>> index 69beb38..51d4eac 100644 >>> --- a/libavcodec/videotoolbox.c >>> +++ b/libavcodec/videotoolbox.c >>> @@ -825,11 +825,13 @@ static CFDictionaryRef videotoolbox_decoder_config_create(CMVideoCodecType codec >>> if (data) >>> CFDictionarySetValue(avc_info, CFSTR("hvcC"), data); >>> break; >>> +#if CONFIG_VP9_VIDEOTOOLBOX_HWACCEL >>> case kCMVideoCodecType_VP9 : >>> data = ff_videotoolbox_vpcc_extradata_create(avctx); >>> if (data) >>> CFDictionarySetValue(avc_info, CFSTR("vpcC"), data); >>> break; >>> +#endif >>> default: >>> break; >>> } >>> -- >>> 1.8.3.1 >>> >>> _______________________________________________ >>> ffmpeg-devel mailing list >>> ffmpeg-devel@ffmpeg.org >>> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >>> >>> To unsubscribe, visit link above, or email >>> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". >> > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".