From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ffmpeg-devel-bounces@ffmpeg.org> Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3E53D4C29F for <ffmpegdev@gitmailbox.com>; Wed, 2 Apr 2025 19:43:55 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C7CBC68AA5D; Wed, 2 Apr 2025 22:43:51 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3AC8E687A2C for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 22:43:46 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 0EB07EBB2B for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 21:45:19 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4Lc8tQuxi1RY for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 21:45:16 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 6C03FEBB20 for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 21:45:16 +0200 (CEST) Date: Wed, 2 Apr 2025 21:45:16 +0200 (CEST) From: Marton Balint <cus@passwd.hu> To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> In-Reply-To: <DM8P223MB0365066DF0B56E60A0E2C4E9BAAF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> Message-ID: <c45a5869-e39e-bc20-0559-079f0b93ca37@passwd.hu> References: <DM8P223MB0365066DF0B56E60A0E2C4E9BAAF2@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] SW's Patchsets Overview X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org> List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe> List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel> List-Post: <mailto:ffmpeg-devel@ffmpeg.org> List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help> List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>, <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe> Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org> Archived-At: <https://master.gitmailbox.com/ffmpegdev/c45a5869-e39e-bc20-0559-079f0b93ca37@passwd.hu/> List-Archive: <https://master.gitmailbox.com/ffmpegdev/> List-Post: <mailto:ffmpegdev@gitmailbox.com> On Wed, 2 Apr 2025, softworkz . wrote: > Hello everybody, > > with freshly gained push access rights, I want to act responsibly and > carefully, and also avoid unexpected surprises so I'm not going to rush > things. Due to that change, I thought it might be good to post an > overview of the patchsets I am intending to push in the near future: Thanks for the heads up. [...] > avutil/log: Replace addresses in log output with simple ids > > GitHub: https://github.com/ffstaging/FFmpeg/pull/59 > Patchwork: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=14094 To be honest, I don't like this at all. You duplicate a lot of code from avutil/log, and the implementation has quite a few problems, some of them not really fixable. - creating object IDs in the order the objects log something (what if they do not? What if it depends on loglevel?) - tracking object IDs based on their address - objects are allocated and removed at runtime, it is possible that an address will be re-used for a different object later on - linear search of addresses. A long ffmpeg process can constantly create objects during runtime, eventually completely depleting the pool and causing an extensive search for all future logs. So overall I don't think it's worth pursuing this, especially since most users won't care neither about the ID, nor about the address... Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".