Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_decode: Don't update buffer number if allocataion fail

From: "Xiang, Haihao" <haihao.xiang-at-intel.com@ffmpeg.org>
To: "ffmpeg-devel@ffmpeg.org" <ffmpeg-devel@ffmpeg.org>
Cc: "Wang, Fei W" <fei.w.wang@intel.com>
Subject: Re: [FFmpeg-devel] [PATCH v1] lavc/vaapi_decode: Don't update buffer number if allocataion fail
Date: Fri, 15 Mar 2024 02:24:43 +0000
Message-ID: <c45349ba98335d925452f698eb6369f76725a862.camel@intel.com> (raw)
In-Reply-To: <20240314003805.1022077-1-fei.w.wang@intel.com>

On Do, 2024-03-14 at 08:38 +0800, fei.w.wang-at-intel.com@ffmpeg.org wrote:
> From: Fei Wang <fei.w.wang@intel.com>
> 
> Signed-off-by: Fei Wang <fei.w.wang@intel.com>
> ---
>  libavcodec/vaapi_decode.c | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c
> index ceac769c52..cca94b5336 100644
> --- a/libavcodec/vaapi_decode.c
> +++ b/libavcodec/vaapi_decode.c
> @@ -72,17 +72,14 @@ int ff_vaapi_decode_make_slice_buffer(AVCodecContext
> *avctx,
>  
>      av_assert0(pic->nb_slices <= pic->slices_allocated);
>      if (pic->nb_slices == pic->slices_allocated) {
> -        if (pic->slices_allocated > 0)
> -            pic->slices_allocated *= 2;
> -        else
> -            pic->slices_allocated = 64;
> -
>          pic->slice_buffers =
>              av_realloc_array(pic->slice_buffers,
> -                             pic->slices_allocated,
> +                             pic->slices_allocated ? pic->slices_allocated *
> 2 : 64,
>                               2 * sizeof(*pic->slice_buffers));
>          if (!pic->slice_buffers)
>              return AVERROR(ENOMEM);
> +
> +        pic->slices_allocated = pic->slices_allocated ? pic->slices_allocated
> * 2 : 64;
>      }
>      av_assert0(pic->nb_slices + 1 <= pic->slices_allocated);

LGTM, will apply

Thanks
Haihao

>  

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".