From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D19A64311C for ; Fri, 19 Aug 2022 16:39:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BCF0568B98F; Fri, 19 Aug 2022 19:39:02 +0300 (EEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B9ACA68B073 for ; Fri, 19 Aug 2022 19:38:55 +0300 (EEST) Received: by mail-wm1-f42.google.com with SMTP id k17so2519665wmr.2 for ; Fri, 19 Aug 2022 09:38:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc; bh=AnCqsCRxd+eXRU1HZ6RbxUbq0GbLrGskxcfgAXPKCYw=; b=If3+BiP8kq7OqDCTLK4RxbLyC4iTrJu4eZ3IWzEIeiEz1PwqtH/USnR8aoHysommmF DL5u2sGT6aLm2UzP0uQ8cncYQ69IYrvnVrlrqHKHK+OmO95fPvLh11JxfT2JWv/tZVov PA08DEpZI5HLADhIgw+8qOOqOKO2KPN//SgYWhN8Ucn/tygd8rJLtpXO6Z5MYjIL+QbT yZcZNpsN4NDgo5Ma3PGTj5ixMA+jEx+zMPS22ye03DVh4hBKnzdIz2JMnlJ4rdSKQ5zh adnken0QsnKpFt7Hsc7F+MllWd9ySBs/3KnBB0E2wrliZRrt4NSD4fANWGyJufy5iOdW kGFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc; bh=AnCqsCRxd+eXRU1HZ6RbxUbq0GbLrGskxcfgAXPKCYw=; b=2n6mg/7syjECJ162oXGbRiEo40YHEZUz04DsoUxqdJJkQrZ7JKADlS+ysPK0tjaGmQ PDp26CGjXJSHeyFsXURar1CxVlJzdzjONPH/WdjYhEJf0XlmpZ9p1c/EVh/AnOCaGn4B UypKlX0/2GZI2XAkFsv0rtrfdvNBrBmQGgfv1/jooc2T0huFgGmGEruW3HdJhDb7E5Nh Nvg7+Battdc0yq01y+tkabRR8ruVaTZLU1AiigDEoGqadroqL+pZERS5OfN1+eAIM8Tw kTIu+RS7SsLyglYqwTLP/cus+f3ks164vaJcGWOhG2PBDedj8kLGrl1WEhS3LK6TWl99 hlEg== X-Gm-Message-State: ACgBeo18zb+CWoibN3SyXW+Er6WgD+sVEbNIC6J41EIF3IkMFnoPZfKD P5NcOaKEuFne6OcMSyaU6PmEXT51fkc= X-Google-Smtp-Source: AA6agR4PVW9fb9LPpgFO2bYDBfZ+9Xmm+QXtEDA1czvXmfEGUZkuZ3kZfrNTe6UnRxeGUE/r3E54zA== X-Received: by 2002:a05:600c:2114:b0:3a5:4f31:3063 with SMTP id u20-20020a05600c211400b003a54f313063mr8776622wml.50.1660927134840; Fri, 19 Aug 2022 09:38:54 -0700 (PDT) Received: from [192.168.1.106] ([149.12.10.163]) by smtp.googlemail.com with ESMTPSA id y6-20020a056000108600b002250f9abdefsm5232365wrw.117.2022.08.19.09.38.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 19 Aug 2022 09:38:54 -0700 (PDT) Message-ID: Date: Fri, 19 Aug 2022 17:38:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: ffmpeg-devel@ffmpeg.org References: <20220816144850.196109-1-derek.buitenhuis@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/17/2022 11:29 AM, Zhao Zhili wrote: >> This seems like it should be in a separate patch, though - it is >> changing a different >> behavior than what this patch does. > > OK. Will send a 2nd patch with this in the next few days. >> I did look at that, but I do not think it can be. >> >> get_stream_info_time is not equivalent to what is here. >> get_stream_info_time will >> eventually fall back to frag_stream_info->tfdt_dts, where as this >> code falls back >> to frag_stream_info->sidx_pts even if it is AV_NOPTS_VALUE. It would >> be a behavior >> change do use get_stream_info_time here. > > OK, it make sense together with `if (sc->has_sidx)`. > > No more comments from me. Applied. Thank you for your reviews :). - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".