From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx
Date: Fri, 19 Aug 2022 17:38:53 +0100
Message-ID: <c447dfd5-9d7e-a836-3b6e-3518fa99f46d@gmail.com> (raw)
In-Reply-To: <tencent_A970792DEA9A4740589A029F09ABEF4E8E08@qq.com>
On 8/17/2022 11:29 AM, Zhao Zhili wrote:
>> This seems like it should be in a separate patch, though - it is
>> changing a different
>> behavior than what this patch does.
>
> OK.
Will send a 2nd patch with this in the next few days.
>> I did look at that, but I do not think it can be.
>>
>> get_stream_info_time is not equivalent to what is here.
>> get_stream_info_time will
>> eventually fall back to frag_stream_info->tfdt_dts, where as this
>> code falls back
>> to frag_stream_info->sidx_pts even if it is AV_NOPTS_VALUE. It would
>> be a behavior
>> change do use get_stream_info_time here.
>
> OK, it make sense together with `if (sc->has_sidx)`.
>
> No more comments from me.
Applied. Thank you for your reviews :).
- Derek
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-19 16:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-16 14:48 Derek Buitenhuis
2022-08-16 16:21 ` Zhao Zhili
2022-08-16 16:32 ` Derek Buitenhuis
2022-08-17 10:29 ` Zhao Zhili
2022-08-19 16:38 ` Derek Buitenhuis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c447dfd5-9d7e-a836-3b6e-3518fa99f46d@gmail.com \
--to=derek.buitenhuis@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git