From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 08C88436C2 for ; Mon, 19 Jun 2023 02:43:56 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3897168BF58; Mon, 19 Jun 2023 05:43:53 +0300 (EEST) Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3F4EB6802B2 for ; Mon, 19 Jun 2023 05:43:47 +0300 (EEST) Received: by mail-ot1-f47.google.com with SMTP id 46e09a7af769-6b160f3f384so2083162a34.3 for ; Sun, 18 Jun 2023 19:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687142625; x=1689734625; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/xxf9QQLkswH4x+Gp3kvuhACh4H3trlpbNkGFuChDts=; b=bNCGkp8e3ToeiAaXAP9wErM26JJ2+SCojSXW+P3nycA32CSs4SZhf8ZHQ08F2xaHMT uC8CLk+XKyEU7KjTPNi7Bk6zuu+tQ1uWXAF0SkHkCmzKPyQsQX8bZheZIL9V7DnIuwXj Fj1WFMbRP8J/fZD74zu95jiL/7q32oWMkK7/x0Wlm18EefBibZRPt4ObJBqz6wf/sVb2 N7iHLk1Q5xKABY1URCvPSmYV+S/mBQAgFVqNkeGNPxIzgVkQVYRDwv2t5TR2i9e7My2v wBGjdSIIZR3r7v27Lk2uLGP+5CDPqvI7hEUSV0Cc7JpAq2M32WtDrFP2Nl3tl28YgGQq TYBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687142625; x=1689734625; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/xxf9QQLkswH4x+Gp3kvuhACh4H3trlpbNkGFuChDts=; b=C9gjNCx9BPkql5GRIKBcIysMebBE5kGWjSIDNUl4q2/2p0kj2VMmuKjOB4a6nRBiB7 L9gZNwxMFDEuLGeMHktkrL1qAXe3LTZ57l4nn1rvR5FCqTlJj5KUt/am71kL20IpeHrA 8bS+bROdva3USIVAQ2l1qzk6bSUTENwyT3YISqNDVd0Dnhr320/XQ66zemg1oXqsvZjr 1hSsnUlGL8NFeuR6umDMAYWKvlGpihibSmzoTlsHQwOjN/AnWpJLcPWp3c3IGYc4qG5S 6ZWqRRJgJY6h0jZi3hdAB8t74Tx64JqoMOwbGaPcwygeh8QUbbEYZQ2y5Vw1hl2Kn8B6 y9sg== X-Gm-Message-State: AC+VfDx7gQ6w7IOe7A/W3fBkl5YSaAVHiTV0J1SDLaZUab2qNJN5LCMo au3G05Qxa27jc94CLOK4ILCx2W598CU= X-Google-Smtp-Source: ACHHUZ4i9sN/sJ7eR/Tn6s4ji/1Wn9JeaaZs5PFEKBUaMYQSPEVyuvRh1vBlKsSHHWnWPbYz1tSW9w== X-Received: by 2002:a9d:7985:0:b0:6b4:27e8:fb3e with SMTP id h5-20020a9d7985000000b006b427e8fb3emr3935177otm.27.1687142625328; Sun, 18 Jun 2023 19:43:45 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id h1-20020a9d6401000000b006af814436f4sm9789821otl.25.2023.06.18.19.43.44 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Jun 2023 19:43:44 -0700 (PDT) Message-ID: Date: Sun, 18 Jun 2023 23:43:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20230612123027.1865-1-d.kozinski@samsung.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v24 6/9] avformat/mov_muxer: Extended MOV muxer to handle EVC video content X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/18/2023 11:27 PM, Wang Bin wrote: > - Changes in mov_write_video_tag function to handle EVC elementary stream >> - Provided structure EVCDecoderConfigurationRecord that specifies the >> decoder configuration information for ISO/IEC 23094-1 video content >> >> Signed-off-by: Dawid Kozinski >> --- >> libavformat/Makefile | 2 +- >> libavformat/evc.c | 422 ++++++++++++++++++++++++++++++++++++++++ >> libavformat/evc.h | 44 +++++ >> libavformat/isom_tags.c | 2 + >> libavformat/movenc.c | 33 ++++ >> 5 files changed, 502 insertions(+), 1 deletion(-) >> create mode 100644 libavformat/evc.c >> create mode 100644 libavformat/evc.h >> >> diff --git a/libavformat/Makefile b/libavformat/Makefile >> index 6e4231fda2..d3503196e3 100644 >> --- a/libavformat/Makefile >> +++ b/libavformat/Makefile >> @@ -364,7 +364,7 @@ OBJS-$(CONFIG_MOV_DEMUXER) += mov.o >> mov_chan.o mov_esds.o \ >> OBJS-$(CONFIG_MOV_MUXER) += movenc.o av1.o avc.o hevc.o >> vpcc.o \ >> movenchint.o mov_chan.o rtp.o >> \ >> movenccenc.o movenc_ttml.o >> rawutils.o \ >> - dovi_isom.o >> + dovi_isom.o evc.o >> OBJS-$(CONFIG_MP2_MUXER) += rawenc.o >> OBJS-$(CONFIG_MP3_DEMUXER) += mp3dec.o replaygain.o >> OBJS-$(CONFIG_MP3_MUXER) += mp3enc.o rawenc.o id3v2enc.o >> > > This breaks msvc build. golomb_tab.o is required in > OBJS-$(CONFIG_MOV_MUXER). otherwise i get this error > > 2023-06-18T12:48:08.5213414Z LD libavformat/avformat-60.dll > 2023-06-18T12:48:08.6503045Z LINK : warning LNK4044: unrecognized > option '/-icf=safe'; ignored > 2023-06-18T12:48:08.8081443Z Creating library > libavformat/avformat.lib and object libavformat/avformat.exp > 2023-06-18T12:48:08.8219530Z evc.o : error LNK2001: unresolved > external symbol ff_golomb_vlc_len > 2023-06-18T12:48:08.8267361Z evc.o : error LNK2001: unresolved > external symbol ff_ue_golomb_vlc_code > 2023-06-18T12:48:09.0122434Z libavformat\avformat-60.dll : fatal error > LNK1120: 2 unresolved externals > 2023-06-18T12:48:09.0517997Z make: *** > [/d/a/avbuild/avbuild/ffmpeg-***/ffbuild/library.mak:119: > libavformat/avformat-60.dll] Error 96 > > > full build log: > https://github.com/wang-bin/avbuild/actions/runs/5303646918/jobs/9599433665 Should be fixed. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".