From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6C30946AD3 for ; Sun, 2 Jul 2023 21:04:26 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 98BD568014E; Mon, 3 Jul 2023 00:04:24 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9C19568BD8E for ; Mon, 3 Jul 2023 00:04:18 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 362L4IKi014373-362L4IKj014373; Mon, 3 Jul 2023 00:04:18 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 062B1A146B; Mon, 3 Jul 2023 00:04:18 +0300 (EEST) Date: Mon, 3 Jul 2023 00:04:17 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: John Cox In-Reply-To: <20230702123242.232484-3-jc@kynesim.co.uk> Message-ID: References: <20230702123242.232484-1-jc@kynesim.co.uk> <20230702123242.232484-3-jc@kynesim.co.uk> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v2 02/15] avfilter/vf_bwdif: Add common macros and consts for aarch64 neon X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: thomas.mundt@hr.de, ffmpeg-devel@ffmpeg.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2 Jul 2023, John Cox wrote: > Add macros for dual scalar half->single multiply and accumulate > Add macro for shift, saturate and shorten single to byte > Add filter constants > > Signed-off-by: John Cox > --- > libavfilter/aarch64/vf_bwdif_neon.S | 53 +++++++++++++++++++++++++++++ > 1 file changed, 53 insertions(+) > > diff --git a/libavfilter/aarch64/vf_bwdif_neon.S b/libavfilter/aarch64/vf_bwdif_neon.S > index 639ab22998..c2f5eb1f73 100644 > --- a/libavfilter/aarch64/vf_bwdif_neon.S > +++ b/libavfilter/aarch64/vf_bwdif_neon.S > @@ -23,3 +23,56 @@ > > #include "libavutil/aarch64/asm.S" > > +// Space taken on the stack by an int (32-bit) > +#ifdef __APPLE__ > +.set SP_INT, 4 > +#else > +.set SP_INT, 8 > +#endif Ok I guess this works and doesn't require excessive ifdefs. It can end up brittle though, but I guess this form can be tolerable. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".