From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B6199411A8 for ; Tue, 4 Jan 2022 04:10:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 708CA68B20D; Tue, 4 Jan 2022 06:10:21 +0200 (EET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A86D68B181 for ; Tue, 4 Jan 2022 06:10:15 +0200 (EET) Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:105:465:1:3:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4JSfKL3HQYzQlNM for ; Tue, 4 Jan 2022 05:10:14 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Message-ID: Date: Tue, 4 Jan 2022 09:40:08 +0530 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220102094940.1765-1-dcnieho@gmail.com> From: Gyan Doshi In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2 0/5] avdevice/dshow fixups X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2022-01-04 05:02 am, Roger Pack wrote: > These LGTM. Feel free to add yourself as a dshow maintainer if so > interested, as well! :) I assume these need to be pushed too. Gyan > > On Sun, Jan 2, 2022 at 2:50 AM Diederick Niehorster wrote: >> These five patches fix two regressions (one crashing bug making dshow >> unusable on x86, and one regression introduced by my recent patches due >> to which devices that seem to not behave according to spec but worked >> fine before my patches could no longer be used. >> They furthermore fix three small issues i found looking through the dshow code: 2x needed cleanup not being done, and one where to skip setting format for a pin when its useless. >> >> new in v2 is fixing of the x86 crash >> >> Diederick Niehorster (5): >> avdevice/dshow: tv_tuner_audio_dialog cleanup missing >> avdevice/dshow: proper cleanup of queried media types >> avdevice/dshow: fix crash on x86 >> avdevice/dshow: only set pin format if wanted >> avdevice/dshow: ensure pin's default format is set >> >> libavdevice/dshow.c | 93 +++++++++++++--------- >> libavdevice/dshow_capture.h | 120 ++++++++++++++--------------- >> libavdevice/dshow_crossbar.c | 4 + >> libavdevice/dshow_enummediatypes.c | 8 +- >> libavdevice/dshow_enumpins.c | 8 +- >> libavdevice/dshow_filter.c | 24 +++--- >> libavdevice/dshow_pin.c | 48 ++++++------ >> 7 files changed, 165 insertions(+), 140 deletions(-) >> >> -- >> 2.28.0.windows.1 >> >> _______________________________________________ >> ffmpeg-devel mailing list >> ffmpeg-devel@ffmpeg.org >> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel >> >> To unsubscribe, visit link above, or email >> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".