From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9DC4543032 for ; Wed, 18 May 2022 17:00:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0429C68B475; Wed, 18 May 2022 20:00:57 +0300 (EEST) Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 1253A68B140 for ; Wed, 18 May 2022 20:00:50 +0300 (EEST) Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-edeb6c3642so3515600fac.3 for ; Wed, 18 May 2022 10:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=zUPiBPiA4JBlj0L1Q1K2SWpZGs/pbTuLcM3/Xjf6IkI=; b=DHW7OciZpY4PWB90aehPQ+yoZzT2neHCnLGd64hy2WD8cT+9OIve6D7svTzZcPmtHS 8aZR+HL/uc4p5Hiyl6+pLURCAUf8pk+9RtKB3DkRrpF7TzU+Nm26Odg55aWCcWN/gfa/ siiMosTTWJ3DXL/VICtKlm+TEd8EO18GJv3yQYt2mok4zeLKhuFmcPyO81USf9I55XHI im5IobXNVqZdpwmCb89Il6wu1VXjiNwlmTWjhWQWlWccCf44fBOiX7VKgVrg0UN/np9z IkgSEXBJJhKmn5NLWFFcI/IljtiGDfelvwkZYNs5xwKC2BPfU4o5K4BUzQBDDUnO/Mc3 FjZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=zUPiBPiA4JBlj0L1Q1K2SWpZGs/pbTuLcM3/Xjf6IkI=; b=2szKI0h38xAHPdkPmtOy+/EvyZTRGN2unFU/dEWrsYo+9jvuEuTd+gx7oPx2OtPuNf F9iOd8ApXPlcGtDT0K2vmU2Jz0bhim/P7aWedMz4cdYpShzKw0eqcwuVJZNnyxQD8vBk dHyvFFzRmlsAVMD/nUOIC7Xc+mavAyAVLYyCHXwxKs63tqVdp6Ee1RPMwUVai4/F/H9e pxXaWW97dvnGZQvxcuCIeBk3VstNULAYDgIdMEP+ayT2I/2MWfF+6LxOOvP7kIuyA/eM kyVmOvInmEo3j9P6iHiwwZL9fiN3G1Krq4Cx81/3HiEGW4R89ukcLinqqVdatJsYlemc Hitg== X-Gm-Message-State: AOAM532RRXpa/JyBUH8O930w/BBEdwpvOOr+fY++OxCxBy5yMwFtlj2E LH2+WeGyh77WUEdgUaCjtfx510zOKHE= X-Google-Smtp-Source: ABdhPJzOeOQbkc4eX0sDrA7/jkKHRli8uEejvgZLPfz/iGDuuOywCglAyHVwXdCbDqFJDzgB1Oio7g== X-Received: by 2002:a05:6870:170b:b0:f1:8a5c:80a0 with SMTP id h11-20020a056870170b00b000f18a5c80a0mr636562oae.16.1652893249077; Wed, 18 May 2022 10:00:49 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id z206-20020aca33d7000000b00328abf1e309sm962960oiz.23.2022.05.18.10.00.47 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 May 2022 10:00:48 -0700 (PDT) Message-ID: Date: Wed, 18 May 2022 14:00:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220518163956.1145583-1-vigneshv@google.com> From: James Almer In-Reply-To: <20220518163956.1145583-1-vigneshv@google.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: Expose the allintra usage mode X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/18/2022 1:39 PM, Vignesh Venkatasubramanian wrote: > libaom added an usage=allintra mode for doing better with still > images. Expose that in the ffmpeg's wrapper. This is especially > useful for encoding still AVIF images. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavcodec/libaomenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c > index 0411773bbf..d93d1b5e3c 100644 > --- a/libavcodec/libaomenc.c > +++ b/libavcodec/libaomenc.c > @@ -1300,6 +1300,9 @@ static const AVOption options[] = { > { "usage", "Quality and compression efficiency vs speed trade-off", OFFSET(usage), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, VE, "usage"}, > { "good", "Good quality", 0, AV_OPT_TYPE_CONST, {.i64 = 0 /* AOM_USAGE_GOOD_QUALITY */}, 0, 0, VE, "usage"}, > { "realtime", "Realtime encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 1 /* AOM_USAGE_REALTIME */}, 0, 0, VE, "usage"}, > +#ifdef AOM_USAGE_ALL_INTRA There's no need to wrap this if you're not using the actual define below. Realtime above was added without a wrapper because libaom versions that don't support usage == 1 just ignore the value if given (or error out). I expect the same for this allintra one. It's better from an API pov that lavc always accepts the "allintra" constant value for the usage avoption, and not depend on the libaom version used at link time. > + { "allintra", "All Intra encoding", 0, AV_OPT_TYPE_CONST, {.i64 = 2 /* AOM_USAGE_ALL_INTRA */}, 0, 0, VE, "usage"}, > +#endif > { "tune", "The metric that the encoder tunes for. Automatically chosen by the encoder by default", OFFSET(tune), AV_OPT_TYPE_INT, {.i64 = -1}, -1, AOM_TUNE_SSIM, VE, "tune"}, > { "psnr", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_PSNR}, 0, 0, VE, "tune"}, > { "ssim", NULL, 0, AV_OPT_TYPE_CONST, {.i64 = AOM_TUNE_SSIM}, 0, 0, VE, "tune"}, _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".