From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v5 1/1] avutil/csp: create public API for colorspace structs
Date: Tue, 24 May 2022 17:51:49 -0400
Message-ID: <c373b284-5737-8d29-7b1e-cb103265e2c8@gmail.com> (raw)
In-Reply-To: <DB6PR0101MB22145C389A997187EDD309BB8FD79@DB6PR0101MB2214.eurprd01.prod.exchangelabs.com>
On 5/24/22 16:56, Andreas Rheinhardt wrote:
> Leo Izen:
>> +#define AVUTIL_CSP_DENOM 100000
>
> Why not 300000 given that the denominator of one of the constants has a
> factor of three?
> (Sorry if this has already been answered before.)
>
I suggested this to haasn, but he pointed out that the 1/3 can be (and
is) manually coded as {1, 3} without using the macro. The spec defines
it as one-third exactly, not via a float value. Adding a factor of 3 to
every denominator shouldn't be necessary as the various av_q functions
handle that gracefully already.
-Leo Izen (thebombzen)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-05-24 21:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-24 16:30 [FFmpeg-devel] [PATCH v5 0/1] " Leo Izen
2022-05-24 16:30 ` [FFmpeg-devel] [PATCH v5 1/1] " Leo Izen
2022-05-24 20:56 ` Andreas Rheinhardt
2022-05-24 21:51 ` Leo Izen [this message]
2022-05-28 10:42 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c373b284-5737-8d29-7b1e-cb103265e2c8@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git