From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avformat/wavdec: dynamically set max_size by default
Date: Thu, 29 Feb 2024 01:18:46 +0100 (CET)
Message-ID: <c36c6813-5b21-be2f-d8c0-03a8c3160280@passwd.hu> (raw)
In-Reply-To: <AS8P250MB07446DB2D60CF7BDFD9122C98F582@AS8P250MB0744.EURP250.PROD.OUTLOOK.COM>
On Thu, 29 Feb 2024, Andreas Rheinhardt wrote:
> Marton Balint:
>> The wav demuxer by default tried to demux 4096-byte packets which caused
>> packets with very few number of samples for files with high channel count.
>> This caused a significant overhead especially since the latest ffmpeg.c
>> threading changes.
>>
>> So let's use a similar approach for selecting audio frame size which is already
>> used in the PCM demuxer, which is to read 25 times per second but at most 1024
>> samples.
>
> 1024 samples seems to be quite small, in particular for files with few
> channels (like stereo).
1024 is kind of a historical default. Also having multiples of 1024 is
beneficial for some codecs which encode this many samples per frame.
In any case, I am not against somewhat increasing this, but it should be
done for both PCM and WAV, it can be a separate patch and discussion.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-02-29 0:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 0:45 [FFmpeg-devel] [PATCH 1/4] fate: never generate auto-generated references Marton Balint
2024-02-26 0:45 ` [FFmpeg-devel] [PATCH 2/4] swresample/resample: rework resample_one function to work the same way as the others Marton Balint
2024-02-26 22:19 ` Michael Niedermayer
2024-02-27 9:48 ` [FFmpeg-devel] [PATCH 1/2] swresample/resample: fix rounding errors with filter_size=1 and phase_shift=0 Marton Balint
2024-02-27 9:48 ` [FFmpeg-devel] [PATCH 2/2] swresample/resample: rework resample_one function to work the same way as the others Marton Balint
2024-02-27 17:54 ` Michael Niedermayer
2024-02-27 20:50 ` Marton Balint
2024-02-28 22:45 ` Michael Niedermayer
2024-02-29 0:19 ` Marton Balint
2024-02-29 12:22 ` Michael Niedermayer
2024-02-29 17:55 ` Marton Balint
2024-03-01 3:30 ` Michael Niedermayer
2024-03-01 22:24 ` Marton Balint
2024-02-27 17:53 ` [FFmpeg-devel] [PATCH 1/2] swresample/resample: fix rounding errors with filter_size=1 and phase_shift=0 Michael Niedermayer
2024-02-26 0:45 ` [FFmpeg-devel] [PATCH 3/4] fate/libswresample: force number of samples for the input of aresample async tests Marton Balint
2024-02-26 0:45 ` [FFmpeg-devel] [PATCH 4/4] avformat/wavdec: dynamically set max_size by default Marton Balint
2024-02-28 23:12 ` Andreas Rheinhardt
2024-02-29 0:18 ` Marton Balint [this message]
2024-03-01 22:30 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c36c6813-5b21-be2f-d8c0-03a8c3160280@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git