From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A5E3841204 for ; Tue, 15 Feb 2022 18:52:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E753A68B203; Tue, 15 Feb 2022 20:52:15 +0200 (EET) Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7E5DD68B064 for ; Tue, 15 Feb 2022 20:52:09 +0200 (EET) Received: by mail-oo1-f53.google.com with SMTP id o128-20020a4a4486000000b003181707ed40so24270556ooa.11 for ; Tue, 15 Feb 2022 10:52:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=bibbVPU3Hhu1SrGYbcLT7mh14OKOA7Kaw29nRIvF7xg=; b=W7k6vbqxny8fvSc3vJgKe/ovnuZEY4iV6pLJb2r3uGdQydztMZ/+yRBW6n/ayswcc2 0wqUeyC+w5OGXAMj/Aihm4PJmF/cLZL2Cnpt8POg7SzhbQ7tHSd829C/42ZVHEJHW07v veoiGYDqIFZx7obXVAi1yWUbH3PTGKch+ofxBfxDfyRV+wxT1tTV83teBxrpLLreT+Er epltm7zHoESlaswOONsjwStUPEASzykgX/FmTbhHDJBEelv/yYOzk3LVsiHN4x/gulpS PQpOt/sJCEW2S4+DpnHx6vBRVfgPnhg3t54nVpcpGuhni9K3S2zz5wgh+WYTovqPMecl qK+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=bibbVPU3Hhu1SrGYbcLT7mh14OKOA7Kaw29nRIvF7xg=; b=idTG0i06szo8oQTWfvoLQZzs1PbPOIGOt4B3Phdf3QuZTZMX9Zu5KQJiQyDLJGoYMp T9ZryA3mCFoU18r0gSyDJRtVTzwrtOFu/RCEWyw0Fh4ksKWVrjtXjeLSKFvcCc9Tdlzv UlQCB3RBzOnZyK/14uVeMgRyXU5MW3Hc5L2E88/udXkVWsQawnaQZ8jDZfGM09dxh4A4 ij6Iln9Oa+Q//oi0ugggXCeilP0ac/7XKLUgSdBHNBgXl0uy57tOLIU5zx0GksXNu5LP 9i0umnFsrEPNC1Vjp8wRW99WxCrAh6ZcKnp9igE8/W+hegSF/ys49juzGnebZ+T3d6iQ lAHQ== X-Gm-Message-State: AOAM531KlzE0Hojrcqk/ullLSwsqcauiciHwERUkthoL7z4Hqa3e2L9+ wttARPTd2xOWje+magKSqJ36s+GGtov5yQ== X-Google-Smtp-Source: ABdhPJyObSIFnOBawcqi2ov8gKh3ItZJNAiFofZST/d8CQGWPX2Hdt5Bem0dOLkw93o7V2zS8aU9jw== X-Received: by 2002:a05:6870:1119:b0:d3:6905:5fb8 with SMTP id 25-20020a056870111900b000d369055fb8mr1036151oaf.48.1644951126980; Tue, 15 Feb 2022 10:52:06 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id r38sm4872377otv.72.2022.02.15.10.52.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Feb 2022 10:52:06 -0800 (PST) Message-ID: Date: Tue, 15 Feb 2022 15:52:04 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220113015101.4-1-jamrial@gmail.com> <20220113020913.870-6-jamrial@gmail.com> <164492580482.19727.5709579514076305797@lain.red.khirnov.net> From: James Almer In-Reply-To: <164492580482.19727.5709579514076305797@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 275/281] avfilter: convert to new channel layout API X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/15/2022 8:50 AM, Anton Khirnov wrote: > Quoting James Almer (2022-01-13 03:09:07) >> diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c >> index ed3c75311a..96704e041c 100644 >> --- a/libavfilter/af_aformat.c >> +++ b/libavfilter/af_aformat.c >> @@ -104,9 +104,36 @@ static av_cold int init(AVFilterContext *ctx) >> ff_add_format, av_get_sample_fmt, AV_SAMPLE_FMT_NONE, "sample format"); >> PARSE_FORMATS(s->sample_rates_str, int, s->sample_rates, ff_add_format, >> get_sample_rate, 0, "sample rate"); >> - PARSE_FORMATS(s->channel_layouts_str, uint64_t, s->channel_layouts, >> - ff_add_channel_layout, av_get_channel_layout, 0, >> - "channel layout"); >> + { >> + AVChannelLayout fmt = { 0 }; >> + const char *cur = s->channel_layouts_str; >> + int ret; >> + >> + if (s->channel_layouts_str && strchr(s->channel_layouts_str, ',')) { >> + av_log(ctx, AV_LOG_WARNING, "This syntax is deprecated, use '|' to " >> + "separate channel layout.\n"); > It might be unclear to the user what "this syntax" refers to, maybe make > it "Using ',' to separate channel layouts is deprecated" This is copy-paste from the PARSE_FORMATS() macro. I'd rather leave changing it to a separate commit, and do it for sample rate and sample format too. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".