From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 1C5254E94A
for <ffmpegdev@gitmailbox.com>; Tue, 18 Mar 2025 14:42:10 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 86B64687A63;
Tue, 18 Mar 2025 16:42:06 +0200 (EET)
Received: from mail-lf1-f43.google.com (mail-lf1-f43.google.com
[209.85.167.43])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 872B0687A06
for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 16:41:59 +0200 (EET)
Received: by mail-lf1-f43.google.com with SMTP id
2adb3069b0e04-547bcef2f96so6377209e87.1
for <ffmpeg-devel@ffmpeg.org>; Tue, 18 Mar 2025 07:41:59 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=martin-st.20230601.gappssmtp.com; s=20230601; t=1742308918; x=1742913718;
darn=ffmpeg.org;
h=mime-version:references:message-id:in-reply-to:subject:to:from:date
:from:to:cc:subject:date:message-id:reply-to;
bh=iJT0XucRrPhWl/MaAlao/Or0FsQTxW92kYaj7B+DfBA=;
b=eiqj8wUwoCF0L+sFt8iMPtsLg/KYpwO9DvkQ8GgDvaJFapbUd1eJqNQ51i3KtusR0c
t1v38FPqCMz3eqmG2ENh7eLPTifl6zB5GVMOmbmK9RQJU39nGAT1WIOYajL7Zbpzzxb6
b9kAtd0Yza+gKC2V8JwKPIVoQoImuGabh8XRAH8sH+9Ob3X64gqJcIV9OtPp3vbMk74r
EuZRI+lNnFu1AE73KPP39I+X7Rydt3wd4TNgC34UGa0YI7w8YdEXE8phGuc5fGTMoWxa
G7+H9mzPuTayF+dl3ZQWY+tNRNI6+ugoc3kEdZV3u3601KBUzGKk2Frp3njx/Bh5vVim
Qxyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1742308918; x=1742913718;
h=mime-version:references:message-id:in-reply-to:subject:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=iJT0XucRrPhWl/MaAlao/Or0FsQTxW92kYaj7B+DfBA=;
b=MVikVrnrj4VYoWk+b3z1I8DLbrIYB8HMz+gZ8YDp8oRWR9WR/6jpObVpIpzCqIQOIW
qKR6MXnTSmTFcb9tcyUhn22xqbKjW65dQ9XFTWNYX39HAYJqnbyXPOvaKm/nn1QA/EtU
9V+8b48hbotCbYV0YHluxBZYEWrS1/ahgKc+q9fahjCwQYsiSMno2pEOoCXhSZspR5X4
EZ5vQHWVhNwmIDeNXGj+WnS7qMUPlPfCg+Qo0yWn5Tk74uUrg/bp5ZmYqiA68jQh2red
aj9RorMZtMzUNeGT3hRyQdassZ8vYx8FWQlIjki5PEEOillldqinPbmw3vxc7BmPWzZc
XBzw==
X-Gm-Message-State: AOJu0YyMQDT9gGWVcbWf88PE4jx5pXXF3gcCphKezThsyiYXvWz3DC3g
JjQwyzAOvjKoQir7Jh9t1vKnIjvv9pddbNnANmBddGfK6Hl8QSbTRe6DDJb8Bfn41Vru81ZtWkd
jPw==
X-Gm-Gg: ASbGncth/13nxCKD21QaUB0FmfJAgPm9VpgytrzTXkL8fqivOsS/Eq++6BGQI1wXZMF
TguTSW71n2jvfd7+LY1017vVmq4yd7+vSv9CcRyiVaWCArkrbysKMYaDmowPQWGKxBbftz9Hz63
GplTO2obR4FeUsY8QLhIQg+iCkQ3NZCYBBsDA78aW5G2b02V0Uhg3PVwTt1XcnZyZaE5wFJ/8VM
KKdvAoy7FnokEEUZIBPnV+kupObRWQojLivVo04nSFQLN9CN+LlKwvnH5pPPQASLNcve6p5l/WS
BElgXj25weCwtCiyU8sWm3Roxnm5FvaaxE2/ql8Nkl2qQukN3Q5OG6XmAO0KozTYUxe2pzpR247
96PUBWq+gW7i2dXvJnUFnav19qpwZmy0TO1tBnOW3
X-Google-Smtp-Source: AGHT+IFUHN4y4jKwXnaHd2ytKK6AOp5J6XSFw5VgOjJTkvJEH2Boctd12RZCiObhGYP86RAMFCVjYw==
X-Received: by 2002:a05:6512:15a7:b0:545:2cb6:af31 with SMTP id
2adb3069b0e04-549c3901b52mr9280731e87.15.1742308918196;
Tue, 18 Mar 2025 07:41:58 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
(tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-549ba864e68sm1719003e87.155.2025.03.18.07.41.57
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 18 Mar 2025 07:41:57 -0700 (PDT)
Date: Tue, 18 Mar 2025 16:41:56 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20250318135252.22378-1-ffmpeg@gyani.pro>
Message-ID: <c2c6ecb-2bed-d43f-2718-399c9f1cc210@martin.st>
References: <20250318135252.22378-1-ffmpeg@gyani.pro>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] configure: improve ar test for response
files
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/c2c6ecb-2bed-d43f-2718-399c9f1cc210@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Tue, 18 Mar 2025, Gyan Doshi wrote:
> ---
> configure | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/configure b/configure
> index d84e32196d..2c060b0cd4 100755
> --- a/configure
> +++ b/configure
> @@ -5230,12 +5230,6 @@ else
> ar_o='$@'
> fi
>
> -if $ar 2>&1 | grep -qi "@.*file"; then
> - ar_objs="true"
> -else
> - ar_objs=""
> -fi
> -
> add_cflags $extra_cflags
> add_cxxflags $extra_cxxflags
> add_objcflags $extra_objcflags
> @@ -7759,6 +7753,13 @@ case $ld_type in
> ;;
> esac
>
> +{
> +ar_out=${FFTMPDIR}/test$LIBSUF
> +respfile="@/dev/null"
I'm a little bit hesitant about using a special file like /dev/null; I
wasn't sure about how this would work e.g. with MSVC. It seems to work
both with msvc-wine, MSVC run through msys2, and both GCC/binutils and
llvm-mingw in msys2. (I haven't tested MSVC through WSL, but I would
expect it to work if these other configs work.)
So it's not an issue - this check does work as intended, but I would maybe
have preferred a real rsp file. (But that requires more temp files to
clean up.)
> +out_arg="${ar_o/\$@/$ar_out}"
This isn't posix sh syntax; running configure on e.g. ubuntu with /bin/sh
== dash, gives:
src/configure: 7759: Bad substitution
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".