From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8A764469F6 for ; Sat, 1 Jul 2023 21:22:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A7E568C194; Sun, 2 Jul 2023 00:21:59 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4205468BF31 for ; Sun, 2 Jul 2023 00:21:53 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 361LLqVr011866-361LLqVs011866; Sun, 2 Jul 2023 00:21:52 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 4A383A146B; Sun, 2 Jul 2023 00:21:52 +0300 (EEST) Date: Sun, 2 Jul 2023 00:21:51 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: "Logan.Lyu" In-Reply-To: <783e76c5-05fd-65b9-c24c-a1f20f3d66ee@myais.com.cn> Message-ID: References: <20230604041756.5196-1-Logan.Lyu@myais.com.cn> <20230604041756.5196-3-Logan.Lyu@myais.com.cn> <8d881143-3f72-3aee-375-9254f993ee25@martin.st> <783e76c5-05fd-65b9-c24c-a1f20f3d66ee@myais.com.cn> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 3/5] lavc/aarch64: new optimization for 8-bit hevc_epel_uni_w_v X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 18 Jun 2023, Logan.Lyu wrote: > Hi, Martin, > > I modified it according to your comments. Please review again. > From 45508b099dc99d30e711b9e1f253068f7804e3ed Mon Sep 17 00:00:00 2001 > From: Logan Lyu > Date: Sat, 27 May 2023 09:42:07 +0800 > Subject: [PATCH 3/5] lavc/aarch64: new optimization for 8-bit > hevc_epel_uni_w_v > > Signed-off-by: Logan Lyu > --- > libavcodec/aarch64/hevcdsp_epel_neon.S | 503 ++++++++++++++++++++++ > libavcodec/aarch64/hevcdsp_init_aarch64.c | 6 + > 2 files changed, 509 insertions(+) > > diff --git a/libavcodec/aarch64/hevcdsp_epel_neon.S b/libavcodec/aarch64/hevcdsp_epel_neon.S > index 0411de9864..ca37ce1786 100644 > --- a/libavcodec/aarch64/hevcdsp_epel_neon.S > +++ b/libavcodec/aarch64/hevcdsp_epel_neon.S > +function ff_hevc_put_hevc_epel_uni_w_v12_8_neon, export=1 > + EPEL_UNI_W_V_HEADER > + > + ldr q4, [x2] > + ldr q5, [x2, x3] > + add x2, x2, x3, lsl #1 > + ldr q6, [x2] > + sub x1, x1, #8 > +1: > + ldr q7, [x2, x3] > + subs w4, w4, #1 > + add x2, x2, x3, lsl #1 > + EPEL_UNI_W_V12_CALC v16, v17 v4, v5, v6, v7, v24, v25, v26, v27 This is missing a comma between "v17" and "v4" (here and in one other place). This breaks compilation for macOS targets, where the assembler (for historical reasons) has a separate way of handling macro arguments. The same also goes for "v20 v24" in two places. > +function ff_hevc_put_hevc_epel_uni_w_v48_8_neon, export=1 > + EPEL_UNI_W_V_HEADER > + stp q8, q9, [sp, #-64]! > + stp q10, q11, [sp, #32] As mentioned in another follow-up reply, you don't need to back up and restore all of q8-q15, only the lower half. This means that it's enough to back up and restore d8-d15, which only takes half as much space. I.e. here you'd have + stp d8, d9, [sp, #-32]! + stp d10, d11, [sp, #16] instead, and for the full d8-d15 you'd have + stp d8, d9, [sp, #-64]! + stp d10, d11, [sp, #16] + stp d12, d13, [sp, #32] + stp d14, d15, [sp, #48] The same goes for both of these places in this patch, and for a number of places in patch 5/5. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".