Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: default to Monoscopic view when parsing eyes box
Date: Sat, 22 Jun 2024 18:34:49 -0300
Message-ID: <c1f47d72-1486-4043-8000-8af17c1a768e@gmail.com> (raw)
In-Reply-To: <20240622212515.GY4991@pb2>

On 6/22/2024 6:25 PM, Michael Niedermayer wrote:
> On Fri, Jun 21, 2024 at 10:25:31PM -0300, James Almer wrote:
>> Signed-off-by: James Almer <jamrial@gmail.com>
>> ---
>>   libavformat/mov.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> doesnt apply automatically with "git am" with the v2
> 
> Applying: avformat/mov: default to Monoscopic view when parsing eyes box
> error: sha1 information is lacking or useless (libavformat/mov.c).
> error: could not build fake ancestor
> Patch failed at 0001 avformat/mov: default to Monoscopic view when parsing eyes box
> 
> it applies with patch but inability to automatically apply patches
> could affect tools which try to test patches posted
> 
> git am --show-current-patch=diff | patch -p1
> patching file libavformat/mov.c
> Hunk #1 succeeded at 6546 with fuzz 2.

Are you sure your tree is clean and up to date? There's no reason for 
this patch to not apply, standalone or after 1/1 v1 or v2.

In any case, this set and the next are withdrawn as i realized i 
mistakenly assumed AVStereo3DView was a new enum, when it's not.
I'll be sending a new set later.

> 
> thx
> 
> [...]
> 
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-06-22 21:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-22  1:25 [FFmpeg-devel] [PATCH 1/2] avutil/stereo3d add Monoscopic View enum value James Almer
2024-06-22  1:25 ` [FFmpeg-devel] [PATCH 2/2] avformat/mov: default to Monoscopic view when parsing eyes box James Almer
2024-06-22 21:25   ` Michael Niedermayer
2024-06-22 21:34     ` James Almer [this message]
2024-06-24 19:40       ` Michael Niedermayer
2024-06-22  2:41 ` [FFmpeg-devel] [PATCH 3/3] avutil/stereo3d: add a Stereo3D type to signal that the packing is defined by the view field James Almer
2024-06-25  8:42   ` Anton Khirnov
2024-06-22  2:59 ` [FFmpeg-devel] [PATCH 4/7] avformat/dump: print Stereo3D view only when type is view defined James Almer
2024-06-22  2:59   ` [FFmpeg-devel] [PATCH 5/7] avutil/stereo3d: add a new allocator function that returns a size James Almer
2024-06-22  2:59   ` [FFmpeg-devel] [PATCH 6/7] avformat/mov: don't use sizeof(AVStereo3D) James Almer
2024-06-22  2:59   ` [FFmpeg-devel] [PATCH 7/7] avformat/matroskadec: " James Almer
2024-06-22  3:34 ` [FFmpeg-devel] [PATCH 1/7 v2] avutil/stereo3d add Monoscopic View enum value James Almer
2024-06-22  3:37 ` [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined James Almer
2024-07-06 12:04   ` Stefano Sabatini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1f47d72-1486-4043-8000-8af17c1a768e@gmail.com \
    --to=jamrial@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git