From: "Martin Storsjö" <martin@martin.st>
To: Alan Kelly <alankelly@google.com>
Cc: "Ronald S. Bultje" <rsbultje@gmail.com>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] checkasm: sw_scale: Produce more realistic test filter coefficients for yuv2yuvX
Date: Fri, 19 Aug 2022 13:41:00 +0300 (EEST)
Message-ID: <c1b9ede3-2532-c19a-402f-47bbc3a1ffa@martin.st> (raw)
In-Reply-To: <CABaBdZok0nDLbRpFbrjzFuq+Ys+xRvWJnp0Sia3uUVCEj3WnSA@mail.gmail.com>
On Thu, 18 Aug 2022, Alan Kelly wrote:
> Thanks Martin for doing this.
>
> On Thu, Aug 18, 2022 at 10:16 AM Martin Storsjö <martin@martin.st> wrote:
> This avoids triggering overflows in the filters, and avoids
> stray
> test failures in the approximate functions on x86; due to
> rounding
> differences, one implementation might overflow while another one
> doesn't.
>
> Signed-off-by: Martin Storsjö <martin@martin.st>
> ---
> FWIW, this modification runs successfully with over 1000
> different
> seeds in checkasm.
> ---
> tests/checkasm/sw_scale.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
I'll go ahead and push this patch later today, if there's no opposition,
as it fixes spurious fate failures.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-08-19 10:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-18 8:16 Martin Storsjö
2022-08-18 9:12 ` Alan Kelly
2022-08-19 10:41 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1b9ede3-2532-c19a-402f-47bbc3a1ffa@martin.st \
--to=martin@martin.st \
--cc=alankelly@google.com \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=rsbultje@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git