Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Giovanni Mascellani via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Giovanni Mascellani <gmascellani@codeweavers.com>
Subject: [FFmpeg-devel] [PATCH] avcodec/h2645_vui: Interpret a degenerate SAR as unspecified.
Date: Tue, 4 Nov 2025 14:37:04 +0100
Message-ID: <c1b2b4d1-2367-4992-ab82-be1c8f949b91@codeweavers.com> (raw)


[-- Attachment #1.1.1: Type: text/plain, Size: 1100 bytes --]

The specification says that if either the numerator or the
denominator is zero then the SAR is to be intended unspecified.
Internally ffmpeg represents an unspecified SAR as 0/1, while
fractions with a zero denominator are not handled properly;
so we bridge the gap by replacing x/0 with 0/1.

Signed-off-by: Giovanni Mascellani <gmascellani@codeweavers.com>
---
  libavcodec/h2645_vui.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/libavcodec/h2645_vui.c b/libavcodec/h2645_vui.c
index 0e576c1563..7d01354761 100644
--- a/libavcodec/h2645_vui.c
+++ b/libavcodec/h2645_vui.c
@@ -46,6 +46,8 @@ void ff_h2645_decode_common_vui_params(GetBitContext 
*gb, H2645VUI *vui, void *l
          else if (vui->aspect_ratio_idc == EXTENDED_SAR) {
              vui->sar.num = get_bits(gb, 16);
              vui->sar.den = get_bits(gb, 16);
+            if (vui->sar.den == 0)
+                vui->sar = (AVRational){ 0, 1 };
          } else
              av_log(logctx, AV_LOG_WARNING,
                     "Unknown SAR index: %u.\n", vui->aspect_ratio_idc);
-- 
2.51.0


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 163 bytes --]

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

             reply	other threads:[~2025-11-04 13:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-04 13:37 Giovanni Mascellani via ffmpeg-devel [this message]
2025-11-04 13:50 ` [FFmpeg-devel] " Zhao Zhili via ffmpeg-devel
2025-11-04 13:58   ` Giovanni Mascellani via ffmpeg-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c1b2b4d1-2367-4992-ab82-be1c8f949b91@codeweavers.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=gmascellani@codeweavers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git