From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] hevcdec: Correctly signal AVCOL_RANGE_UNSPECIFIED if nothing was set in the bitstream
Date: Thu, 17 Feb 2022 15:06:30 +0200 (EET)
Message-ID: <c1982f3b-eb3e-f337-3074-5a618ae7dfc6@martin.st> (raw)
In-Reply-To: <CA+anqdxCXc8iUuUBBtRQW6qQ7tcu=GsLmLvJhXut0GKx-1bSSA@mail.gmail.com>
On Thu, 17 Feb 2022, Hendrik Leppkes wrote:
> On Thu, Feb 17, 2022 at 1:54 PM Martin Storsjö <martin@martin.st> wrote:
>>
>> This matches what the H264 decoder signals for such a case.
>>
>> Signed-off-by: Martin Storsjö <martin@martin.st>
>> ---
>> libavcodec/hevcdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c
>> index 8d7a4f7147..01d459984f 100644
>> --- a/libavcodec/hevcdec.c
>> +++ b/libavcodec/hevcdec.c
>> @@ -338,7 +338,7 @@ static void export_stream_params(HEVCContext *s, const HEVCSPS *sps)
>> avctx->color_range = sps->vui.video_full_range_flag ? AVCOL_RANGE_JPEG
>> : AVCOL_RANGE_MPEG;
>> else
>> - avctx->color_range = AVCOL_RANGE_MPEG;
>> + avctx->color_range = AVCOL_RANGE_UNSPECIFIED;
>>
>
> The HEVC specification is pretty clear that when its not signalled, it
> should be inferred as 0 (eg. mpeg)
>
>> When the video_full_range_flag syntax element is not present, the value of video_full_range_flag is inferred to be equal to 0
Hmm, I see. Ok, thanks - patch dropped then.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-02-17 13:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 12:54 Martin Storsjö
2022-02-17 12:58 ` Hendrik Leppkes
2022-02-17 13:06 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c1982f3b-eb3e-f337-3074-5a618ae7dfc6@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git