From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EEC4042A86 for ; Mon, 11 Jul 2022 20:58:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9F98968B73B; Mon, 11 Jul 2022 23:58:36 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 712B868B4DF for ; Mon, 11 Jul 2022 23:58:30 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 26BKwNnw005372-26BKwNnx005372; Mon, 11 Jul 2022 23:58:23 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 9E2D6A150B; Mon, 11 Jul 2022 23:58:23 +0300 (EEST) Date: Mon, 11 Jul 2022 23:58:20 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: Hubert Mazur In-Reply-To: <20220629082440.119841-2-hum@semihalf.com> Message-ID: References: <20220629082440.119841-1-hum@semihalf.com> <20220629082440.119841-2-hum@semihalf.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: Assign callback with function X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: mw@semihalf.com, gjb@semihalf.com, jswinney@amazon.com, spop@amazon.com, ffmpeg-devel@ffmpeg.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 29 Jun 2022, Hubert Mazur wrote: > Assign c->sad[0] callback with already existing neon implementation > of pix_abs16 function. > > Signed-off-by: Hubert Mazur > --- > libavcodec/aarch64/me_cmp_init_aarch64.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c > index 9fb63e9973..bec9148a1a 100644 > --- a/libavcodec/aarch64/me_cmp_init_aarch64.c > +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c > @@ -35,5 +35,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx) > if (have_neon(cpu_flags)) { > c->pix_abs[0][0] = ff_pix_abs16_neon; > c->pix_abs[0][3] = ff_pix_abs16_xy2_neon; > + > + c->sad[0] = ff_pix_abs16_neon; > } > } > -- > 2.34.1 LGTM, although I wouldn't use the word "callback" for these. I'll push this with a reworded commit message. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".