Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: Assign callback with function

From: "Martin Storsjö" <martin@martin.st>
To: Hubert Mazur <hum@semihalf.com>
Cc: mw@semihalf.com, gjb@semihalf.com, jswinney@amazon.com,
	spop@amazon.com, ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: Assign callback with function
Date: Mon, 11 Jul 2022 23:58:20 +0300 (EEST)
Message-ID: <c156ca15-ec9f-2ee9-57c-8db31ae54e3@martin.st> (raw)
In-Reply-To: <20220629082440.119841-2-hum@semihalf.com>

On Wed, 29 Jun 2022, Hubert Mazur wrote:

> Assign c->sad[0] callback with already existing neon implementation
> of pix_abs16 function.
>
> Signed-off-by: Hubert Mazur <hum@semihalf.com>
> ---
> libavcodec/aarch64/me_cmp_init_aarch64.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/aarch64/me_cmp_init_aarch64.c b/libavcodec/aarch64/me_cmp_init_aarch64.c
> index 9fb63e9973..bec9148a1a 100644
> --- a/libavcodec/aarch64/me_cmp_init_aarch64.c
> +++ b/libavcodec/aarch64/me_cmp_init_aarch64.c
> @@ -35,5 +35,7 @@ av_cold void ff_me_cmp_init_aarch64(MECmpContext *c, AVCodecContext *avctx)
>     if (have_neon(cpu_flags)) {
>         c->pix_abs[0][0] = ff_pix_abs16_neon;
>         c->pix_abs[0][3] = ff_pix_abs16_xy2_neon;
> +
> +        c->sad[0] = ff_pix_abs16_neon;
>     }
> }
> -- 
> 2.34.1

LGTM, although I wouldn't use the word "callback" for these. I'll push 
this with a reworded commit message.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".