From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B1B5F49284 for ; Wed, 16 Jul 2025 11:50:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3BE0868E459; Wed, 16 Jul 2025 14:49:57 +0300 (EEST) Received: from sender-op-o11.zoho.eu (sender-op-o11.zoho.eu [136.143.169.11]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4181C68E404 for ; Wed, 16 Jul 2025 14:49:51 +0300 (EEST) ARC-Seal: i=1; a=rsa-sha256; t=1752666589; cv=none; d=zohomail.eu; s=zohoarc; b=LChIGUiFB4de8KIy9wjZ87WZjPxSm1ZH2EnoqEhaGCCYoVRfTVrGI1ukvGMdLyeNaKDo0x3N8MGdekHLDCIzGTVM8EeVa+AEDe3wLiM/Ji6KCnvFpXoRnYVT5n8iyxPWGWRix2sQBIula1CWne/S7oEUdulsBEhotl6xApjHoS8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1752666589; h=Content-Type:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=o3SZK6PeI+u7HN1O9tJh7/jCn4y2YZBvThQNMPw8DwA=; b=hq8WDZyBPbtjAlOePhIqX9hmYIWDd/X3yimAw4OK0tITSu+yD2j3mr74mZx2q6KhGyEgwX6tiEpPOEznxrPoaRUAxEHrG2xGSVMUeRsakx00NKm/BjVUK2zkvr00vxDJQAli6aK5adjnTtebsE3W/gfwYBDQ8E8VBNQKLLRsMNc= ARC-Authentication-Results: i=1; mx.zohomail.eu; dkim=pass header.i=frankplowman.com; spf=pass smtp.mailfrom=post@frankplowman.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1752666589; s=zmail; d=frankplowman.com; i=post@frankplowman.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Message-Id:Reply-To:Cc; bh=o3SZK6PeI+u7HN1O9tJh7/jCn4y2YZBvThQNMPw8DwA=; b=WnELLLH0APrqvzWrpW4EOmX5qouevG8FKvRAX5BkJFFZzxmVqHid8L79RmyAUFfn nbywH1ea7zL4U6WyNOERdQge5Qpg8hDoybshuSEpQkrW4HRFrwrpI1Vq8mJn4FUAZ0r PE6yecOY07cbrBom2l3N3QwIxDFvEUZJe4MP3IPg= Received: by mx.zoho.eu with SMTPS id 1752666585557249.3611681540034; Wed, 16 Jul 2025 13:49:45 +0200 (CEST) Message-ID: Date: Wed, 16 Jul 2025 12:49:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20250714222429.2532133-1-michael@niedermayer.cc> <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> From: Frank Plowman In-Reply-To: <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> X-Zoho-Virus-Status: 1 X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-1.4.2/252.641.34 X-ZohoMailClient: External Subject: Re: [FFmpeg-devel] [PATCH] configure: Update ossfuzz stuff to clang-12+ X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3134320249725003177==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============3134320249725003177== Content-Language: en-GB Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CXI7vOr0j0Tzt57ywUB40Vcs" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CXI7vOr0j0Tzt57ywUB40Vcs Content-Type: multipart/mixed; boundary="------------rlyasnvewnjmzFeDdaS6lpXM"; protected-headers="v1" From: Frank Plowman To: ffmpeg-devel@ffmpeg.org Message-ID: Subject: Re: [FFmpeg-devel] [PATCH] configure: Update ossfuzz stuff to clang-12+ References: <20250714222429.2532133-1-michael@niedermayer.cc> <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> In-Reply-To: <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> --------------rlyasnvewnjmzFeDdaS6lpXM Content-Type: multipart/mixed; boundary="------------JLIPmPvE4SCixbrQW8eygKxk" --------------JLIPmPvE4SCixbrQW8eygKxk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 16/07/2025 19:11, Frank Plowman wrote: >=20 >=20 > On 16/07/2025 18:58, Kacper Michajlow wrote: >> On Tue, 15 Jul 2025 at 00:24, Michael Niedermayer >> wrote: >>> >>> --- >>> configure | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/configure b/configure >>> index fc082d5467e..e568eed55d3 100755 >>> --- a/configure >>> +++ b/configure >>> @@ -4606,8 +4606,8 @@ set >> $logfile >>> test -n "$valgrind" && toolchain=3D"valgrind-memcheck" >>> >>> enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize=3D" && != echo $CFLAGS | grep -q -- "-fcoverage-mapping" &&{ >>> - add_cflags -fsanitize=3Daddress,undefined -fsanitize-coverage=3D= trace-pc-guard,trace-cmp -fno-omit-frame-pointer >>> - add_ldflags -fsanitize=3Daddress,undefined -fsanitize-coverage=3D= trace-pc-guard,trace-cmp >>> + add_cflags -fsanitize=3Dfuzzer,address,undefined -fsanitize-mem= ory-track-origins -fno-omit-frame-pointer >>> + add_ldflags -fsanitize=3Daddress,undefined >>> } >> >> How about we remove this block of code? Or move it to >> --toolchain=3Dclang-fuzz for local build? In oss-fuzz build environmen= t >> (docker) this flags shouldn't be injected (and are not because of grep= >> checks) and instead CFLAGS are used for compile flags and >> --libfuzzer for linking. >> >> - Kacper >=20 > +1 >=20 > I have a patch locally which does something similar. We could add thes= e > flags only to those targets which need to be compiled with libfuzzer, > rather than to all CFLAGS. It saves you having to re-configure if you > want to compile some fftool, then some fuzzer binary or vice-versa. >=20 It occurred to me that my suggestion might only work in my situation because I am not actually using the fuzzer binaries to fuzz anything, but only to run individual fuzzed bitstreams which I have produced using a different fuzzer. In this situation, it is okay to only link the final executables with the libfuzzer flags and not the libs. Maybe if you want to actually do fuzzing with libfuzzer, though, you also need the libfuzzer flags when linking the libs in order to get the relevant coverage instrumentation? --=20 Frank --------------JLIPmPvE4SCixbrQW8eygKxk Content-Type: application/pgp-keys; name="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Disposition: attachment; filename="OpenPGP_0x03A84C6A098F2C6B.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEaDsehBYJKwYBBAHaRw8BAQdAtPY6tq5662mjGsrl9wixeTHtvaO/qPBio/aX SmF+pjnNJUZyYW5rIFBsb3dtYW4gPHBvc3RAZnJhbmtwbG93bWFuLmNvbT7ClgQT FgoAPgIbAQIXgAUJAeEzrBYhBDTiSNa330dpcMczBAOoTGoJjyxrBQJoOyIVBQsJ CAcCBhUKCQgLAgQWAgMBAh4BAAoJEAOoTGoJjyxrMhUBAKT3f80IXiufxCSU1rve Xp5BKwvNbY6szRdR/m21m9GAAQCGhR6t64PlMspXLtwWq9o1vjKzjWH+Bgw+UybQ CG2zDM4zBGg7HsQWCSsGAQQB2kcPAQEHQPmGNV50IFIJBy9F60ZIxe5my91pL/Sl LUWq9Z5DHBsYwsA1BBgWCgAmFiEENOJI1rffR2lwxzMEA6hMagmPLGsFAmg7HsQC GwIFCQHhM4AAgQkQA6hMagmPLGt2IAQZFgoAHRYhBEh0l9eKWUIIcnmv1LvizNAX Sd6KBQJoOx7EAAoJELvizNAXSd6KtkEBAP0jS/nBlqaVJq0iNeNDk+PnKkNBmC9p i4SuwFD71nQfAP9eWO32RXbRoIwvbrdsalWxWYmqSOdIdQE51qGMsJUuAjtIAQDA 6o6O2o2pHnWWdSqKs7Zkp4BImBD+kztmzA0Du3vJeQD/TR+qrBCXaG1FCDKn9c+Q XQNtHTxI9c6dCywjkQljOAzOOARoOyM7EgorBgEEAZdVAQUBAQdAKS1xy5312Agk deedJEXplopXco5pyANBz/edWeb7zEkDAQgHwn4EGBYKACYWIQQ04kjWt99HaXDH MwQDqExqCY8sawUCaDsjOwIbDAUJAeEzgAAKCRADqExqCY8saxvgAP9zskNI1Sti DXM4RFMoJb1aQ5TPToQZSSkGhw7JyMbLpgD/VCG7BOFjKgJGtXYEb5zpmRzNzdEB QkLsgE/vAD9GXQs=3D =3DReZ+ -----END PGP PUBLIC KEY BLOCK----- --------------JLIPmPvE4SCixbrQW8eygKxk-- --------------rlyasnvewnjmzFeDdaS6lpXM-- --------------CXI7vOr0j0Tzt57ywUB40Vcs Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature.asc" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQRIdJfXillCCHJ5r9S74szQF0neigUCaHeR2AUDAAAAAAAKCRC74szQF0neinow AP9skS0mltCUjqCMG0z2V2MZJwj51QAOjNkFWfLTp+9MogD9EvMQhb1SO9XnGny0H38E6UGl1Y+j tEArCuQXCoaIJgc= =SR8y -----END PGP SIGNATURE----- --------------CXI7vOr0j0Tzt57ywUB40Vcs-- --===============3134320249725003177== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3134320249725003177==--