From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8FEEE40244 for ; Sun, 20 Mar 2022 17:06:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6801768B050; Sun, 20 Mar 2022 19:06:39 +0200 (EET) Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4866468020D for ; Sun, 20 Mar 2022 19:06:33 +0200 (EET) Received: by mail-oo1-f45.google.com with SMTP id y27-20020a4a9c1b000000b0032129651bb0so16621623ooj.2 for ; Sun, 20 Mar 2022 10:06:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=eVHt1Bvt8dj/VuR5MswhdbE4Wv8YzGBlOmqn3PZvuZQ=; b=THEoyPZj9LbqkhnwsKsWJRfh1UbcN6Xcg+LWXjQ9793MSQrHLEn5h4hRMOo725ryHl p2I75ikkcJiTo61sjl4hQOsDsVJLu76OIoWM5L5iWz8IQ2g+zLt9z/jU2tcNUB0fJMuH 1XQTlOMZtpoQS1XwgwopPRUOTiFBtrsC9fysoJNvqT3FY31FOrA47WtuOdNwYh3SE1cT VR3Vu00pXn116Zxb+zmoTxxYx8gw8pqXuFyd5ioCdMR9P5Utpg7fCU7N3UeIw+jCQTJU W74dp6vT1ST90Tvn76g+VJS/uL/Tm39K8XdLyjHfLsag/w3doSdlIj2+uDdy643TGA7I STWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=eVHt1Bvt8dj/VuR5MswhdbE4Wv8YzGBlOmqn3PZvuZQ=; b=jCbBnVZ8QvZSm+skd12hGzB1PBKMGbXSlhaaa1pKczJAq93uhqvySnqdJngOlKhguI flgaB/pJayZZ0hOH01VJZ4QCdZGmZB8p2tB1R9r5EfSM74DGAe7NGow5SLdLFLO8QC9b JE9fOIOio68JFj+C24jgSVmHG+LVIN/NbQAWqSjeo3hFIw4ashVXG2xEB7YV9VTa+X0S mLVzgvaYkNNeMRTXKefofiYuJjCc4XHXtCSrK5FcLN2ApiY6Ri/lwAxKlOmmkwQTeOl7 Z0z7+fWXgSsGT3uw7m4CnZzaELaArgtYTq2ISz94AzSzcALZQPu+ggJQGR2WYtueO19S UEHA== X-Gm-Message-State: AOAM530IV/tJElxSKcQrWcAzP5hGPWzU8qmCsPIqZjdTXkV5hIrC471K sTdOhNRUiFr894agX6x2fSF9HcTdIMOnYw== X-Google-Smtp-Source: ABdhPJxIdUV1V0wOinc9sfCKd9RysqRHgFF1HWv1H0R2Ht60iRBZ+HoyU590j3A22fEY7STlzECrWw== X-Received: by 2002:a4a:b5c5:0:b0:321:248:bd50 with SMTP id u5-20020a4ab5c5000000b003210248bd50mr5507561ooo.50.1647795991084; Sun, 20 Mar 2022 10:06:31 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id q39-20020a4a88ea000000b0032165eb3af8sm6019694ooh.42.2022.03.20.10.06.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 10:06:30 -0700 (PDT) Message-ID: Date: Sun, 20 Mar 2022 14:06:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318221907.44594-1-jamrial@gmail.com> <164769792631.19727.12560972113347699248@lain.red.khirnov.net> From: James Almer In-Reply-To: <164769792631.19727.12560972113347699248@lain.red.khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 1/3] avformat/slndec: add support to set channel layout X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/19/2022 10:52 AM, Anton Khirnov wrote: > Quoting James Almer (2022-03-18 23:19:05) >> Signed-off-by: James Almer >> --- >> libavformat/pcmdec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/pcmdec.c b/libavformat/pcmdec.c >> index dcd13787d5..a2bcfc2814 100644 >> --- a/libavformat/pcmdec.c >> +++ b/libavformat/pcmdec.c >> @@ -170,7 +170,8 @@ PCMDEF(vidc, "PCM Archimedes VIDC", NULL, VIDC) >> #if CONFIG_SLN_DEMUXER >> static const AVOption sln_options[] = { >> { "sample_rate", "", offsetof(PCMAudioDemuxerContext, sample_rate), AV_OPT_TYPE_INT, {.i64 = 8000}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> - { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 1}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> + { "channels", "", offsetof(PCMAudioDemuxerContext, channels), AV_OPT_TYPE_INT, {.i64 = 0}, 0, INT_MAX, AV_OPT_FLAG_DECODING_PARAM }, >> + { "ch_layout", "", offsetof(PCMAudioDemuxerContext, ch_layout), AV_OPT_TYPE_CHLAYOUT, {.str = "mono"}, 0, 0, AV_OPT_FLAG_DECODING_PARAM }, >> { NULL }, >> }; >> >> -- >> 2.35.1 > > For what purpose? The demuxer doesn't do anything with the value. The demuxer calls pcm_read_header() as init, which uses it. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".