From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id D397943E86 for ; Tue, 16 Aug 2022 16:32:14 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7A9CC68B8E8; Tue, 16 Aug 2022 19:32:12 +0300 (EEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7238068041B for ; Tue, 16 Aug 2022 19:32:06 +0300 (EEST) Received: by mail-wr1-f47.google.com with SMTP id v3so13308472wrp.0 for ; Tue, 16 Aug 2022 09:32:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:from:to:cc; bh=2CrrzerKp/JvHIkry1LSOCtT3UzHA9HB5J6kJoCvLfM=; b=GInIdiIYxLpDywOnDm8cs5UiE3ZIfZrNovOvmHsHy/QrZoPv7ODApxqYk1U81oCbGX UCP0df0NTINvSL9dj4BO/sjYYa9HpF+uQAhNjN6hBtHygOyQIP31cgXgzyJyfb13qct+ ht2bEn+Zttp3ObA0KS1Z9oWNu9Eyu6RFnLakd023WH7Dq/BahD7VeowyclBUPp0Cy9Xb s7u3szKrAwFVr3DZsCKkuy7Jeh2GzUKZF/e5TRq3sAIGcno6Bg/l9R0E5pq3gJ9Gcgtg 8I4yP547vV8rTsif4uuePzBUxsRmO5r8RUbmVX+mS/aCH/LwOChcIJ89giaqQqLeEBTX opoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc; bh=2CrrzerKp/JvHIkry1LSOCtT3UzHA9HB5J6kJoCvLfM=; b=FjrBtbvL71F8uoeRy5TAaRhYsAqNyQa5mHhDRotGzF+gOTjwRwJCDSRrP6CmW0vWQJ kBdGMZGDOWmbea5NV2saI+bRsPZBJEEZIN/aXGcs+gCa2su7PrumoBbUwkXN5C6fumnT ptPlkuhxTTq0sR0n9SlpOAXMXJPq+tZXfhFZhpagdgDaQYajEKFo6IVTPV8pfs1NmD3s Z/b6l1iT7F9gpTZFb3iw3OvTFazI5c6x7i699oKgNWxsMkmjOUkVkFfUUeVF9is+PGmi H37JBl9DdqIF1nJ33ydLaFIjXk5dmEtVEXWGygLfVYDDSf7p3sV9CJ4ngANQpDQVGjBy Zq7A== X-Gm-Message-State: ACgBeo1OK6uuQMtQRalGLDKvr2D/C2zFqmq3ZJgcs8UUfwVr0ElRrBCL R6UdnkQPrJhtFksnUD708MBNV+bbxY8= X-Google-Smtp-Source: AA6agR4gsR24A+VPVjz1+qnpkMsKjjJ6ifeo5FwjLq5/BqENGmp84Up9LUyRNxBy7GsTfTbkF85OcQ== X-Received: by 2002:a05:6000:1863:b0:220:6d5f:deb5 with SMTP id d3-20020a056000186300b002206d5fdeb5mr11848710wri.470.1660667525580; Tue, 16 Aug 2022 09:32:05 -0700 (PDT) Received: from [192.168.1.106] ([149.12.10.163]) by smtp.googlemail.com with ESMTPSA id m17-20020a05600c3b1100b003a319b67f64sm5054161wms.0.2022.08.16.09.32.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 09:32:05 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 17:32:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 To: ffmpeg-devel@ffmpeg.org References: <20220816144850.196109-1-derek.buitenhuis@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v3] mov: Compare frag times in correct time base when seeking a stream without a corresponding sidx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/16/2022 5:21 PM, Zhao Zhili wrote: > get_frag_time() can be called with an mp4 file which has no sidx at all. In that case, > dst_st should have a higher priority than other streams, even if sc->has_sidx is false. > And first_tfra_pts might be used here, which makes the check of sc->has_sidx unnatural. > So in my opinion, the check on sc->has_sidx should be removed. This seems like it should be in a separate patch, though - it is changing a different behavior than what this patch does. > + frag_stream_info = get_frag_stream_info(frag_index, index, dst_st->id); > + timestamp = get_stream_info_time(frag_stream_info); > + if (timestamp != AV_NOPTS_VALUE) > + return timestamp; I did look at that, but I do not think it can be. get_stream_info_time is not equivalent to what is here. get_stream_info_time will eventually fall back to frag_stream_info->tfdt_dts, where as this code falls back to frag_stream_info->sidx_pts even if it is AV_NOPTS_VALUE. It would be a behavior change do use get_stream_info_time here. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".