From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/wavdec: change ch_layout used av_channel_layout_default.
Date: Wed, 8 May 2024 21:41:23 +0200 (CEST)
Message-ID: <c09b3634-2d9a-ed0f-fc48-909178eeace5@passwd.hu> (raw)
In-Reply-To: <20240508092453.97376-1-hiccupzhu@gmail.com>
On Wed, 8 May 2024, shiqizhu wrote:
> Signed-off-by: shiqizhu <hiccupzhu@gmail.com>
> ---
> libavformat/wavdec.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c
> index 00856a5eca..9060796c81 100644
> --- a/libavformat/wavdec.c
> +++ b/libavformat/wavdec.c
> @@ -233,8 +233,7 @@ static int wav_parse_xma2_tag(AVFormatContext *s, int64_t size, AVStream *st)
> avio_skip(pb, 3);
> }
> av_channel_layout_uninit(&st->codecpar->ch_layout);
> - st->codecpar->ch_layout.order = AV_CHANNEL_ORDER_UNSPEC;
> - st->codecpar->ch_layout.nb_channels = channels;
> + av_channel_layout_default(&st->codecpar->ch_layout, channels);
Why do you assume that the default layout is suitable here? A demuxer
should not guess the channel layout, if the format does not provide any
information about it.
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-05-08 19:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-08 9:24 shiqizhu
2024-05-08 19:41 ` Marton Balint [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c09b3634-2d9a-ed0f-fc48-909178eeace5@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git