From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Subject: Re: [FFmpeg-devel] [PATCH 19/19] Remove unnecessary libavutil/(avutil|common|internal).h inclusions
Date: Wed, 23 Feb 2022 17:02:48 +0200 (EET)
Message-ID: <c0853e59-ec5c-120-eae7-3e67e6a04c@martin.st> (raw)
In-Reply-To: <AM7PR03MB66609FF2DEA54C40B3D5D1928F349@AM7PR03MB6660.eurprd03.prod.outlook.com>
On Tue, 15 Feb 2022, Andreas Rheinhardt wrote:
> Some of these were made possible by moving several common macros to
> libavutil/macros.h.
>
> While just at it, also improve the other headers a bit.
>
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
> libavcodec/ac3.c | 3 ++-
> libavcodec/ac3.h | 1 +
> libavcodec/ass_split.c | 8 +++++++-
> libavcodec/av1_parse.h | 2 +-
> libavcodec/bitstream.c | 2 +-
> libavcodec/cabac.c | 5 +----
> libavcodec/celp_math.c | 7 +++----
> libavcodec/codec_desc.c | 3 ++-
> libavcodec/dca_exss.h | 2 +-
> libavcodec/dcadct.c | 2 +-
> libavcodec/dcadct.h | 3 ++-
> libavcodec/dcadec.h | 4 +++-
> libavcodec/dcahuff.c | 2 +-
> libavcodec/dirac_vlc.h | 2 +-
> libavcodec/dnxhddata.c | 4 +++-
> libavcodec/dnxhddata.h | 3 ++-
> libavcodec/dv_profile.c | 3 ++-
> libavcodec/elsdec.c | 7 +++++--
> libavcodec/exrdsp.h | 2 +-
> libavcodec/flacdsp.c | 1 +
> libavcodec/flacdsp.h | 2 +-
> libavcodec/flacdsp_lpc_template.c | 2 +-
> libavcodec/flacdsp_template.c | 2 +-
> libavcodec/fmtconvert.c | 3 ++-
> libavcodec/golomb.c | 2 +-
> libavcodec/h264_levels.c | 2 +-
> libavcodec/h264_redundant_pps_bsf.c | 7 ++++---
> libavcodec/h264_sei.c | 2 +-
> libavcodec/huffman.c | 5 ++++-
> libavcodec/jfdctfst.c | 5 ++---
> libavcodec/jpeg2000dwt.c | 3 ++-
> libavcodec/jrevdct.c | 4 +++-
> libavcodec/lagarithrac.h | 1 -
> libavcodec/libopus.c | 1 -
> libavcodec/lsp.c | 4 ++--
> libavcodec/lzwenc.c | 2 +-
> libavcodec/mdct15.c | 3 ++-
> libavcodec/mips/mpegaudiodsp_mips_fixed.c | 1 +
> libavcodec/mips/mpegaudiodsp_mips_float.c | 1 +
> libavcodec/mjpegenc_huffman.c | 3 ---
> libavcodec/mpegaudiodecheader.c | 2 +-
> libavcodec/mpegaudiodsp.h | 2 +-
> libavcodec/msmpeg4data.h | 2 +-
> libavcodec/opusdsp.c | 2 ++
> libavcodec/opusdsp.h | 2 --
> libavcodec/pngdsp.c | 2 +-
> libavcodec/ra288.h | 2 +-
> libavcodec/rangecoder.h | 2 +-
> libavcodec/raw.c | 2 +-
> libavcodec/rle.c | 2 +-
> libavcodec/scpr3.h | 7 +------
> libavcodec/tests/cabac.c | 2 +-
> libavcodec/tests/jpeg2000dwt.c | 5 +++++
> libavcodec/tests/rangecoder.c | 1 +
> libavcodec/trace_headers_bsf.c | 4 ++--
> libavcodec/videodsp.c | 3 ++-
> libavcodec/vp56data.h | 2 +-
> libavcodec/vp56rac.c | 4 +++-
> libavcodec/vp9dsp.c | 4 +++-
> libavcodec/wavpack.h | 5 ++++-
> libavcodec/wavpackenc.h | 2 ++
> libavcodec/x86/fdct.c | 3 ++-
> libavcodec/x86/mpegaudiodsp.c | 4 +++-
> libavcodec/x86/pngdsp_init.c | 3 ++-
> libavcodec/xiph.c | 2 ++
> libavcodec/xiph.h | 2 +-
> libavdevice/timefilter.c | 6 +++++-
> libavfilter/af_afir.h | 13 ++++++-------
> libavfilter/af_volume.h | 4 ++--
> libavfilter/avfiltergraph.c | 2 --
> libavfilter/colorspace.h | 2 +-
> libavfilter/ebur128.c | 3 ++-
> libavfilter/motion_estimation.c | 1 +
> libavfilter/motion_estimation.h | 2 +-
> libavfilter/pthread.c | 6 +++---
> libavformat/argo_asf.h | 2 +-
> libavformat/asfcrypt.c | 3 ++-
> libavformat/avlanguage.c | 3 +--
> libavformat/hlsplaylist.h | 1 -
> libavformat/matroska.h | 2 +-
> libavformat/network.c | 1 -
> libavformat/riff.c | 3 ++-
> libavformat/tee_common.c | 5 +++--
> libavformat/webmdashenc.c | 2 ++
> libavformat/wv.c | 3 ++-
> libavutil/adler32.c | 2 +-
> libavutil/aes.c | 8 ++++++--
> libavutil/aes_ctr.c | 5 ++++-
> libavutil/avsscanf.c | 8 +++++---
> libavutil/avstring.c | 5 ++++-
> libavutil/base64.c | 6 ++++--
> libavutil/blowfish.c | 5 +++--
> libavutil/bprint.c | 3 ++-
> libavutil/buffer_internal.h | 1 -
> libavutil/camellia.c | 6 +++++-
> libavutil/cast5.c | 6 +++++-
> libavutil/channel_layout.c | 6 ++++--
> libavutil/color_utils.c | 1 -
> libavutil/crc.c | 2 +-
> libavutil/des.c | 6 ++++--
> libavutil/error.c | 7 +++++--
> libavutil/fixed_dsp.c | 1 +
> libavutil/fixed_dsp.h | 2 +-
> libavutil/lls.c | 2 +-
> libavutil/log.c | 4 +++-
> libavutil/lzo.c | 6 ++++--
> libavutil/mem.c | 9 +++++----
> libavutil/pixelutils.c | 12 +++++++++---
> libavutil/qsort.h | 2 +-
> libavutil/rc4.c | 5 +++--
> libavutil/ripemd.c | 4 +++-
> libavutil/sha.c | 3 ++-
> libavutil/sha512.c | 3 ++-
> libavutil/stereo3d.c | 3 ++-
> libavutil/tea.c | 4 ++--
> libavutil/tests/color_utils.c | 2 ++
> libavutil/tests/pixelutils.c | 4 ++++
> libavutil/twofish.c | 6 +++++-
> libavutil/video_enc_params.c | 2 --
> libavutil/x86/imgutils_init.c | 3 +--
> libavutil/xtea.c | 4 ++--
> libswscale/input.c | 6 ------
> libswscale/options.c | 2 --
> libswscale/rgb2rgb.h | 5 +----
> libswscale/swscale.c | 8 ++------
> libswscale/swscale_internal.h | 1 -
> 126 files changed, 260 insertions(+), 178 deletions(-)
LGTM
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2022-02-23 15:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 18:41 [FFmpeg-devel] [PATCH] avutil/x86/emms: Don't unnecessarily include lavu/cpu.h Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 02/19] avdevice/decklink_(common_c|dec|enc).h: Fix checkheaders Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 03/19] avcodec/cabac_functions: Add missing headers Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 04/19] avcodec/aarch64/idct: Add missing stddef Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 05/19] avcodec/mips: Fix checkheaders Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 06/19] avformat/avio: Don't include common.h Andreas Rheinhardt
2022-02-23 14:46 ` Martin Storsjö
2022-02-23 16:07 ` Andreas Rheinhardt
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 07/19] avutil/log: Don't include avutil.h Andreas Rheinhardt
2022-02-23 14:47 ` Martin Storsjö
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 08/19] avutil/audio_fifo: Avoid avutil.h inclusion Andreas Rheinhardt
2022-02-23 14:48 ` Martin Storsjö
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 09/19] avutil/fifo: Don't include avutil.h Andreas Rheinhardt
2022-02-23 14:49 ` Martin Storsjö
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 10/19] avutil/file: " Andreas Rheinhardt
2022-02-23 14:49 ` Martin Storsjö
2022-02-15 17:42 ` [FFmpeg-devel] [PATCH 11/19] avutil/eval: " Andreas Rheinhardt
2022-02-23 14:50 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 12/19] avutil/imgutils: " Andreas Rheinhardt
2022-02-23 14:50 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 13/19] avutil/samplefmt: Don't include attributes.h, avutil.h Andreas Rheinhardt
2022-02-23 14:51 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 14/19] avutil/pixelutils: Don't include common.h Andreas Rheinhardt
2022-02-23 14:51 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 15/19] avutil/integer: " Andreas Rheinhardt
2022-02-23 14:51 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 16/19] avutil/display: Don't include avutil.h Andreas Rheinhardt
2022-02-23 14:52 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 17/19] Remove obsolete version.h inclusions Andreas Rheinhardt
2022-02-23 14:54 ` Martin Storsjö
2022-02-23 15:15 ` Andreas Rheinhardt
2022-02-23 19:44 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 18/19] avutil/avassert: Don't include avutil.h Andreas Rheinhardt
2022-02-23 14:58 ` Martin Storsjö
2022-02-15 17:43 ` [FFmpeg-devel] [PATCH 19/19] Remove unnecessary libavutil/(avutil|common|internal).h inclusions Andreas Rheinhardt
2022-02-23 15:02 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0853e59-ec5c-120-eae7-3e67e6a04c@martin.st \
--to=martin@martin.st \
--cc=andreas.rheinhardt@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git