From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B3979446B9 for ; Mon, 21 Nov 2022 00:17:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5FF9F68BC30; Mon, 21 Nov 2022 02:17:27 +0200 (EET) Received: from mail-oa1-f52.google.com (mail-oa1-f52.google.com [209.85.160.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A957D68BABF for ; Mon, 21 Nov 2022 02:17:21 +0200 (EET) Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-14279410bf4so10262629fac.8 for ; Sun, 20 Nov 2022 16:17:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=aiyR+uxD6T6Vf2iRI7aH6FWZhkpsG2l1SKxPCLbsTpE=; b=IBxL3gFkMxdKwjFnet/fULD4fHuYJcN2Hr7bCSS1l/z0SR+APITVl0Ul3nJfu6A82h E2LXwy7R7SfqA60sEcKb7rr2wP/zZgooffw4rNzV3k6WlShBOjhDJybz+1XWIeO+ECR+ EziPNFhokzlbKEAApgnSVfsqlHfTu6xK8zkfrVer04HAPLihhKmaG6Nv3r6+IUfibmIJ rnF21Wg4kMwx4LoDa9zwVpjbYZuCgSjq+JhPSrAlGANHi8OcpbgXqZQFhP1MOTsIDLMU eGOoTMFXxKnuwyKYdLZljYL8GwuFehiWH60imBn8vcpnDp0hO91AgH1o2/ufEBL/wTJJ VK2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aiyR+uxD6T6Vf2iRI7aH6FWZhkpsG2l1SKxPCLbsTpE=; b=6z33Ff9s9BJK2H6vz6YuXNA8b7YYJ4XcL41HJDhFtfTd6rkRAcoopFNyzSaHnO3775 c/ELlrYX0DU/Mz0qudLEVpx2IF9gw92Pd1lR61CI5NYIXLtnsvn2mnsANbqcPQDbA8jd x3ONwdD+4iH8MfZZ9/LpTqtAFW82igdqBDkUY5p99VbS8jiOsZ+OpKeVf0HkvlmVOONp +q1/g92itEjkWF/JWFB4kZRqRIvgvBseeJvnNqeLkumYDHgeXw6peXtFQDDgcXSOpi4P l4m/PhB9Uz5wpTa4KDbTiXQaxsBYfvP5Ho8DCG4/gJuwCGmMz29CY1ljm09OT09XVZOM hYdA== X-Gm-Message-State: ANoB5pn4b3RBVsW5QXJt5feAQI6B924DZ5l1kjMYHq/CzT/ZdJLuAoKm 7CPWS7iALbz8u0zvgyz94hA/M+b9KhQ= X-Google-Smtp-Source: AA0mqf7Fcwcy5pPNqXwh4iA0of7raUtoa9b8boVj3vR11NAYE9hxDtF+QwYD+xZ0znKZBCUbkAhF5w== X-Received: by 2002:a05:6870:9a97:b0:13b:c7a6:563c with SMTP id hp23-20020a0568709a9700b0013bc7a6563cmr2584920oab.263.1668989839440; Sun, 20 Nov 2022 16:17:19 -0800 (PST) Received: from [192.168.0.15] ([181.85.72.69]) by smtp.gmail.com with ESMTPSA id r7-20020a05683001c700b006618e23df48sm4290639ota.39.2022.11.20.16.17.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Nov 2022 16:17:18 -0800 (PST) Message-ID: Date: Sun, 20 Nov 2022 21:17:51 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 2/7] avcodec/flashsvenc: Account for header in packet size X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 11/18/2022 11:59 PM, Andreas Rheinhardt wrote: > Fixes ticket #10053. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/flashsvenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c > index 35793400fa..9d065bb92d 100644 > --- a/libavcodec/flashsvenc.c > +++ b/libavcodec/flashsvenc.c > @@ -229,7 +229,8 @@ static int flashsv_encode_frame(AVCodecContext *avctx, AVPacket *pkt, > I_frame = 1; > } > > - if ((res = ff_alloc_packet(avctx, pkt, s->image_width * s->image_height * 3)) < 0) > + res = ff_alloc_packet(avctx, pkt, 4U + s->image_width * s->image_height * 3); For a 1x1 image (like the one from the ticket) this results in 7 bytes + padding being allocated... > + if (res < 0) > return res; > > pkt->size = encode_bitstream(s, p, pkt->data, pkt->size, opt_w * 16, opt_h * 16, ...yet encode_bitstream() will return 17, meaning it wrote into the padding bytes, which just happens to work because said padding was big enough. The smallest dimension that results in this being equal or smaller than the allocated size is 3x3. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".