From: Casey Smalley <casey.smalley@arm.com>
To: ffmpeg-devel@ffmpeg.org
Subject: [FFmpeg-devel] [PATCH] Replace br return with ret
Date: Tue, 8 Aug 2023 13:22:33 +0100
Message-ID: <bfd7faea-bd3e-0b4c-ba29-c78119e1bb8b@arm.com> (raw)
This patch changes the return instruction in the
tr_32x4 macro from br to ret.
Using ret properly hints that the branch is a
function return.
On devices that support BTI a landing pad is
required when branching with br, or the instruction
can be replaced with a ret.
The change fixes fate-hevc-hdr-vivid-metadata when
on hardware with BTI support.
Signed-off-by: Casey Smalley <casey.smalley@arm.com>
---
libavcodec/aarch64/hevcdsp_idct_neon.S | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aarch64/hevcdsp_idct_neon.S
b/libavcodec/aarch64/hevcdsp_idct_neon.S
index f7142c939c..dbb3705670 100644
--- a/libavcodec/aarch64/hevcdsp_idct_neon.S
+++ b/libavcodec/aarch64/hevcdsp_idct_neon.S
@@ -790,7 +790,7 @@ function func_tr_32x4_\name
add x3, x11, #(32 + 3 * 64)
scale_store \shift
- br x10
+ ret x10
endfunc
.endm
-- 2.40.1
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-08-08 12:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 12:22 Casey Smalley [this message]
2023-08-08 17:46 ` Martin Storsjö
-- strict thread matches above, loose matches on Subject: below --
2023-07-27 10:26 Casey Smalley
2023-07-27 13:55 ` Rémi Denis-Courmont
2023-07-27 17:22 ` Reimar Döffinger
2023-08-04 9:14 ` Casey Smalley
2023-08-04 10:48 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bfd7faea-bd3e-0b4c-ba29-c78119e1bb8b@arm.com \
--to=casey.smalley@arm.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git