From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 199434ADB4 for ; Tue, 23 Jul 2024 00:17:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 35C7A68D473; Tue, 23 Jul 2024 03:16:59 +0300 (EEST) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A8CFC68D2F7 for ; Tue, 23 Jul 2024 03:16:52 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id B79302819FB18 for ; Tue, 23 Jul 2024 02:16:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1721693810; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DTqPrV6uOU2FcEbtLeI1qmfqK0m/HirmCoQWRjSsFOg=; b=HqHGFUfH4GYhVKVmFzI5k2hKjEvzmS4ivloj5cg68pdbRDmV3D2CB5bG+UJxe88McQc9yr Kzmjezu2Syl5JeE4u0Hi30mUnFROowwmsFkLxm1RjaUmCsBNZxCnOVzrJtX3ohrxia3E/a BY9OxUnrejQ7YdD/2JssC4EXGOVBPmJNZa9CrPpIqH2ohSvcvgKxxvoti46rb7rKOdBVmX thl8Leioz4Bsp1gtihcPCd00eHukNDGPyd8wdVhKVmJJRRzO23V/RaZc6MbM1kBC8GmFnL Rh75pzJWtHN65cnl4VGWwcjdT7KUO04a3/Ul2WDe3EsslKoFX9eUPQOkEpUSqg== Message-ID: Date: Tue, 23 Jul 2024 02:16:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240709190547.99246-1-joshua.allmann@gmail.com> Content-Language: en-US, de-DE From: Timo Rothenpieler In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/h264_mp4toannexb: Prepend SPS/PPS to buffering period SEI X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 23/07/2024 01:01, Josh Allmann wrote: > On Tue, 9 Jul 2024 at 12:06, Josh Allmann wrote: >> >> Encoders may emit a buffering period SEI without a corresponding >> SPS/PPS if the SPS/PPS is carried out-of-band, eg with avcc. >> >> During Annex B conversion, this may result in the SPS/PPS being >> inserted *after* the buffering period SEI but before the IDR NAL. >> >> Since the buffering period SEI references the SPS, the SPS/PPS >> needs to come first. >> --- >> >> Notes: >> v2: Updated FATE test refs >> >> libavcodec/bsf/h264_mp4toannexb.c | 13 +++++++++++++ >> tests/ref/fate/h264-bsf-mp4toannexb | 2 +- >> tests/ref/fate/h264_mp4toannexb_ticket2991 | 18 +++++++++--------- >> tests/ref/fate/segment-mp4-to-ts | 12 ++++++------ >> 4 files changed, 29 insertions(+), 16 deletions(-) >> > > Ping again for review. Looking at the FATE output, this patch fixes a number > of things - see [1] for details patch generally looks good to me, but I'm not closely familiar with the code there. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".