From: "Martin Storsjö" <martin@martin.st>
To: Dmitriy Kovalenko <dmtr.kovalenko@outlook.com>
Cc: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] swscale: rgb_to_yuv neon optimizations
Date: Fri, 30 May 2025 10:09:58 +0300 (EEST)
Message-ID: <be6b67e5-1ab0-51f3-1690-325a4f58ca8c@martin.st> (raw)
In-Reply-To: <2B10E794-CFC3-4CBA-9732-0E9B7C6A8CF5@outlook.com>
On Thu, 29 May 2025, Dmitriy Kovalenko wrote:
> I appreciate the review for both the commits. I did fix all the
> unrelated changes and iterated in the new version, would appreciate the
> rearview.
Don't top post.
There are still at least 5 of my comments unaddressed. If you are not
going to address them, then you need to respond to the comments and
explain why you think the change should be kept as is.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-05-30 7:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-27 16:57 Dmitriy Kovalenko
2025-05-29 18:53 ` Martin Storsjö
2025-05-29 21:38 ` Dmitriy Kovalenko
2025-05-30 7:09 ` Martin Storsjö [this message]
2025-05-30 7:18 ` Dmitriy Kovalenko
2025-05-30 7:22 ` Martin Storsjö
2025-05-30 7:07 ` Martin Storsjö
[not found] <20250531091631.45342-1-dmtr.kovalenko@outlook.com>
2025-05-31 9:11 ` Dmitriy Kovalenko
2025-06-05 12:00 ` Martin Storsjö
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be6b67e5-1ab0-51f3-1690-325a4f58ca8c@martin.st \
--to=martin@martin.st \
--cc=dmtr.kovalenko@outlook.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git