Re: [FFmpeg-devel] [PATCH 17/19] Remove obsolete version.h inclusions

["Martin Storsjö" <martin@martin.st>]

On Wed, 23 Feb 2022, Andreas Rheinhardt wrote:

> Martin Storsjö:
>> On Tue, 15 Feb 2022, Andreas Rheinhardt wrote:
>>
>>> Forgotten in e7bd47e657bbf9e1ce9915e93bc80cb1a29fb7f3.
>>>
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
>>> ---
>>> libavcodec/vc2enc.c            | 2 +-
>>> libavcodec/x86/blockdsp_init.c | 2 --
>>> libavfilter/internal.h         | 1 -
>>> libavfilter/vf_swapuv.c        | 1 -
>>> libavformat/url.h              | 1 -
>>> libavutil/common.h             | 1 -
>>> libavutil/internal.h           | 1 -
>>> libswscale/swscale_internal.h  | 1 -
>>> 8 files changed, 1 insertion(+), 9 deletions(-)
>>
>> LGTM
>>
>> What do you think of the includes of version.h in
>> libavdevice/android_camera.c, libavcodec/mediacodec.c,
>> libavcodec/mediacodec_wrapper.c and libavcodec/xvmc.h?
>>
>> // Martin
>>
>
> The one from android_camera.c stems from a misunderstanding: It used
> LIBAVDEVICE_VERSION_INT until 13b77af2f0b56d6c87bb147947337981c21f4245,
> so it is safe to remove (or replace by lavu/version.h).
> The mediacodec.c has been added for reasons unknown and seems to have
> been unnecessary all the time.
> The one in mediacodec_wrapper.c stems from the same misunderstanding as
> for android_camera.c. Has been fixed in
> c0bce367e4932f0fb09195e6978ac1a5a60480a4.

Thanks!

> xvmc.h's inclusion is certainly unnecessary. But who cares given that
> this header isn't included anywhere?

It just came up when grepping for 'version.h', and I was trying to check 
whether it could be enough with 'version_major.h' in my patchset or not.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".