From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B30C04971F for ; Sun, 18 Feb 2024 18:38:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id F13D068D36C; Sun, 18 Feb 2024 20:38:56 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 998FF68D222 for ; Sun, 18 Feb 2024 20:38:50 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 6DCC0E9FC1 for ; Sun, 18 Feb 2024 19:38:50 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8xJRhAvwkm1r for ; Sun, 18 Feb 2024 19:38:47 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 435C2E720E for ; Sun, 18 Feb 2024 19:38:47 +0100 (CET) Date: Sun, 18 Feb 2024 19:38:47 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <5fa600da-3af2-488a-bd4f-9a6f630c7ab3@gmail.com> Message-ID: References: <20240218104534.17743-1-cus@passwd.hu> <5fa600da-3af2-488a-bd4f-9a6f630c7ab3@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fate: use an even more exotic channel layout mov-mp4-pcm-float test X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 18 Feb 2024, James Almer wrote: > On 2/18/2024 7:45 AM, Marton Balint wrote: >> The old layout happened to be a native layout and therefore missed some >> recently fixed layout parsing bugs. >> >> Signed-off-by: Marton Balint >> --- >> tests/fate/mov.mak | 2 +- >> tests/ref/fate/mov-mp4-pcm-float | 4 ++-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak >> index 4850c8aa94..8d154c8b5b 100644 >> --- a/tests/fate/mov.mak >> +++ b/tests/fate/mov.mak >> @@ -187,7 +187,7 @@ fate-mov-mp4-pcm: CMD = transcode wav >> $(TARGET_PATH)/tests/data/asynth-44100-1.w >> FATE_MOV_FFMPEG-$(call TRANSCODE, PCM_S16LE, MOV, WAV_DEMUXER >> PAN_FILTER) \ >> += fate-mov-mp4-pcm-float >> fate-mov-mp4-pcm-float: tests/data/asynth-44100-1.wav >> -fate-mov-mp4-pcm-float: CMD = transcode wav >> $(TARGET_PATH)/tests/data/asynth-44100-1.wav mp4 "-af >> aresample,pan=FL+LFE+BR|c0=c0|c1=c0|c2=c0 -c:a pcm_f32le" "-map 0 -c copy >> -frames:a 0" >> +fate-mov-mp4-pcm-float: CMD = transcode wav >> $(TARGET_PATH)/tests/data/asynth-44100-1.wav mp4 "-af >> aresample,pan=FR+FL+FR|c0=c0|c1=c0|c2=c0 -c:a pcm_f32le" "-map 0 -c copy >> -frames:a 0" > > Wouldn't FR+FL+LFE be enough to test this? While also generating a file > that's realistic. It depends on what you want to test. With the old code, for FR+FL+LFE, only the channel order would have been wrong, with FR+FL+FR also the channel count. Having the same channel position in the same track is not that theoretical, at least for MOV I have samples where an additional FR/FL track is used for Music/Effects. I admit, for MP4 that might be less common though, and I also admit that using a separate track for it would be better. But as we know, nothing is ideal in practice... Nevertheless, I can change the test to FR+FL+LFE if that is preferred. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".