From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EC57244967 for ; Mon, 31 Oct 2022 05:55:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EB7B968BD92; Mon, 31 Oct 2022 07:55:19 +0200 (EET) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AAA6868BD68 for ; Mon, 31 Oct 2022 07:55:12 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667195717; x=1698731717; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=3V9E1u+bBV1MUkYF2/p6iQTCwoSodqFXSbGwInCQJ6E=; b=ThD+JuqvOKO4pjanf0HouEmylo26FdG0fuwznthhffhcngEwwe8xS0ps RLACxzUCCRqn9/kbtworQ46dV8uogiFLIvJzvvucrpF69GeA3R3GztXtW aT57wWkQMvuv3Sf1ssJBD/mfF6kpgdDXzraHzNmeK89Fps/RSdtfqVC2w /OA7bDVJjg/QhRyEnyUAFWbn8gG8DVqF+8/kqwlQXi2FWaqili3SM/L18 7f6Yh39YHVlj7zFcx7r5RMjo+vz6AEKmcbifG/qrjHbpe/teUNKk1jf5b Q6ZBbIGMI0ObGD3RxHUHSmY8cg2b7iBp+CE4FpiNllxYdNTPLVzaRxHUi w==; X-IronPort-AV: E=McAfee;i="6500,9779,10516"; a="370895500" X-IronPort-AV: E=Sophos;i="5.95,227,1661842800"; d="scan'208";a="370895500" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Oct 2022 22:55:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10516"; a="738830888" X-IronPort-AV: E=Sophos;i="5.95,227,1661842800"; d="scan'208";a="738830888" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga002.fm.intel.com with ESMTP; 30 Oct 2022 22:55:09 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 30 Oct 2022 22:55:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 30 Oct 2022 22:55:06 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 30 Oct 2022 22:55:06 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.42) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 30 Oct 2022 22:55:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=BTdSeQe9ZOT6TYl8+1+QeXzb2ub2nNA/1m60/6/5piPEwNZx/CTC7n46pcsV8fAYDpEk1eAKwEZeuS/fSBqi7j9kBeL53+tWwfWZ/5GwgjuCqL+wgiPM+hSfdsb+qdkiW8A4kQqizGxhSoCirYykRx121PiplsKTHMrbaOwOwIg67isa+j0CuSKkKpg9RN9pczCM2LUA+00/SfGuol4s0TqLA8xdM/XmWVP5gJKp/ff0kMqqur7cZzYciUBpZg+U+nGD9oaqfDHqa6njGgGAzcYq3sgv+zbS13oWCDvzAOwose1suvwsGZ5W97BXgfW7LuE0O/C4xCFItVGpVOFNqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3V9E1u+bBV1MUkYF2/p6iQTCwoSodqFXSbGwInCQJ6E=; b=LIjUpCwtaQ4B4Bh7ufcecp573QI/E9Gb0Z2IG8P0R/IGCy2IVXjK6kfP+bH/mSdCWpqvYs1lzfnO15X7H+J3XSEhfaHm8bpK0+AyI3eJlevKvx1x7BdDNvtRAQeRBFP0MzmDmEyYKxAoDci5TahKweJHarWpt6oFtpMrLtkNThpejGva2ecK7CowsJixHs511mJRvyNC0ldDKhrNbUjeWi7xXLRLqsO4XV8AZqERGzTBEhG4tXTR94OjuFuxtla0IDFU3kcVJX3RuN9VhnS66kgAaB9pX6IYBmSrdxEOIY8qyuVpsa8B+XtzR3lExsPNYVo0T4y35+/v8RucpRvyCA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SA2PR11MB5049.namprd11.prod.outlook.com (2603:10b6:806:11b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5769.19; Mon, 31 Oct 2022 05:55:04 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8c4d:83ab:3e7a:3f23%5]) with mapi id 15.20.5769.019; Mon, 31 Oct 2022 05:55:04 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 01/11] avfilter/overlay_vaapi: use FILTER_SINGLE_PIXFMT Thread-Index: AQHY3JbJYmF8tLCDU0WU0VWqG1l7Fa4oIXcA Date: Mon, 31 Oct 2022 05:55:04 +0000 Message-ID: References: <6ec5e9960b725a21a4b0dad188d4eddd8b3571c5.1665399281.git.ffmpegagent@gmail.com> In-Reply-To: <6ec5e9960b725a21a4b0dad188d4eddd8b3571c5.1665399281.git.ffmpegagent@gmail.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: BN9PR11MB5515:EE_|SA2PR11MB5049:EE_ x-ms-office365-filtering-correlation-id: 921fbc75-aaa3-4b5f-a742-08dabb047512 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qoOdv5g409VUHck/GyXqf+fuHJY2mXfAPkWcscahI301f/dTyJ1GcJFlgEA5NJHCH1dAs5KtJk6V1V8rByivVk5dpn/GwGnGKgLvQGIAlnR7/L/LE0GGE3HpEvaud9Ifu5yNOMmchrobpNBToM7FtZBZOFrQ8TOs7Ufz3IyDzkONDvt2TOKoW7iiTEPhKxIVADvtArWvS5OLEAG0AE23pRwOoH8+Q+cV2ecvPCKfdv7m9a9A5p3M5pHwS8M4DdsY5qZuK32iLfDuEqxuZqTFu8aCtw/R7/MenLLkjViz46TmaQJ+/mOJepbwgcK+4IIOSSgJLYWTSYpMas46m0VAQ1C/BnlxgIFqcj0MH2Bn5SOx94A/aXDQ3DbLhvfo2JlsbgwS6JYIsbh5vMmrzT/D1IMAioUaNYJMdRgubguFnt3lpe/lP33SD6A6+vws/ClqBzC7UOnGw4GieAFXVOpCjjysw25tUwL25ZnH50mjwbw5g+hpbWknjWH1arcupF0B3407ZPl4LwCG3EtPHhDbSNb7QbgN79dUPDceVavGt/CR7mhx7XxAtcgObY9dSgvs/QdIlHezu1/MHmYcU6YbmMiKJdOXVjvUkuyRyzsgw8jFnSuC3aqpMDVmcIpkl1VbYTLKXI4yFI65cYJ6m9wBQLgH+O6EqsaEOdNq/Hg/SRuvWz6HGjFlpteupAKPoYfZefOlC5uVrILbKf4NND/D2LKoRyerJ8lDuzfO00cHEaufeFbU9RsFiFXSxb7+Gzr4PbpxfCF8P37IcwWDSK4rcg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(136003)(376002)(39860400002)(396003)(346002)(366004)(451199015)(83380400001)(6486002)(2906002)(71200400001)(4001150100001)(122000001)(86362001)(38070700005)(36756003)(38100700002)(82960400001)(6512007)(2616005)(26005)(186003)(8676002)(91956017)(66946007)(66556008)(316002)(64756008)(66446008)(66476007)(4326008)(478600001)(76116006)(41300700001)(6506007)(8936002)(6916009)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cHF6bWZGdXF0NVpabkx2VlN3UWVRYTQ1YWx6eFNoMUsyQ29ZSWdIZVdVTytK?= =?utf-8?B?ZVlsM1lXRDRKNjAzdmFPWnVIZUZNcHl1SFB4eW9ab21LR1h1NU5acFFVMGRh?= =?utf-8?B?NGpBZE8vZXMwUGtUc25NR2tFK0VxbmRqWjJPMlFCeGo0OXBkcnBxSnlaSGRR?= =?utf-8?B?VzJZaEFtZkRwekk0ZnZGZ1NOWHBSWGY0aHByTjB1S0htd1F3Yy9UN3FaMFJH?= =?utf-8?B?RXRYOU5uTE5ZTFZ4dUlnNGdoNVRDRWhwSmZKRjhVVW90REswUjNKNHV5SjJO?= =?utf-8?B?SHBsVDJrM05CQ0NNUWlGMmtFaDUrdWJXS0ZHRWQ3NjJHR2xUQjIxVXpIamNR?= =?utf-8?B?eGRRWGlnR3EwcTgyblZac1ZBbVRIWmFvTTcra1IrZ0FBOFlwa3RrNW9VbnM4?= =?utf-8?B?cGc0QzdYTytLMG0zQnBRRE1qOGhjaXVMQ3MxRFhNQnlkNzJVeWFKTWRacHFp?= =?utf-8?B?Sy9HZVEzREtWN01wdVRyZjU4Z2JXQmZQbHEvdndndFR6dm5hc0MzVWlKSUtt?= =?utf-8?B?RlBrMGthNlQvK0VRTmpwZXA4YmJjSzVwb0tYaWtWakdGdng3LzJFNXJQczV4?= =?utf-8?B?QzdSSUY0cUovTzNwb3JiNWFyRUV3V3d4M2ZGT0sydnJHZWhRTllCUHZ2ZUtE?= =?utf-8?B?dm5nU2xXUlpLQWpZcGZEeXRPRmtDcGt6RWlOMHBKNmhGNDhOalpSTEpoUTdR?= =?utf-8?B?Y0xWQXFyZVdXS1A2WVlRRDJLSytMV0RHcXozVXVzRWZkYW9uMHVjY0NUb2pN?= =?utf-8?B?bUs2bTlzZzg4cnR4TytvK3NWR3NpRmRTMlBVQmpBcWJqeTBMQXdZMUgzaTdj?= =?utf-8?B?enVUMDB5cjB6eW5zeXU3Z243TTBWb0x3UGtJUDN1QmxTWEZEbFdUZE1ib0Vt?= =?utf-8?B?U2YwK0pKVFo1czlicG9pdms2dFRDQjdhUFJWTUdkYTZFMXAxdklVZi9ydnZ1?= =?utf-8?B?REx1cFRBdFlydWRySzl5Tks4NTRZRVhHUzU5ZGtNbEFzcFAzVTRVbUk3bWlH?= =?utf-8?B?dGF4UU1oSURJbVFPcU9Ba09XellKWFB5ZmwrNGNDZ1JhVmg4Y0RJK1lkRmNr?= =?utf-8?B?WW5LbFdSUXY2R3dkeDVQUnRCanBGR2M0V1dnSnRVdDVha1J2Mmt1bHU5a2Nv?= =?utf-8?B?eU93QlFjSUNDY3JlRC9LRUljUm1QUFhmNmRWRzlHeWdWLzFFWUxHaDl3UXVB?= =?utf-8?B?WkdHcElCdWUwWGxvUW1kRmh2MzJlYWZMb093WmpHaUs2UTZDRE9WTTV1Vzhj?= =?utf-8?B?UG9jN0x1Yis2TnZTd1ZEOThWV0dYVnJUY3N1V25ObHA4NVhWbllMbWVranJV?= =?utf-8?B?dzRLSHFkV2lEVjR0ci9PcDQ0bEZpNW92b0kyb2U4MUhHc2RSVHNMdjFEOHhh?= =?utf-8?B?NW5xZXFqWU1BZjNDTnY3aTQzb0NVc2FiWjloVStTenlqWnZyQytUWlNqdUNw?= =?utf-8?B?K245d21jdHhJVnBHNDVtR2Q0TTFiMDVnMytvMElnRGNlMjVjYVRuOXIzc1ZK?= =?utf-8?B?cU9TL0lwZWEvUHRON3ZXR0JnTEV0N3FGYzFNbmtwUTNGTlRqUVk0cGoyNVQr?= =?utf-8?B?M2taelFNYUVvM01iUG5NcEgzMHZFdFBrSTVOWGR1a1ZtZUl6Nmp5Tlc2QXNL?= =?utf-8?B?bENFN0ozUWNyN09SZkwxaFZlTmE3aVg0SEZldSs0eE1TdkluUUZwZ2M5NFp5?= =?utf-8?B?MXpjcHB5bW1WYk1tVVNwT29JSmlObHBZakUySGhnQkhsUEZwb2xRZnFLZ2xZ?= =?utf-8?B?N3pWL0VJZGs4bFhXa2NYaGxzTlZCemVVSHZFOFBveldidjVWdVRQYUxDekJW?= =?utf-8?B?cndtZ2l3dCtyTUxYRFFSZkdtbERVbDF0V2s1NldUajNFTFZhdmUxZmNsK1Bk?= =?utf-8?B?RUtWNG1IZXRkR09zRXU4NmJVUWFnSFFqd0hDMTV4Qnp4SVU0cG5ybnlMbk9n?= =?utf-8?B?RDBPNXdyS0dzbndXeWpBaElBSEtlcG1kcWVnamdablkyc1B1QXQzNi8welRD?= =?utf-8?B?ZmhoT0hxbVd0aGVIM2hPdDBUYUZOODNaZk83VzF0cEhWMEhNWXQvYkpqREg2?= =?utf-8?B?QzhtYnNaL1VXZEJNcmNVMXFaUTJwbTQ4UTZQZk5tQjZqU0FWdjI1bTUvV0Nh?= =?utf-8?B?N2ppd0xYOEhGRVE0WmxzQUVyMWlRZlFrenFONVQ1b21JaWJMTjFCcmZROTFG?= =?utf-8?B?Q2c9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 921fbc75-aaa3-4b5f-a742-08dabb047512 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Oct 2022 05:55:04.4454 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xbzwjYnV6KGZSbKx3Lf5gVt+w4Y3HHC/h+Keu3KeMMmwvnwo8tqq1ZCvvG0GmUPwV4pzt6SF4Y7eO7ZF2vxHCg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5049 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 01/11] avfilter/overlay_vaapi: use FILTER_SINGLE_PIXFMT X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "softworkz@hotmail.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-10-10 at 10:54 +0000, softworkz wrote: > From: softworkz > > Signed-off-by: softworkz > --- > libavfilter/vf_overlay_vaapi.c | 30 +----------------------------- > 1 file changed, 1 insertion(+), 29 deletions(-) > > diff --git a/libavfilter/vf_overlay_vaapi.c b/libavfilter/vf_overlay_vaapi.c > index 3e6a0de13f..218daf571f 100644 > --- a/libavfilter/vf_overlay_vaapi.c > +++ b/libavfilter/vf_overlay_vaapi.c > @@ -38,34 +38,6 @@ typedef struct OverlayVAAPIContext { > float alpha; > } OverlayVAAPIContext; > > -static int overlay_vaapi_query_formats(AVFilterContext *ctx) > -{ > - int ret; > - enum { > - MAIN = 0, > - OVERLAY = 1, > - }; > - > - static const enum AVPixelFormat pix_fmts[] = { > - AV_PIX_FMT_VAAPI, > - AV_PIX_FMT_NONE > - }; > - > - ret = ff_formats_ref(ff_make_format_list(pix_fmts), &ctx->inputs[MAIN]- > >outcfg.formats); > - if (ret < 0) > - return ret; > - > - ret = ff_formats_ref(ff_make_format_list(pix_fmts), &ctx- > >inputs[OVERLAY]->outcfg.formats); > - if (ret < 0) > - return ret; > - > - ret = ff_formats_ref(ff_make_format_list(pix_fmts), &ctx->outputs[0]- > >incfg.formats); > - if (ret < 0) > - return ret; > - > - return 0; > -} > - > static int overlay_vaapi_build_filter_params(AVFilterContext *avctx) > { > VAAPIVPPContext *vpp_ctx = avctx->priv; > @@ -418,6 +390,6 @@ const AVFilter ff_vf_overlay_vaapi = { > .activate = &overlay_vaapi_activate, > FILTER_INPUTS(overlay_vaapi_inputs), > FILTER_OUTPUTS(overlay_vaapi_outputs), > - FILTER_QUERY_FUNC(overlay_vaapi_query_formats), > + FILTER_SINGLE_PIXFMT(AV_PIX_FMT_VAAPI), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > }; Patchset LGTM except a nitpicky comment about coding style in patch 09/11. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".