From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 42DB34B6E3 for ; Tue, 11 Jun 2024 18:44:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C4F9F68D8BA; Tue, 11 Jun 2024 21:44:34 +0300 (EEST) Received: from mail-oa1-f43.google.com (mail-oa1-f43.google.com [209.85.160.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5EBD868D8B1 for ; Tue, 11 Jun 2024 21:44:28 +0300 (EEST) Received: by mail-oa1-f43.google.com with SMTP id 586e51a60fabf-24c9f91242dso646577fac.2 for ; Tue, 11 Jun 2024 11:44:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718131466; x=1718736266; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ogbTYOJZkvhLyG98Eej6kIXUlu5eY3DdD0Z8v6e66m8=; b=S94SdF54+MPpG7QGb3RZnlpFcgfLspA7uAE1oqqvfGOmJCprLckR+ZwpSrWBS9QsTr hpqCtgCQp0p8G8zhUmWbUy1+/uhZ9cWsRlzwiKRIyiTFEtMrB2SlWvo+lbVIO0lpNlR1 47XgvRWAbEkFuwhLqbbVmSFcor3fXlqjYY8AGmw2dgkLMkUZOADWE2lddfLGL49L4phy hDebNlRpN2hZAMvxpQlrXkk3H6Dcub/cJt5G37Bqs6BLE8lhwvRmnYZ6+QOlva8j5gCj dtTQmtc0UcjDRdxctudA2HJz43BJEaOeo3y3gK/Sxci6rjlUWwgglESaTyzFgjf7je+k pDnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718131466; x=1718736266; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ogbTYOJZkvhLyG98Eej6kIXUlu5eY3DdD0Z8v6e66m8=; b=MjWzrH6PSwKL9ILNWGmeshk1sjexZ8fSc4jY17tqJtEg/+7AsdW7Yr0gif9hFErofK OhiI3KjbQm7hwD0tT+lMsYvX4DfsCrim5D7GhlN+LG9WOomzDZHLNXwkCvKD62+JL+X0 0Kpz00ryhfYsjsSEA3j8pJKyFS2MQrg3GTbte6b2mgEE6t4+nZLwsd7ymcBbe78jzU+g ZOLgDYHOTut1l3DyCzEi7aHhpgA55BX9HQUAeQO8gXuKvmCmPF62o8IlzzCIje7bNWpV 36jGo6NSkBgu9z14wyGB9NIo7STy1RX3PZJrCMNPwv4j+rbEXs3UL67BcKazSq7azSfz 2Pgg== X-Gm-Message-State: AOJu0YxHzbEyvM3u1hVNyliY36LmW50SDZHZosEwc0B7iSi4DLgdz25J tuLaV2SuRtTV7kfnbDVJ3ZHz662vw6lXZ2YP68ufX79X93qD4U4P7qsDGg== X-Google-Smtp-Source: AGHT+IE0+dpbszFrgLSFqPjmR7PPqCQT4ehDp4ohXS/RNHDEVLcRCUORw1VVlwQaG5esSVd603SRNg== X-Received: by 2002:a05:6870:9611:b0:24f:ee10:78a4 with SMTP id 586e51a60fabf-2546462ce73mr14245341fac.42.1718131466141; Tue, 11 Jun 2024 11:44:26 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f719317d62sm38660005ad.2.2024.06.11.11.44.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Jun 2024 11:44:25 -0700 (PDT) Message-ID: Date: Tue, 11 Jun 2024 15:44:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240610184408.68171-1-derek.buitenhuis@gmail.com> <20240610184408.68171-2-derek.buitenhuis@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20240610184408.68171-2-derek.buitenhuis@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/10/2024 3:44 PM, Derek Buitenhuis wrote: > These originate from the Apple Vision Pro, and are documented here: > > https://developer.apple.com/documentation/coremedia/cmprojectiontype > > Signed-off-by: Derek Buitenhuis > --- > libavutil/spherical.c | 3 +++ > libavutil/spherical.h | 16 ++++++++++++++++ > 2 files changed, 19 insertions(+) > > diff --git a/libavutil/spherical.c b/libavutil/spherical.c > index 800d3459a5..d78f98f945 100644 > --- a/libavutil/spherical.c > +++ b/libavutil/spherical.c > @@ -57,6 +57,9 @@ static const char *const spherical_projection_names[] = { > [AV_SPHERICAL_EQUIRECTANGULAR] = "equirectangular", > [AV_SPHERICAL_CUBEMAP] = "cubemap", > [AV_SPHERICAL_EQUIRECTANGULAR_TILE] = "tiled equirectangular", > + [AV_SPHERICAL_HALF_EQUIRECTANGULAR] = "half equirectangular", > + [AV_SPHERICAL_RECTANGULAR] = "rectangular", > + [AV_SPHERICAL_FISHEYE] = "fisheye", > }; > > const char *av_spherical_projection_name(enum AVSphericalProjection projection) > diff --git a/libavutil/spherical.h b/libavutil/spherical.h > index 828ac836da..118fbcc3d1 100644 > --- a/libavutil/spherical.h > +++ b/libavutil/spherical.h > @@ -66,6 +66,22 @@ enum AVSphericalProjection { > * the position of the current video in a larger surface. > */ > AV_SPHERICAL_EQUIRECTANGULAR_TILE, > + > + /** > + * Video frame displays as a 180 degree equirectangular projection. > + */ > + AV_SPHERICAL_HALF_EQUIRECTANGULAR, > + > + /** > + * Video contentframe displays on a flat, rectangular 2D surface. > + */ > + AV_SPHERICAL_RECTANGULAR, This should ideally be the enum with value 0, but until next major when such a change can happen, it would be IMO a good idea if you set spherical->projection to AV_SPHERICAL_RECTANGULAR in av_spherical_alloc(). > + > + /** > + * Fisheye projection (Apple). > + * See: https://developer.apple.com/documentation/coremedia/cmprojectiontype/fisheye > + */ > + AV_SPHERICAL_FISHEYE, > }; > > /** _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".