From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4356B40935 for ; Thu, 3 Mar 2022 18:32:08 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7343368AF00; Thu, 3 Mar 2022 20:32:07 +0200 (EET) Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E6EF687992 for ; Thu, 3 Mar 2022 20:32:01 +0200 (EET) Received: by mail-oo1-f41.google.com with SMTP id r41-20020a4a966c000000b0031bf85a4124so6790586ooi.0 for ; Thu, 03 Mar 2022 10:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:content-language:to :references:from:subject:in-reply-to:content-transfer-encoding; bh=YYOV5SspKNie+JtN7loAVImrPZAAe/cDs4lqNYZ+8ng=; b=aQIN3HwqP/FXnEQJDydfHnIBTjZ0nAreU2pfIp1s9xLouYZYsBqZGys3iVLgFPb+qj FsrLfdZfroG6JmJaHjGe27/mEYoht7DIgHtwL6hKV4O9nv1yNuSqFdkbrM6oaRnTcgkt YSMbRKeIm3vRx74Jfv/mbCJdhNg8eoW6geRnXVFZxPzb8HVQrz3GS8X9mX/PMzhzTj14 q7kvqwnT4z/tS45ji2xy6YBflcKdofjPUiBu73yOBDwFgLNbF5O0kJkdHjwFcY2BuENZ so0+FT7UsOQ1JbFN6deeZPORZ3U2eP6djlGJMI+Svr7RtuOLt1Vcu/R9KXEtETk6E7II S3dA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent :content-language:to:references:from:subject:in-reply-to :content-transfer-encoding; bh=YYOV5SspKNie+JtN7loAVImrPZAAe/cDs4lqNYZ+8ng=; b=CzlY6mLGjXEt4C3BSqZ2f6bROiSynZ4S2BKTBAMF9U4UnGtOgvWbAsxhrlr0jnWldP c1yoawAuh/J7Ojt4fXZ46784p8FM2rMMDsdncUBtFligthW11DJa9CY3yFyj56vDzEpB umcHyY634k4mld7jZzeCAGzelhhcYVH4LfApn2HBY2vcc45IaT4iCFtg+oEw1IzmnSrE C+uv7+aCfYRbpQVSUsc1yMPJ3GZL0LFZLf44ql/5uyPqUOcuyQ7WAYA/djjxB3hiC9Cx gcrCcEZDoiBcaXm+t0CjyrDWhMA/WC7/caAfUfIYF0z+X6vMU9Az2nkx/qsHc1sAGfx1 VkwA== X-Gm-Message-State: AOAM532DZpeHbtICduSfdmOrSW27tyZdgqNfnJDDAl96Eo1udV8yfKN6 Cgqo3RPpCPQSdAY8V2hCWxlBRg9H0Gc= X-Google-Smtp-Source: ABdhPJy1+EB/slZ5tbd6BtKifuSQrmecJlgEvDi/RYnR3uam0E0TxXO04CLtX56BTx2IPyMn52f4og== X-Received: by 2002:a05:6870:3113:b0:d3:473b:3f1d with SMTP id v19-20020a056870311300b000d3473b3f1dmr5055164oaa.116.1646332319137; Thu, 03 Mar 2022 10:31:59 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id n62-20020acabd41000000b002d97bda3870sm1352532oif.53.2022.03.03.10.31.57 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Mar 2022 10:31:58 -0800 (PST) Message-ID: Date: Thu, 3 Mar 2022 15:31:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220302184023.285022-1-george@nsup.org> <20220302184023.285022-5-george@nsup.org> From: James Almer In-Reply-To: <20220302184023.285022-5-george@nsup.org> Subject: Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/2/2022 3:40 PM, Nicolas George wrote: > diff --git a/tests/fate/libavfilter.mak b/tests/fate/libavfilter.mak > new file mode 100644 > index 0000000000..692f1d4960 > --- /dev/null > +++ b/tests/fate/libavfilter.mak > @@ -0,0 +1,9 @@ > +# avfiltergraph.c : pick_format() : video / don't lose alpha > +FATE_LIBAVFILTER_NEGOTIATION_VIDEO += fate-libavfilter-negotiation-alpha > +fate-libavfilter-negotiation-alpha: CMD = lavfi_dump testsrc2=d=0,format=rgba,scale,format=yuv444p/yuva444p > + > +FATE_LIBAVFILTER-$(call ALLYES, TESTSRC2_FILTER FORMAT_FILTER SCALE_FILTER) += $(FATE_LIBAVFILTER_NEGOTIATION_VIDEO) > + > +fate-libavfilter: $(FATE_LIBAVFILTER) $(FATE_LIBAVFILTER-yes) > +fate-libavfilter-negotiation: $(FATE_LIBAVFILTER_NEGOTIATION) $(FATE_LIBAVFILTER_NEGOTIATION-yes) > +FATE_FFMPEG += $(FATE_LIBAVFILTER-yes) This can be simplified as such: > # avfiltergraph.c : pick_format() : video / don't lose alpha > FATE_LIBAVFILTER-$(call ALLYES, TESTSRC2_FILTER FORMAT_FILTER SCALE_FILTER) += fate-libavfilter-negotiation-alpha > fate-libavfilter-negotiation-alpha: CMD = lavfi_dump testsrc2=d=0,format=rgba,scale,format=yuv444p/yuva444p > > fate-libavfilter: $(FATE_LIBAVFILTER-yes) > FATE_FFMPEG += $(FATE_LIBAVFILTER-yes) No need to add a fate-libavfilter-negotiation target until there are more such tests. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".