From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 40A3740983 for ; Tue, 1 Feb 2022 22:35:00 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E171968B1CE; Wed, 2 Feb 2022 00:34:58 +0200 (EET) Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 6E17B68AF51 for ; Wed, 2 Feb 2022 00:34:52 +0200 (EET) Received: by mail-ot1-f54.google.com with SMTP id p3-20020a0568301d4300b005a7a702f921so857221oth.9 for ; Tue, 01 Feb 2022 14:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=njtr27/M4e8QTiGqMjF2WD4HL7xWl2fyOX0UAt8NA6k=; b=ZZ0dtLM6EEU2C3bl2Kd1D5BwYm5aAbI+YcnZ+ddQPsQFuvRZEBhtQ5no3vUXpHsd/h xAN78QPihOnV6Dd7Km14o4VVqeQYlDiidcBJEzs9MZdrIfWXRV3xMpxsoPkFY9CwgS1O 0cY9IiGwnkhnCBqgMezq+ZVQPpv47Me0wgCZUsqzrm14Yn5AWIA9jubNzdwHg+fN8V6U xaZFP/U1aYys6UcGvg4VLzlPKjtOnHfYhTStwiAiNd5gGnYvCKQ9d/rvrMWgpuJe2GSU inJZ6EcKMIx8Uzv7j74ALoqyU6jelmc19dCRxeNrqyNFECLvGx3qm3TjxgdqUsldIOLl 2qMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=njtr27/M4e8QTiGqMjF2WD4HL7xWl2fyOX0UAt8NA6k=; b=G8ywf8Oqin3tNAmkrVzKicl6kjFl/4T2HZ8Lk3pHVHM1S486KhAD5OYIQBmunQcGQ6 hfZFpOZLQJZGHve7fVYKGA8ri3gEvj4FRA7jxIBQMo+BzMluLmae+bH1BB0G+hjjwFtD isb239VAG30R/w05jHvMtRaNSf8U0tl/a9vfIxxgPRDSKJJDqbruSm9xxRvN/2fCeuKG GWOW+6Ys0rglKc7cIrHkNIUzRrT8pX8mS+/txlTl1OnjnRjS3FMHxR7u3NpbscNWvhhg 6KfyLl6YqWuu07t6af9ulvSpMYOAu4S65A39PZoJO9cIC0g5DXt9i+tRbjoroD1kux5N HFmQ== X-Gm-Message-State: AOAM533X/Qd+cSGe5P3kdY+d5H14WfpKbLEVhs5aC9F9Oe/7S80OgZsm lOE7W+oYKHcN1n+AiOUP5l3+UDNvO0s= X-Google-Smtp-Source: ABdhPJy7YlRooDUFvI4Z9ltKHjhkOfE+XqXGhNcMVCMIGTM6fvt73iFkIEGehCSR7NZMPL/PrrfLsA== X-Received: by 2002:a9d:4e03:: with SMTP id p3mr15574433otf.299.1643754890500; Tue, 01 Feb 2022 14:34:50 -0800 (PST) Received: from [192.168.0.10] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id s3sm14270796otg.67.2022.02.01.14.34.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Feb 2022 14:34:50 -0800 (PST) Message-ID: Date: Tue, 1 Feb 2022 19:34:48 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220201223058.31090-1-scott.the.elm@gmail.com> From: James Almer In-Reply-To: <20220201223058.31090-1-scott.the.elm@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] lavu: make av_get_media_type_string() never return NULL X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/1/2022 7:30 PM, Scott Theisen wrote: > printf %s with a null pointer is undefined behavior > --- > libavutil/avutil.h | 3 +-- > libavutil/utils.c | 3 ++- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/avutil.h b/libavutil/avutil.h > index 4d633156d1..4bd468d72f 100644 > --- a/libavutil/avutil.h > +++ b/libavutil/avutil.h > @@ -207,8 +207,7 @@ enum AVMediaType { > }; > > /** > - * Return a string describing the media_type enum, NULL if media_type > - * is unknown. > + * Return a string describing the media_type enum, never NULL. This is an API breakage, so it's not ok. The doxy states it returns NULL if media_type is unknown, so you're expected to check the returned pointer before trying to use it. > */ > const char *av_get_media_type_string(enum AVMediaType media_type); > > diff --git a/libavutil/utils.c b/libavutil/utils.c > index ea9b5097b8..c85d7abace 100644 > --- a/libavutil/utils.c > +++ b/libavutil/utils.c > @@ -71,12 +71,13 @@ const char *avutil_license(void) > const char *av_get_media_type_string(enum AVMediaType media_type) > { > switch (media_type) { > + case AVMEDIA_TYPE_UNKNOWN: return "unknown"; > case AVMEDIA_TYPE_VIDEO: return "video"; > case AVMEDIA_TYPE_AUDIO: return "audio"; > case AVMEDIA_TYPE_DATA: return "data"; > case AVMEDIA_TYPE_SUBTITLE: return "subtitle"; > case AVMEDIA_TYPE_ATTACHMENT: return "attachment"; > - default: return NULL; > + default: return "invalid"; > } > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".