Re: [FFmpeg-devel] [PATCH v4 2/3] avformat/imf: fix packet pts, dts and muxing

[Zane van Iperen <zane@zanevaniperen.com>]

On 17/2/22 02:54, pal@sandflow.com wrote:
>                   av_log(s,
>                          AV_LOG_DEBUG,
>                          "Switch resource on track %d: re-open context\n",
>                          track->index);
> -                if (open_track_resource_context(s, &(track->resources[i])) != 0)
> -                    return NULL;
> +
> +                ret = open_track_resource_context(s, &(track->resources[i]));

Nit: "track->resources + i" is easier to read imo

> +                if (ret != 0)
> +                    return ret;
>                   if (track->current_resource_index > 0)
>                       avformat_close_input(&track->resources[track->current_resource_index].ctx);
>                   track->current_resource_index = i;
>               }
>   
> -            return &(track->resources[track->current_resource_index]);
> +            *resource = &(track->resources[track->current_resource_index]);

Nit: track->resources + track->current_resource_index



The rest lgtm.

Will apply (with nits fixed) in a few days of no objections.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".