From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id EA90E442CC for ; Mon, 5 Sep 2022 02:47:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0312068B8C3; Mon, 5 Sep 2022 05:47:56 +0300 (EEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9893D68B6B6 for ; Mon, 5 Sep 2022 05:47:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1662346074; x=1693882074; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=/k0wb+rEiYp1c8CowwKv5wS9hP+hryqd7Xxn1TTvCnI=; b=lqBa3Z0THid4uXwSl46B6qTnnwoEjMTOmqXlmFTvFzikiaCXbQDHkQMh XPt1LEjSFkj4ReGh7BDZ9lGOTyr3AasII4+b41BO6B+X0GL0t0gab2LWz c6rBTbaVeFsWHaN9Z70D1Jsf0KtB8ETvlwvEAuxmRt/ETDrflFhzSSrXt 4oWTP/CqdoUBTcw2NFz9+tERn15sNDKGoXoVx2E86Fb9VNPwh38LnKt/k Xg44ittNenu/GxxbKTnyVhJ/lZuJE4M3IuRpWKFVe+0uyxEVoCwSQVQ81 2/qccEzTnv2WPEXINzcKq7nUX4kTQrhbPVb5e9Ae+ZkvvLe0QtVT7Dkc/ A==; X-IronPort-AV: E=McAfee;i="6500,9779,10460"; a="296296242" X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="296296242" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2022 19:47:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,290,1654585200"; d="scan'208";a="616260975" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 04 Sep 2022 19:47:47 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sun, 4 Sep 2022 19:47:46 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31 via Frontend Transport; Sun, 4 Sep 2022 19:47:46 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2375.31; Sun, 4 Sep 2022 19:47:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mTGW8xVCR0v7AiiyijykMFOzHqGj6MDA0iD6Wn0HMws1dIZ9tbltB3vZKGHy5YPy+bWtF7DKK5ttE68sHMNiCXplEKPguAvasehpPD1dX8l74TMBv9rYGYnqhnPMV5QpuFDakis5r2YCA/UDzGHefUjgmSwEFLMha122bj6klMCkkrMyVPxaBzm9eai2d3FTYzEJqQb7SySHC8xpf+wfx98XJt2tk26dtm1RA2IitP1H+rriv6O9Nz3q2ugeQbuUSI7r9uQkHkE1EBNG5EX7Ma9n+vA45wQArgzf18d9lbzdEyGfdILkAUutWEcCK16NyiuLPjqxm1TDIBvj6jteBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/k0wb+rEiYp1c8CowwKv5wS9hP+hryqd7Xxn1TTvCnI=; b=SWNg7wKJCaY+NIZ8qXAV9D2xRSKGUum2BqMOyfWFK9IHlqg+SeQJgaIkEaFS4WgSp4DwsoKs52sWSAmxl9x+1jm4aUiwx1ePonYNOsp6jxwSKKXjOTJ0JFuVv9OGf7vZfOH93GvFL3ygGup3HksC/bKTTdeQSnDm+/XNAB1fWaGSBPso+rm/uRyjSHjdrmGj28O4SXPIqdzgfdKjrAq70kBKvOAqvE3wG4bnT4FjXxfUsJY1KVCLHNJuRCYr6UL97ITRsoAyTR5ZEvVXb7gNzPW6zimaKMCIZw43MjlW2kQyaevQ2+5lYZDym1vLwOZxT8LA4ehBDCZpx/oUje0Zuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by SN6PR11MB2717.namprd11.prod.outlook.com (2603:10b6:805:60::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.16; Mon, 5 Sep 2022 02:47:44 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::8444:e015:794f:441b%2]) with mapi id 15.20.5588.012; Mon, 5 Sep 2022 02:47:44 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_qsv: add support for AV_PIX_FMT_VUYX Thread-Index: AQHYu5kOmk+o01FBFEqSCxkvkQhNOK3F6FkAgApEMoA= Date: Mon, 5 Sep 2022 02:47:44 +0000 Message-ID: References: <20220829072751.22395-1-haihao.xiang@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9358314f-8690-40ac-8ac6-08da8ee9028d x-ms-traffictypediagnostic: SN6PR11MB2717:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 1TdFeWo1fvCheyLhhqkxid//J5u6wbVRNXwkh62E1yevEjmcTyG1obsntGgWPhY6931zVoNIhIwkxUT3rvS02hwQAVuGqpAShV79i8AprXTwGcf8tjSNX4VEbRja2lWFOW2eO0kP9WdvHBgXWZBpUa3F+OnRUGw4EfKIw3YCiPUMUypZheLZkElNFUs7M6cWxFAtpZVudwxZXUpsxArVMtPaY+DxR6Ns7b1gutWK3O9i5m0c/ARGHmkTCqL2eV9OhXBlhVJ64JyB7w7yFYTRcABqqx1gw7C8JsyxhEL4o0REmp6qyv/5C8yrXKIYbBf6VFWqgIqt+x2pU/Q5Ykgj5ndhw72eMrmSg0ZwWYh2ol5nmbciXfx2S/7LNAY0DilKusLtYOjxtKe1ukttmafVHgxGnDxIhwhqH5tPHjJyqW54T3LRny1qWCuGdWRCY3M3jem0UFC4TNPnrgHZ8q7DZaGUzxr+xJYi9NFITfpjKhc/ouN4NU3najTl7wl9krh3h817O+ArQ2/PEx3lYBfdUFto3AZh5lNxdhpFYJoiftYjOi2IpO8pdh7UlzlWbApfkI1Of6UuNzfrEzYoRA/OMTHQ6UmoFv+T+wog+aMyWYOg6CoFDrwBU/3CNkEHodllZxH65SbahMg9odKld0AZZz67CFiFnzInTILIS1dx494/kmCNRyd3tFKfzBPPqHfJIY6FiIVDH//5QqMtmHkUtJsn+F1gOvIHo5q9xJ12zPjnlr1GxsYLSHr0ARr5owvLuqDIxoJkIni0JFker6SW6oEv26iLQEyv0uLSThDi0qw= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(376002)(396003)(136003)(366004)(346002)(39860400002)(91956017)(66946007)(66446008)(66556008)(478600001)(6916009)(316002)(66476007)(6486002)(45080400002)(2906002)(76116006)(122000001)(36756003)(86362001)(38100700002)(82960400001)(38070700005)(71200400001)(186003)(2616005)(53546011)(6506007)(26005)(6512007)(8676002)(5660300002)(41300700001)(64756008)(8936002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?Nlk1VWRGTHllNWF0YlBLU1BYT2lUc0tEMGl0Z08rV2RkaGtiYU5pRGdBYXQw?= =?utf-8?B?RWpVVi9rdVROOXdXRk9lUDBXTkduczMrR0N3S3hKUVAzL1Jhd1hVRlVGcXl3?= =?utf-8?B?Ui82L05VN0lFRmdUK21ZY2ZZUEJsZzM5NUVkZDJsWndxZUJ2ZDJXSHJmNTJI?= =?utf-8?B?YnlKTVpNc0pMSW15SEV2YnF6MXdFZGNkOFphU3RzZ1BKNFJQUXpFTW5EODcw?= =?utf-8?B?Ukw0ajZVV3JORjJCV0Jrb0lPOVovZ0I1bUdIUEQxSG1WVkRCWXB3RENSN2t1?= =?utf-8?B?dkJFYXgwT1c5RnBaZ3FVeTcxbW1XNEZZcy9TUXY3eENyb1Bnd1RrK3FYRCtx?= =?utf-8?B?MkFoSGFiR2FFOUVOUi9Mdjlzc05ya3Rqd240ZnJKdmNpaFdJWFJMYkZiOTBY?= =?utf-8?B?b1kwZTRrME5vRzlxSEptWGVZQkM3a25JcmNocXpCbkY5WXkrbW82QmVBT2Ri?= =?utf-8?B?TGw5eExpdDlKSFFtWU9PbnBwL1hWa2Irelg2RWR1NGsvMDBkTyt1cWpyalRS?= =?utf-8?B?VHVFcXp3amZNcnR6N3FGa3VsMFZ6bmt6OHRzRDRZVDB3TEE4b3U5UmFtK0xJ?= =?utf-8?B?dnJSd0J2dXg5NVBiZnFjQUZWb2JZOUFxYitpUFg3SG56QWRXYTdTckIvNmly?= =?utf-8?B?cXYrYTRWNFR1QWxSa2N6K3E2TWtKZy9SUmZjSi9rbHRyMmlORTBSeHZJM1dZ?= =?utf-8?B?UGx6OE5pMW1hcEl5aFpaQmhYRjdZeEdDeXVDaHI2Ui90V2hYYlVyVHR5b0tH?= =?utf-8?B?dkFQWUVraGN4ZXdjVE1wZGJVbWVEdHlTTnU3VWJhSjNvTGt1dTdkTVNtanhz?= =?utf-8?B?TUFrNGIvM1FNYzRNRTI5N1RCNHRQRGtZVWRJdE5vTTZYS1BGMDZ1NnRkR0lR?= =?utf-8?B?RFBaZFlsTlZyYmpWamdVZ2FGdGJLZFQrNXVWc29PVFJ6bkFPUjU1RVRRbHAw?= =?utf-8?B?TEFmUnVubldQaTQwclNETnZWM2pqcllzOGxZQy8xckwwR0NhZDdhekM1ODJv?= =?utf-8?B?NC9USVpyUjNHRElFWlN2S0hTRk1rQ2FMRDhDb3UvR21OenZPMG9Ca0VjeGN2?= =?utf-8?B?TTJiUGFtRDN0bXlGYnZiUW5nOFBtRHMzWGtKNDRXc1lnV09HY0ZrRkFiR25W?= =?utf-8?B?dW9NUDFIdjBaNE5WRkthM0JHUmxJb25zNDE2MXZPVjZjdStrWENSV1cxMUND?= =?utf-8?B?WFhBT1ZUdkJTQ2cxWEtkNkhjWHpVMmw4QWZMQVdudFZjbDhxUlpYNWNMNUJr?= =?utf-8?B?bm1DZ3pRRUdLNW1UaXVCcTBHMGJHRjE3RHAzQVpRN3VYSjdHd2g5Nm5RMDBH?= =?utf-8?B?QnlvVk1Nd0p6OVVpOTR0Qm9wdjBxR083eVZYSE9WR2pHb3pUWGtFMlVIeVdL?= =?utf-8?B?ZDBxWW93UWE0YVdQZW95V3ZocUltYXcwQ0h4S0RxVHNwZ1U4TCsydE1vcGZj?= =?utf-8?B?cll5c0RmejBPUUM4c0h2WUxZR1ZpbHJvaXplQzBNNS9NSXZ6VytUK3VnUWtr?= =?utf-8?B?NXl2QXZPR2JwQytZck9KMmErNERvUk8xQjBOM2phTjdxVStvbTFycTdIeDlL?= =?utf-8?B?RUVZMDFKdnQyeW5seHVYRURDbHBtcHJJYjJBVTM2cHNxYWcxWHdFYUpLN1dX?= =?utf-8?B?UlB5YnF0UnZ4RjBJMnpHY1hwRHdOdXJTcUVhV3VRNnRvcllITFhuRUZZb3pl?= =?utf-8?B?R3FDS3h6cDZqY01CUkxuNTd6UWYxcUVzdXE0bmRWWXFxcVBWOFRHNzR5QjhC?= =?utf-8?B?bFNtMHZ5RVhSSGZxeWFVcGxjZ1UwUUpoY2dJODMyaStvVzBGZTVPblRZNTgr?= =?utf-8?B?M3BRQnRTT1BYODFvOFpIR1dFTkhtSGN4VUVmL0NPbzhla3FreTYxMXFzZEdk?= =?utf-8?B?YU04RXpkblZtSm9RaWw0RnZidVEyYVczcVpHem1xbXdBOXRUL3JIT0pLVHky?= =?utf-8?B?MHcvdU5sZ3lDTGY0MU9SV1huWlEzbG02WXVxakY1TkMyRkpiVFhQNXh6UWV4?= =?utf-8?B?eitKOWpQTDA0NnZLMzFtdUg0M1VQZzNHdzdjaXNEU0d4WXJqQ1hXaE84SlUr?= =?utf-8?B?bFlDNFpPK0FMTk9PN3cwVzFEeWRDeUxLUEJ5emN5NVJiYnZLSFFvZ3FBVlYz?= =?utf-8?B?c3I4WnVWaFVjYWhJS290ZG1XelZiTlFhdytkVGFyOUEyd2tNVnhxVlR3eGFU?= =?utf-8?B?QWc9PQ==?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9358314f-8690-40ac-8ac6-08da8ee9028d X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Sep 2022 02:47:44.7388 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: FhWQ96uT/0QOMzz0+lMW2p5Hjfq3+fKlKBw1+so12R99fO9Fm0iRR467jAI6a6q3f6WP0po54kIaNAHJBzfYyw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB2717 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavu/hwcontext_qsv: add support for AV_PIX_FMT_VUYX X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 2022-08-29 at 14:01 +0000, Xiang, Haihao wrote: > On Mon, 2022-08-29 at 08:17 -0300, James Almer wrote: > > On 8/29/2022 4:27 AM, Xiang, Haihao wrote: > > > From: Haihao Xiang > > > > > > AV_PIX_FMT_VUYX is used in FFmpeg for 8bit 4:4:4 content on Intel HW, > > > and MFX_FOURCC_AYUV is used in the SDK > > > > Sounds like you want the VUYA pixfmt instead. > > AV_PIX_FMT_VUYX is used for 4:4:4 content in the VAAPI path, AV_PIX_FMT_VUYX > is > expected when creating vaapi urface. QSV is based on > VAAPI under Linux, so AV_PIX_FMT_VUYX is expected too in the QSV path when > creating vaapi surface. > > > > > > --- > > > libavutil/hwcontext_qsv.c | 8 ++++++++ > > > 1 file changed, 8 insertions(+) > > > > > > diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c > > > index 510f422562..a3350eae0f 100644 > > > --- a/libavutil/hwcontext_qsv.c > > > +++ b/libavutil/hwcontext_qsv.c > > > @@ -119,6 +119,8 @@ static const struct { > > > MFX_FOURCC_YUY2 }, > > > { AV_PIX_FMT_Y210, > > > MFX_FOURCC_Y210 }, > > > + { AV_PIX_FMT_VUYX, > > > + MFX_FOURCC_AYUV }, > > > #endif > > > }; > > > > > > @@ -1502,6 +1504,12 @@ static int map_frame_to_surface(const AVFrame > > > *frame, > > > mfxFrameSurface1 *surface) > > > surface->Data.U16 = (mfxU16 *)frame->data[0] + 1; > > > surface->Data.V16 = (mfxU16 *)frame->data[0] + 3; > > > break; > > > + case AV_PIX_FMT_VUYX: > > > + surface->Data.V = frame->data[0]; > > > + surface->Data.U = frame->data[0] + 1; > > > + surface->Data.Y = frame->data[0] + 2; > > > + surface->Data.A = frame->data[0] + 3; > > > > This will go wrong with VUYX. You need to use AV_PIX_FMT_VUYA. > > frame->data[0] + 3 is valid even if alpha channel is ignored in VUYX. Intel HW > doesn't use the data in alpha channel actually, but the SDK uses Microsoft > pixel > format AYUV which is the alpha version, here set a valid address to alpha > channel when mapping a VUYX AVFrame to a AYUV mfx surface. > Is there more comment about this patch ? Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".