From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id B514D4C22B for ; Thu, 6 Feb 2025 07:41:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8915968B9F2; Thu, 6 Feb 2025 09:41:11 +0200 (EET) Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE29668B407 for ; Thu, 6 Feb 2025 09:41:05 +0200 (EET) Received: by mail-qt1-f180.google.com with SMTP id d75a77b69052e-467a17055e6so8485901cf.3 for ; Wed, 05 Feb 2025 23:41:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738827664; x=1739432464; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=52dKhlKNVXvbhCv93IPuXhbLLqxryz9PLP4l11mxawY=; b=a1OXThsvjNNolr4sf6nyVUZAE1VsPtApyO+PKIZXRTr8XOBvrEthqF41QQZ2DwfknP DPb0OsVoM9YMLTeMS3Fwr+G/SdERqdva0JHfAswdjob6nhnAQ0pTHKjywHXyhcTtogrI 7dSaJLiuLqaFm8CE08HeJ2Jyp+NLsnh9Tx/+Gl/cpY2c1P+RtbxufAkGqWwb1qZLhR2S +4nRdZY1qX0zgtyNYgZlr76vPvwZaSOeNnT9+hM4Oqty+mDA5imt3wmCOZxIW9xHIvkL 6cA5Dl0zD5sTFlBkqKbEUA1s6RommJIj8sY3uPT1A4JCkQQ+3llShKxwnl8zjLlW9zPn JG3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738827664; x=1739432464; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=52dKhlKNVXvbhCv93IPuXhbLLqxryz9PLP4l11mxawY=; b=uC11oXXmFqHVBa3jQa+SAa4mVBmjCrWQtYxc5oufSxPBbr+ffWpTju5igYi/YGbO0B SOe1Frj+aHXuOIp33Wv1Y/Mqp0qkGIwMwANP0L9nedFPWn0j6OEJB3g9cdXF1CqDHdEu /friBF1N4kaim1JcM+/KFhjtFFlv2flTMHwr6zNSz8bY6EVAEzAHaJj1Q8dE+oHmABRt WYDswr6dP1LEcZ2AYO2FzPy0wFvqJ/WwHMch7GsEMGekqjwbrcfJn/na3FciJlslFxAc 8Zz4f5h4shkT8+KuO/Ji/oExevF6qgEvSdgmzRQB2L1lK7AdJY2W+1C2MsackqA/n61j cgkA== X-Gm-Message-State: AOJu0Yw3+vBpsxbvYMKUQnRcmF3vKN08OyxTs1uRSLc+ZkFrEZXe5V83 dW1W/81GH6Z5/A3Qu0LUJoqg/RSh/hIAwciQUdSxSemaSp9bRYxGrf6UUGhl X-Gm-Gg: ASbGncve/smpCy3IfSmY3rwVMWRcibrw8rhW77up6pHL/s27aj4m7NJ7rr99Y/lyli3 fUl2VlSugdWTXxMIx1EirKklPYmyqg5f6L5XpYBRAp//nnu8wUiSb1J+iYH3tqSYgjvRXXQxJcI /4oBbmFIg6r4J4+TXV8Q39lL8KF0YRmm0CeLRdwRIXtwJ3Y5cWQ/wpAPsPmlPZ03kcyfq158QK8 gQOOhznHcB9vAsbLgbmXAkBA7jkYk75w286gX8TNAwiwYI4oP53gSshy6Cl/f9XCOE7rQcKHD4G 8E3OjM14e40yc56JqVQ+TjVxhBrZWHhXvCb1dc7+wIJvFpircbJdYo1Qc0k5ADbp4BaXStM= X-Google-Smtp-Source: AGHT+IHUFQ37Tm6t4Ck8G6Im3vltBzERxv2GTK+wpb1GUz7flbsEQIntxoTXRYFTfDJoe5Zx883L+Q== X-Received: by 2002:a05:622a:130c:b0:46c:7276:7997 with SMTP id d75a77b69052e-4702818e232mr87633461cf.13.1738827664263; Wed, 05 Feb 2025 23:41:04 -0800 (PST) Received: from [192.168.1.35] (104-184-204-59.lightspeed.livnmi.sbcglobal.net. [104.184.204.59]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-47153beaa5csm3132411cf.68.2025.02.05.23.41.02 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Feb 2025 23:41:03 -0800 (PST) Message-ID: Date: Thu, 6 Feb 2025 02:41:01 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250206070047.152-1-torresefrain10@gmail.com> Content-Language: en-US-large From: Leo Izen Autocrypt: addr=leo.izen@gmail.com; keydata= xjMEZZw8HxYJKwYBBAHaRw8BAQdAgcfI+LbtjWarA7LQu6/WAPlKkn9tn4HalmHgGVhMUdzN KkxlbyBJemVuIChUcmFuZXB0b3JhKSA8bGVvLml6ZW5AZ21haWwuY29tPsKTBBMWCgA7FiEE HYMKC85GcJ4gOyb8dk5I6kgiGDMFAmWcPB8CGwMFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcC F4AACgkQdk5I6kgiGDOnGAEA+oJFwblAblnhK+T5a5EuEbXMTZG4FkYTYz0VmjJ0NHIA/Rn9 ZE9+EEsH8fmT0hRJSiM3+zbkwQJA9gVVYAek9kMKzjgEZZw8HxIKKwYBBAGXVQEFAQEHQDes 4thejF9AU2rkGuDuut3CQYwB4SVpI4EzU8uvPJgfAwEIB8J4BBgWCgAgFiEEHYMKC85GcJ4g Oyb8dk5I6kgiGDMFAmWcPB8CGwwACgkQdk5I6kgiGDOv3QD+PLXrL0Ihk675Ip5FG+VJOodN 6e+5n3iYC6wJ75eqG3EA/1nCywoGXlCYuzXgq3el6NOn+8awwaXcTVJFzZCRbe8M In-Reply-To: <20250206070047.152-1-torresefrain10@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avformat/unix: Set is_streamed to true X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2/6/25 2:00 AM, dank074 wrote: > Currently when a Unix Domain Socket is used as input there is a loss of data when data is consumed from the stream. Setting is_streamed to true fixes this, since the unix domain socket is now treated like a consumable stream. > > Fixes: #9346 > Signed-off-by: dank074 > --- > libavformat/unix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/unix.c b/libavformat/unix.c > index 5704155cf0..2de4023835 100644 > --- a/libavformat/unix.c > +++ b/libavformat/unix.c > @@ -89,7 +89,7 @@ static int unix_open(URLContext *h, const char *filename, int flags) > } > > s->fd = fd; > - > + h->is_streamed = 1; > return 0; > > fail: The patch looks fine as-is but two style nitpicks: - we like to have a full blank line between the return statement and the one before it, so you should add this line of code right after the line s->fd = fd; but not remove the blank line that was there - commit messages should be capped at 72 characters per line for historical reasons, so please insert newline characters in the commit message If there's no other objections I will push this patch and make both of these changes on my end, preserving authorship before I do, if that is okay with you. - Leo Izen (Traneptora) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".