From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A000046A9A for ; Wed, 2 Aug 2023 15:28:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 223F368C64A; Wed, 2 Aug 2023 18:28:31 +0300 (EEST) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE03E68C05A for ; Wed, 2 Aug 2023 18:28:24 +0300 (EEST) Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3a751bd3372so208780b6e.0 for ; Wed, 02 Aug 2023 08:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690990103; x=1691594903; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=q2eeKvkezW9afGHUHIjUgFLw80mvYCr6aNTa0mxxY0E=; b=nraS4uunMrAJKkYRCjhRrMF3gMm4aO4FbSfS3xxBx4NHhknUgc8qqwsN3su69UeebZ 3vb8MXVwxQL71eMc2duIe07zA6lSl1gsO36AQA3ea3r5CsUt7GmG1O8GlPT5wVoNaZ1N W7Xyxu7WI1rSy3LO04fxVezxg/g1hqpsoCH6O2fDZ46foNSCWE7P0VARQqb2k8ZI7pah L+od7qwEhJzZhtBEGKl2VDRl9jFsiX4gLALSVqyyiMD+Ti3/MBS2c/qhikN/rT2UpOO4 yFLFiBFiZ4dBkgM95xm3S0KpBP/aSBACJkehlku9NWfcSCZmo3eKK7TqpV1GW4TOZfV9 lm+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690990103; x=1691594903; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=q2eeKvkezW9afGHUHIjUgFLw80mvYCr6aNTa0mxxY0E=; b=cApA3FH2H9IGoezZwDlUcQnqZdmORqH6lRCtKAQ+fvAbX28gj+20cNf82ONck7uhT5 H2QZcg9tN6x2sQarmYKRXOP1nMIGXqtW1hzTn2IZy6mp9ZZcDN2iaowmmudqlYJUqX48 hrPOm/p10sFpmcZ3x0ASoFh3Z0sc+KKfjWq0ZSAGzGbo5+5b7X2ovg2y04qaGpMt02v6 VnWmJo1mKwC7w2R62tor3sMk3Pn7MzRB6WG8USbEkVev3z5qyxqc2q2EJyUN9xRh0Q7e WR1+r0Qd1DoxxcyrOpMTILE/Ei2wxtuKbrlQyeqiZTyTUsjAuK9sImoGlnyThwlwoAOm iXRg== X-Gm-Message-State: ABy/qLa/hsHaqj0WxvN41F4eSdp6mG8Zf3GpE0b+R9RM/5qAaWAX5ZWd zk5snzfcjpWmxOtRVpI+cI46s+MVp/Q= X-Google-Smtp-Source: APBJJlHqW5aDBI2HHIH2DyLGVYEgZnACNVq7ZXdVhGEG3WZ95IGBOINbJLhK/Ldg9Eyv03FjV54Tiw== X-Received: by 2002:a05:6808:17a2:b0:394:25b9:db19 with SMTP id bg34-20020a05680817a200b0039425b9db19mr14319527oib.2.1690990103019; Wed, 02 Aug 2023 08:28:23 -0700 (PDT) Received: from [192.168.1.35] (c-68-56-149-176.hsd1.mi.comcast.net. [68.56.149.176]) by smtp.gmail.com with ESMTPSA id n186-20020a25d6c3000000b00ca519aa8cf7sm3872295ybg.39.2023.08.02.08.28.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 02 Aug 2023 08:28:22 -0700 (PDT) Message-ID: Date: Wed, 2 Aug 2023 11:28:21 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20230801133055.256537-1-leo.izen@gmail.com> <20230801133055.256537-5-leo.izen@gmail.com> <20230801185942.GD7802@pb2> Content-Language: en-US-large From: Leo Izen In-Reply-To: <20230801185942.GD7802@pb2> Subject: Re: [FFmpeg-devel] [PATCH v6 4/5] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 8/1/23 14:59, Michael Niedermayer wrote: > On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote: >> This prevents code duplication in the source form by calling the parse >> code that was moved to avcodec last commit. The code will be duplicated >> in binary form for shared builds (it's not that large), but for source >> code it will only exist in one location now. >> >> Signed-off-by: Leo Izen >> --- >> libavformat/Makefile | 6 +- >> libavformat/img2dec.c | 4 +- >> libavformat/jpegxl_anim_dec.c | 132 +++-------- >> libavformat/jpegxl_probe.c | 412 ---------------------------------- >> libavformat/jpegxl_probe.h | 37 --- >> libavformat/version.h | 2 +- >> 6 files changed, 38 insertions(+), 555 deletions(-) >> delete mode 100644 libavformat/jpegxl_probe.c >> delete mode 100644 libavformat/jpegxl_probe.h > > breaks build with shared libs > Interesting, I have jpegxl_parse.o in SHLIOBJS, but the actual file is in libavcodec, and it's in libavcodec/Makefile's STLIOBJS declaration. What else do I need to do in order to allow it to link into libavformat? - Leo Izen _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".