From: Leo Izen <leo.izen@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH v6 4/5] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse
Date: Wed, 2 Aug 2023 11:28:21 -0400
Message-ID: <bcd077b4-76c3-d206-ee50-8f5db091977f@gmail.com> (raw)
In-Reply-To: <20230801185942.GD7802@pb2>
On 8/1/23 14:59, Michael Niedermayer wrote:
> On Tue, Aug 01, 2023 at 09:30:54AM -0400, Leo Izen wrote:
>> This prevents code duplication in the source form by calling the parse
>> code that was moved to avcodec last commit. The code will be duplicated
>> in binary form for shared builds (it's not that large), but for source
>> code it will only exist in one location now.
>>
>> Signed-off-by: Leo Izen <leo.izen@gmail.com>
>> ---
>> libavformat/Makefile | 6 +-
>> libavformat/img2dec.c | 4 +-
>> libavformat/jpegxl_anim_dec.c | 132 +++--------
>> libavformat/jpegxl_probe.c | 412 ----------------------------------
>> libavformat/jpegxl_probe.h | 37 ---
>> libavformat/version.h | 2 +-
>> 6 files changed, 38 insertions(+), 555 deletions(-)
>> delete mode 100644 libavformat/jpegxl_probe.c
>> delete mode 100644 libavformat/jpegxl_probe.h
>
> breaks build with shared libs
>
Interesting, I have jpegxl_parse.o in SHLIOBJS, but the actual file is
in libavcodec, and it's in libavcodec/Makefile's STLIOBJS declaration.
What else do I need to do in order to allow it to link into libavformat?
- Leo Izen
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-08-02 15:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 13:30 [FFmpeg-devel] [PATCH v6 0/5] JPEG XL Parser (and bug fixes) Leo Izen
2023-08-01 13:30 ` [FFmpeg-devel] [PATCH v6 1/5] avcodec/libjxldec: fix errors when decoding grayscale after rgb Leo Izen
2023-08-01 13:30 ` [FFmpeg-devel] [PATCH v6 2/5] avcodec/libjxldec: use internal AVFrame as buffered space Leo Izen
2023-08-01 13:30 ` [FFmpeg-devel] [PATCH v6 3/5] avcodec/jpegxl_parser: add JPEG XL parser Leo Izen
2023-08-01 13:30 ` [FFmpeg-devel] [PATCH v6 4/5] avformat/jpegxl: remove jpegxl_probe, instead call avcodec/jpegxl_parse Leo Izen
2023-08-01 18:59 ` Michael Niedermayer
2023-08-02 15:28 ` Leo Izen [this message]
2023-08-02 15:38 ` Andreas Rheinhardt
2023-08-01 13:30 ` [FFmpeg-devel] [PATCH v6 5/5] fate/jpegxl_anim: add demuxer fate test for jpegxl_anim Leo Izen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd077b4-76c3-d206-ee50-8f5db091977f@gmail.com \
--to=leo.izen@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git