From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/ffrtmpcrypt: Fix int-conversion warning
Date: Thu, 4 Jan 2024 14:47:08 +0200 (EET)
Message-ID: <bcb15e5-4022-8740-6298-e0cf6e5be76e@martin.st> (raw)
In-Reply-To: <f2dfc8d9-8773-4e72-8d49-98d8048f6bb0@frankplowman.com>
On Fri, 22 Dec 2023, Frank Plowman wrote:
> Hi Martin,
>
> Thanks for the review.
>
> On 22/12/2023 12:15, Martin Storsjö wrote:
>> The change LGTM, but the wording here is slightly confusing IMO. The
>> problem isn't with using per se AVERROR, that's just a macro for generating
>> suitable integers, the issue is more about the fact that we're returning
>> from a macro, without knowing the actual context where the macro is
>> invoked.
>>
>> WDYT about this wording?
>>
>>> The gcrypt definition of `bn_new` used to use the return statement on
>>> errors, with an AVERROR return value, regardless of the signature of the
>>> function where the macro is used - it is called in `dh_generate_key` and
>>> `ff_dh_init` which return pointers. As a result, compiling with gcrypt and
>>> the ffrtmpcrypt protocol resulted in an int-conversion warning. GCC 14 may
>>> upgrade these to errors [1].
>
> Yeah this is better, I agree.
Pushed now, thanks for the patch!
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2024-01-04 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 12:00 Frank Plowman
2023-12-22 12:15 ` Martin Storsjö
2023-12-22 12:35 ` Frank Plowman
2024-01-04 12:47 ` Martin Storsjö [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcb15e5-4022-8740-6298-e0cf6e5be76e@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git