Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö" <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] av_fopen_utf8 and cross-DLL CRT object sharing issue on Windows
Date: Mon, 9 May 2022 12:36:05 +0300 (EEST)
Message-ID: <bcabe9-20d6-40db-23d5-a093b95bd6c0@martin.st> (raw)
In-Reply-To: <DM8P223MB0365BF3DC896FFAF650F2BC7BAC69@DM8P223MB0365.NAMP223.PROD.OUTLOOK.COM>

On Mon, 9 May 2022, Soft Works wrote:

>> -----Original Message-----
>> From: ffmpeg-devel <ffmpeg-devel-bounces@ffmpeg.org> On Behalf Of
>> Martin Storsjö
>> Sent: Sunday, May 8, 2022 10:02 PM
>> To: FFmpeg development discussions and patches <ffmpeg-
>> devel@ffmpeg.org>
>> Subject: Re: [FFmpeg-devel] av_fopen_utf8 and cross-DLL CRT object
>> sharing issue on Windows
>>
>> On Sat, 7 May 2022, Soft Works wrote:
>>
>>>> This means that CRT objects (file descriptors from open(), FILE*
>>>> opened
>>>> with fopen/fdopen) mustn't be shared across DLLs; such an object
>> must
>>>> be
>>>> opened, accessed and closed within the same DLL.
>>>
>>> This only happens when you explicitly modify the build configuration
>>> to statically link to the CRT.
>>
>> No, this is not a custom build configuration. This is the build
>> configuration you get if you configure with "configure --enable-shared
>> --toolchain=msvc".
>
> Ok, then this is what needs to be fixed. When you configure for "shared",
> the exe and dll binaries need to be all compiled with /MD.

I disagree. Both (statically linked or dynamically linked CRT) are 
entirely valid configurations, and ffmpeg works fine (except for this 
particular, so far marginally used, function) in both those build 
configurations.

>> Also, another fairly common situation where the "different CRTs"
>> scenario
>> happens if you'd e.g. build the ffmpeg libraries as DLLs with mingw,
>> but
>> then link against those DLLs with a user application built with MSVC.
>
> AFAIK, it is possible to create DLLs with mingw/MSYS2 in a way that
> these can link to a specific version of the MS CRT, but that's just
> a side note.

Yes, that's true. (As a side note to this side note, I'm the one who added 
support for UCRT in mingw-w64 in the first place, so I do know a thing or 
two about that.)

But in short, yes it's possible to spend effort at making them use the 
same shared CRT, but it's also fairly common to use different CRTs.

// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2022-05-09  9:36 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 12:47 Martin Storsjö
2022-05-07  4:22 ` Soft Works
2022-05-07  4:32   ` Andreas Rheinhardt
2022-05-07  5:02     ` Soft Works
2022-05-08 20:11       ` Martin Storsjö
2022-05-09  0:30         ` Soft Works
2022-05-09  9:41           ` Martin Storsjö
2022-05-09 10:38             ` Soft Works
2022-05-09 10:47               ` Martin Storsjö
2022-05-09 10:53                 ` Soft Works
2022-05-08 20:01   ` Martin Storsjö
2022-05-09  0:28     ` Soft Works
2022-05-09  9:36       ` Martin Storsjö [this message]
2022-05-09 10:59         ` Soft Works

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bcabe9-20d6-40db-23d5-a093b95bd6c0@martin.st \
    --to=martin@martin.st \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git