From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id CF6C643498 for ; Thu, 14 Jul 2022 05:02:46 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8143A68B65F; Thu, 14 Jul 2022 08:02:43 +0300 (EEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A2CDE68A5E1 for ; Thu, 14 Jul 2022 08:02:37 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1657774962; x=1689310962; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-id:content-transfer-encoding: mime-version; bh=GhO55UIUkyNWAc58Jx3G4vRw68IZq+Lc3tegP3Hyzwo=; b=YFABIAQ8olqrAKn0EmGG+xkJCQvXvzgt5OHGMTCymmU0H61yzz8HsnUv ak46+xAOaFdjxXrTdvfH9iyAQmQvwLurdP4rWo5Y/f/mtUrZDXUglfd3N LaN2gymd+UzFVVxmCkVg/0slIKq3mhaZjXVqqgUcEvxDWZdDJYuhL54W4 lsV/mIFxPIOogx9oeoK7LTILvCdEMzNBWFzv+tplVehNITNt2mYIe0hpG IQ7aAdADxstwgaZ9FOyX1s449OggU6Dn3F/nU9A1wUYhuvlT+IWp0Vm55 hQTOLNDM5Rx+wgyUINUwA/VMoW+WchDXN/tPXY7Iuh+VE2rfVjGfKyMEZ Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10407"; a="371728307" X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="371728307" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jul 2022 22:02:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.92,269,1650956400"; d="scan'208";a="595957383" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP; 13 Jul 2022 22:02:35 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 13 Jul 2022 22:02:34 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 13 Jul 2022 22:02:34 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 13 Jul 2022 22:02:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DPEJtkzk88oC9BbExKCRq6D0MB/dFt8mz3Ap7d8JXtRU4J15XCKL4iNBkRoHeC5J6F9Ek9VetXzJthwr8FZt3zAJzvJgAgXxFfeNjSwheVSCRBRvC/zjZXDgUD612vmSmboKu3uYxsIK08fvuA8MYNO+RKQzzDY3B8YBRlrxoU5SarzGpzbYCPE7zIqgnJHKuE68xifhnmffsjMVGmvpxzXTr8oZ5y/LeLHoWe+LB5okCxz33pbPfs4XZlxf1M9eFBkBjaKNV1EZ0k6Qx73y6Jfdb40bcC6wLsL97vkkYCf8J64ifBF+ktqnArsKcayGFDzz8MGgdmAw7UruXish9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GhO55UIUkyNWAc58Jx3G4vRw68IZq+Lc3tegP3Hyzwo=; b=jV+toLZd1f85jwUqhsdv8VQ2/MHPL/EWZcJ0GKjpPubOCdrVu50EVRqOUDugHDX+SrSkQEPZP6JLI3DsD+UiqgUC/N+XnGk/9gcWGB8Ku7ZinWgeLnEuD6GNzFjIf8Mk5Ovd8OdbIJzn536JfWOyq0MCW3fHC/il1PMUAdfkBbeZFogfTv/hpffpZZXq6OHjtBU+iT804ylXOpguWS6Vov5xy/+BIPkSCPKQ/9MOFAkO5KXU+/P7eTTVDrW1cgJmBsk/wWLzuZzIHDBB0C9Dbty5zXLS4b9eHpne5+HULLxyApl93KCwRSLmQoyT955NgIF5qPOXQIi5rPGQova7SA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by DM6PR11MB4201.namprd11.prod.outlook.com (2603:10b6:5:200::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.16; Thu, 14 Jul 2022 05:02:27 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::f977:9a9f:bad7:d3ce%5]) with mapi id 15.20.5438.014; Thu, 14 Jul 2022 05:02:27 +0000 From: "Xiang, Haihao" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v2 3/4] lavc/hevc_refs: exclude current frame from long term refs Thread-Index: AQHYf45dNbAPiqwY0ECOpoc39ipCZ619frUA Date: Thu, 14 Jul 2022 05:02:27 +0000 Message-ID: References: <20220614012302.2808428-1-fei.w.wang@intel.com> <20220614012302.2808428-3-fei.w.wang@intel.com> In-Reply-To: <20220614012302.2808428-3-fei.w.wang@intel.com> Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0620673e-21b8-42ac-515e-08da65560c86 x-ms-traffictypediagnostic: DM6PR11MB4201:EE_ x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: L8QFh2kQD702vZNJbC8m1Ili6PywnJlMH/FAmEcv4AlCT+suKAOEivgC4xIM70RqEwdUlsCIeM85FpTAOVip/eafS0FfjWHeR9qgjiXrkLJbeyzrnFdd3IclG9/GgKpSw1KWvJIH9TZ497cQ5kQ1Lld7EJeGs33Jrzsanjp8yubFd7zYL7cUTP67BOTZIDHC1yHcrn6gLV/yGWb/Eye3m8adZxfChWleNZ/Efvy2qi8UTXt7pYhumB/6LimYYXsaMhlx33pfSt6OpLvRJwyLNe23F7DQiT1vzbsnNi0Tm5WpYaqJ2eEYGYdVT5QGyhm9+aZBzBkcJayLlT8CRASjg/o18zER5CLz89IqngS26qfKZuReVAt5CKfDdlxjl19oN9TIrqaR3Kz8jvUrYDpduNNplcl8tx2abtMkvB15NQ0pCcE7X7Gc20qdC91DLLdF+V5G+rmDhtgLurtk8IpssAquz4OI10U/yjWcFcN0gIBVOv5XtiuEncsJfjknvKD2Neot4PHR9a5uNrqx1tScD5yWoiWGVV0ayyyMEng0DXDVmgmiZ0MzsWgLIAC2dWNPZHtXtn3ecL6Q0NjjkpXz0nrV1WfzirytH3Y7rFxIWrVpJ1G4++0ZHdxBR9w9NiQB/UtuDUe7htyMmrBVhlqwuYpE1vTO3JHzfbdsUz1pHsjYEsqde7ZirKj45v7HEJofftcZiY49T5SL6gwgkc8Du67cZaB3JPk1pNac32zgjcSEl9n/OtxaLfJE5uLVBj8DqvXbn4kxYT75L08VLSWAV8moX4H/SmtCiHWj7IvoPw99yfPCtL4Aoy4FVfKk1ajChlWFSs4W9ddsfw3YxiqckA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(366004)(39860400002)(136003)(396003)(346002)(376002)(107886003)(86362001)(4326008)(186003)(38100700002)(5660300002)(122000001)(2616005)(66446008)(38070700005)(66476007)(82960400001)(478600001)(76116006)(66556008)(83380400001)(316002)(6916009)(66946007)(6486002)(91956017)(64756008)(54906003)(71200400001)(2906002)(41300700001)(6512007)(26005)(6506007)(36756003)(8936002)(8676002)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?WHBuT0toQm4yQTFDTUxnU25qUGR6ZGh5QndoaFNQcy9MTWpiNTF4SjFqd3VT?= =?utf-8?B?cXhwUmxWWC9uR1VPdlpzUTRxZUdvWE4xc3BINlB6SG9UR253NTgvTWtyYmdk?= =?utf-8?B?d0R2VThCVlllK0pDa0xXc2VFaWc0RlpkL1ZCZGVNV2hUNE85bWNoOFlXSVRa?= =?utf-8?B?aTlFR1RCT2JPQ2ZsK3BGVGVxZ1U5NERMSWtnS0dVMGFLdlNBam4yZ0U1ZW80?= =?utf-8?B?cEdORk1xUWJNTHlPUU5Qb3dJU2grWlVVVXNudVYzcXQ4Vm1MQ1NtWTF3d2dm?= =?utf-8?B?bDEyNXZtYnJjdFhPczI0MWR3TzJ2TU5OOU9LUEtNaittK29oT3VaRUE4VExW?= =?utf-8?B?dVV3K3lMTzFKeUpHMTA2dVl4THAxV0JQcHZjQlhQY2NGeUZ0Q04zV0RrYkJ3?= =?utf-8?B?UXpoNkNuUWVsdEZzUExoUUhMdXJMbUFjUm91dCtjRjIzcXo3SXhPay9nWkdJ?= =?utf-8?B?WVAzTjI1dWVOdElhelAwM0tWcDBtVUQvSHlZRG9JbU9RREU1ZzJZYWFjeTVF?= =?utf-8?B?WDRzRkJpaXNuVjQrZERyMjBHWlk2SEYveHcxSG9QQjZ5SDBTb2I5UGtJZ0Vv?= =?utf-8?B?bW5YVUlJUzNRcmllZGl3UHBqa1Bka3NkUVhlLzdQekFJcm9nVGpoVVB3T0Vl?= =?utf-8?B?alI0UVlOSDVKcm1mMzVmYTJlY3ZUNDNRMzUyTlhEbnc2aU5CRU5MbzArbGpB?= =?utf-8?B?UldVRDZweFlVQmJacXhlNCtzdnNLakhpUVM1YkNISFVoLytuMm1VMGhYRlRn?= =?utf-8?B?Zm4zbTFSbVYvQVd6cEx1dWIxbVZkNCt6SldtQU5tM3ArZHE3QXl2SVJNYkpx?= =?utf-8?B?REFTS0I0NkpiK1E1a3FXaFpJc0dzREQ4ckJ2VHlRVFNtVG8yUlZJdTNJV1Bk?= =?utf-8?B?RzR1WXBvNXZiZnFVb3FuaWVSZlpBcmlVZERoSzBneEdtWS92VmVKYy85UDgr?= =?utf-8?B?YVN1QVUvcGdmMTYvQXM5bEdGZWpBeEdLNzlhWXY2QTI5YUw4U3c0bHlBbFRs?= =?utf-8?B?VG81YkFjME5SVksyZnlWN0hHNmNjYXJPc2hoUU5OSDc2U2EyRkx6QjFHL0Ev?= =?utf-8?B?MC9YWU1BeUwzazdVTkhRTzZhR3lyL1ZCTkdvKzl1YmduaU0yVUN4SVczaldM?= =?utf-8?B?OUMxbUlMajVubC9HRG1KeWNGTHMrbFhXQXdkR1NPeFhoS3hZZktwd2ErSXJw?= =?utf-8?B?cU5CTUVtMk82bTR0ZHcvUFpMVWNUa2xocHhuK0RGd2dvLzg5Y2xNOTlReTVY?= =?utf-8?B?WW9pcGcwUm5CZVdCNCtTRXkyaXFRcE1zZ1NzdnQ5SGR3NkdISG5pczNMYmlR?= =?utf-8?B?Tm1Rb3JhWlZja05vc3NRZWJKcDRnSGRCL2szSlA2RnVEbk52TWhyY0pWeCt6?= =?utf-8?B?VTNJd2hmY3AzUHRkVERrdVpzamFoRS9OT1Q0dERINjg1QU4vektvalIzWnR4?= =?utf-8?B?ejFKQ3RmTnlHbkNkazZaSjZSYVZsMTkwRUJGZDBocHdKdmE0bnZ6Z1V2bDY0?= =?utf-8?B?UXprRk9EYUdoSFBMWmVTaUxGdERxa2RoaTJzRDJJV1Y0U0YxdFJOdFZJN0Za?= =?utf-8?B?aEs0TEhjNVRvODRiZFlwdkdjSENaSGNqaEs0dWprQ21QVk1BWnFvYk8rQ2hn?= =?utf-8?B?NkxOUDF5NkRBYVZNLzBHeTFDSldEOUh0TGlaK3RhRUpkQWFvUEExbm11Ylh2?= =?utf-8?B?elFxaEg1d2V3TTFVZXFNbHdRVDhyWTU3ZjlyMXd1TWJXblljOXEvNFR4NVlW?= =?utf-8?B?MElyd0VoRUUvYnVrSjJJWEJDcm5SQy9HLzFXL2hKM1Y4aURWaHZhZk9TWU5u?= =?utf-8?B?czVleXI5N2dWRm1veTZUQ0JObjFrWDhqZHlqcUtBOWdFd1FMMTRHV3ArVHZM?= =?utf-8?B?RzQreXdja3poK29mVnBERUE5Q0JHK21tTkpSS0tQUm1LZFI4UnB4azhjV2NM?= =?utf-8?B?T2k0R3lnUGVLTmtFU05yMS9pdjZVYnpBUm9yRUpJYWpzd0JNSnNmMXArUmtq?= =?utf-8?B?SG5vdkZnd2RPV1lCVUE4aXFWamdwYW9STHMxLzl1aVBHbDRCM3RXYWpsZFQw?= =?utf-8?B?U3VORkJ4OVpCWUV0L2dWTmUwbUJOT05nWGxzSGhIRlVwUmF6VXp3NEhyb1Vk?= =?utf-8?B?U3lrMFJaUDhtb1FVR0lPZkNhR3lXS1B3a0puMVcrLzZpRmp1ZzF6d0p2YkxZ?= =?utf-8?B?dkE9PQ==?= Content-ID: <49F88D3CE70EB74EA8AB838B2863BF5F@namprd11.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0620673e-21b8-42ac-515e-08da65560c86 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Jul 2022 05:02:27.7912 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +UC39QmqpPc1cTtEkSbs2iu0D/ozcOxUq3d4bKauaSS4ne9RxHLIbvZueKQyqWmRlxmPusUxxGwwvukyeb90dg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4201 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v2 3/4] lavc/hevc_refs: exclude current frame from long term refs X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "Xu, Guangxin" , "Wang, Fei W" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 2022-06-14 at 09:23 +0800, Fei Wang wrote: > From: Xu Guangxin > > suppose > a. You have 3 frames, 0, 1, 4096. > b. The ltMask is 0xfff and use_msb is 0. > c. The 0, 1 are lt refs for 4096. > d. you are decoding frame 4096, and get the 0 frame. > Since 4096 & ltMask is 0 too, even you want get 0, find_ref_idx may give you > 4096. > add_candidate_ref will report an error for this > > Tested-by: Fei Wang > Signed-off-by: Xu Guangxin > --- > libavcodec/hevc_refs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/hevc_refs.c b/libavcodec/hevc_refs.c > index 89053fd1a2..b3d5f96043 100644 > --- a/libavcodec/hevc_refs.c > +++ b/libavcodec/hevc_refs.c > @@ -386,7 +386,7 @@ static HEVCFrame *find_ref_idx(HEVCContext *s, int poc, > uint8_t use_msb) > for (i = 0; i < FF_ARRAY_ELEMS(s->DPB); i++) { > HEVCFrame *ref = &s->DPB[i]; > if (ref->frame->buf[0] && ref->sequence == s->seq_decode) { > - if ((ref->poc & mask) == poc) > + if ((ref->poc & mask) == poc && (use_msb || ref->poc != s->poc)) > return ref; > } > } LGTM -Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".